From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, mjt@tls.msk.ru,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq
Date: Wed, 12 Nov 2014 12:41:53 +0100 [thread overview]
Message-ID: <54634781.5040606@redhat.com> (raw)
In-Reply-To: <1415791795-6779-1-git-send-email-famz@redhat.com>
On 12/11/2014 12:29, Fam Zheng wrote:
> The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading
> comment.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> include/hw/virtio/virtio-scsi.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> index 9e1a49c..bf17cc9 100644
> --- a/include/hw/virtio/virtio-scsi.h
> +++ b/include/hw/virtio/virtio-scsi.h
> @@ -209,7 +209,8 @@ typedef struct VirtIOSCSIReq {
> /* Note:
> * - fields before elem are initialized by virtio_scsi_init_req;
> * - elem is uninitialized at the time of allocation.
> - * - fields after elem are zeroed by virtio_scsi_init_req.
> + * - fields after elem (except the ending cdb[]) are zeroed by
> + * virtio_scsi_init_req.
> * */
>
> VirtQueueElement elem;
>
Applied, thanks.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, mjt@tls.msk.ru,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq
Date: Wed, 12 Nov 2014 12:41:53 +0100 [thread overview]
Message-ID: <54634781.5040606@redhat.com> (raw)
In-Reply-To: <1415791795-6779-1-git-send-email-famz@redhat.com>
On 12/11/2014 12:29, Fam Zheng wrote:
> The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading
> comment.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> include/hw/virtio/virtio-scsi.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> index 9e1a49c..bf17cc9 100644
> --- a/include/hw/virtio/virtio-scsi.h
> +++ b/include/hw/virtio/virtio-scsi.h
> @@ -209,7 +209,8 @@ typedef struct VirtIOSCSIReq {
> /* Note:
> * - fields before elem are initialized by virtio_scsi_init_req;
> * - elem is uninitialized at the time of allocation.
> - * - fields after elem are zeroed by virtio_scsi_init_req.
> + * - fields after elem (except the ending cdb[]) are zeroed by
> + * virtio_scsi_init_req.
> * */
>
> VirtQueueElement elem;
>
Applied, thanks.
Paolo
next prev parent reply other threads:[~2014-11-12 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 11:29 [Qemu-trivial] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq Fam Zheng
2014-11-12 11:29 ` [Qemu-devel] " Fam Zheng
2014-11-12 11:41 ` Paolo Bonzini [this message]
2014-11-12 11:41 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54634781.5040606@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.