* [Qemu-trivial] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq
@ 2014-11-12 11:29 ` Fam Zheng
0 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2014-11-12 11:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, mjt, Markus Armbruster
The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading
comment.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
include/hw/virtio/virtio-scsi.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
index 9e1a49c..bf17cc9 100644
--- a/include/hw/virtio/virtio-scsi.h
+++ b/include/hw/virtio/virtio-scsi.h
@@ -209,7 +209,8 @@ typedef struct VirtIOSCSIReq {
/* Note:
* - fields before elem are initialized by virtio_scsi_init_req;
* - elem is uninitialized at the time of allocation.
- * - fields after elem are zeroed by virtio_scsi_init_req.
+ * - fields after elem (except the ending cdb[]) are zeroed by
+ * virtio_scsi_init_req.
* */
VirtQueueElement elem;
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq
@ 2014-11-12 11:29 ` Fam Zheng
0 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2014-11-12 11:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, mjt, Markus Armbruster
The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading
comment.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
include/hw/virtio/virtio-scsi.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
index 9e1a49c..bf17cc9 100644
--- a/include/hw/virtio/virtio-scsi.h
+++ b/include/hw/virtio/virtio-scsi.h
@@ -209,7 +209,8 @@ typedef struct VirtIOSCSIReq {
/* Note:
* - fields before elem are initialized by virtio_scsi_init_req;
* - elem is uninitialized at the time of allocation.
- * - fields after elem are zeroed by virtio_scsi_init_req.
+ * - fields after elem (except the ending cdb[]) are zeroed by
+ * virtio_scsi_init_req.
* */
VirtQueueElement elem;
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-trivial] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq
2014-11-12 11:29 ` [Qemu-devel] " Fam Zheng
@ 2014-11-12 11:41 ` Paolo Bonzini
-1 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2014-11-12 11:41 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: qemu-trivial, mjt, Markus Armbruster
On 12/11/2014 12:29, Fam Zheng wrote:
> The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading
> comment.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> include/hw/virtio/virtio-scsi.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> index 9e1a49c..bf17cc9 100644
> --- a/include/hw/virtio/virtio-scsi.h
> +++ b/include/hw/virtio/virtio-scsi.h
> @@ -209,7 +209,8 @@ typedef struct VirtIOSCSIReq {
> /* Note:
> * - fields before elem are initialized by virtio_scsi_init_req;
> * - elem is uninitialized at the time of allocation.
> - * - fields after elem are zeroed by virtio_scsi_init_req.
> + * - fields after elem (except the ending cdb[]) are zeroed by
> + * virtio_scsi_init_req.
> * */
>
> VirtQueueElement elem;
>
Applied, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq
@ 2014-11-12 11:41 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2014-11-12 11:41 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: qemu-trivial, mjt, Markus Armbruster
On 12/11/2014 12:29, Fam Zheng wrote:
> The cdb is not zeroed by virtio_scsi_init_req, so fix the misleading
> comment.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> include/hw/virtio/virtio-scsi.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> index 9e1a49c..bf17cc9 100644
> --- a/include/hw/virtio/virtio-scsi.h
> +++ b/include/hw/virtio/virtio-scsi.h
> @@ -209,7 +209,8 @@ typedef struct VirtIOSCSIReq {
> /* Note:
> * - fields before elem are initialized by virtio_scsi_init_req;
> * - elem is uninitialized at the time of allocation.
> - * - fields after elem are zeroed by virtio_scsi_init_req.
> + * - fields after elem (except the ending cdb[]) are zeroed by
> + * virtio_scsi_init_req.
> * */
>
> VirtQueueElement elem;
>
Applied, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-12 11:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-12 11:29 [Qemu-trivial] [PATCH] virtio-scsi: Fix comment for VirtIOSCSIReq Fam Zheng
2014-11-12 11:29 ` [Qemu-devel] " Fam Zheng
2014-11-12 11:41 ` [Qemu-trivial] " Paolo Bonzini
2014-11-12 11:41 ` [Qemu-devel] " Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.