All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, linux-mmc@vger.kernel.org
Cc: Chris Ball <chris@printf.net>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC] mmc: sh_mmcif: Increase MMCIF clock rate to 97.5MHz
Date: Wed, 12 Nov 2014 16:40:58 +0300	[thread overview]
Message-ID: <5463636A.1060608@cogentembedded.com> (raw)
In-Reply-To: <1415688142-20023-1-git-send-email-ykaneko0929@gmail.com>

Hello.

On 11/11/2014 9:42 AM, Yoshihiro Kaneko wrote:

> From: Shinobu Uehara <shinobu.uehara.xc@renesas.com>

> Signed-off-by: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---

> This patch is based on mmc-next branch of Chris Ball's mmc tree.

>   drivers/mmc/host/sh_mmcif.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)

> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index 656fbba..fe9a8b7 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
[...]
> @@ -1371,6 +1373,8 @@ static int sh_mmcif_probe(struct platform_device *pdev)
>   	struct resource *res;
>   	void __iomem *reg;
>   	const char *name;
> +	struct device_node *np = pdev->dev.of_node;
> +	int clk_rate;

    'u32'.

>
>   	irq[0] = platform_get_irq(pdev, 0);
>   	irq[1] = platform_get_irq(pdev, 1);
> @@ -1433,6 +1437,16 @@ static int sh_mmcif_probe(struct platform_device *pdev)
>   		dev_err(&pdev->dev, "cannot get clock: %d\n", ret);
>   		goto eclkget;
>   	}
> +
> +	if (np && !of_property_read_u32(np, "renesas,clk-rate", &clk_rate)) {

    Doesn't the standard "clock-frequency" prop fit here?

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, linux-mmc@vger.kernel.org
Cc: Chris Ball <chris@printf.net>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC] mmc: sh_mmcif: Increase MMCIF clock rate to 97.5MHz
Date: Wed, 12 Nov 2014 13:40:58 +0000	[thread overview]
Message-ID: <5463636A.1060608@cogentembedded.com> (raw)
In-Reply-To: <1415688142-20023-1-git-send-email-ykaneko0929@gmail.com>

Hello.

On 11/11/2014 9:42 AM, Yoshihiro Kaneko wrote:

> From: Shinobu Uehara <shinobu.uehara.xc@renesas.com>

> Signed-off-by: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---

> This patch is based on mmc-next branch of Chris Ball's mmc tree.

>   drivers/mmc/host/sh_mmcif.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)

> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index 656fbba..fe9a8b7 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
[...]
> @@ -1371,6 +1373,8 @@ static int sh_mmcif_probe(struct platform_device *pdev)
>   	struct resource *res;
>   	void __iomem *reg;
>   	const char *name;
> +	struct device_node *np = pdev->dev.of_node;
> +	int clk_rate;

    'u32'.

>
>   	irq[0] = platform_get_irq(pdev, 0);
>   	irq[1] = platform_get_irq(pdev, 1);
> @@ -1433,6 +1437,16 @@ static int sh_mmcif_probe(struct platform_device *pdev)
>   		dev_err(&pdev->dev, "cannot get clock: %d\n", ret);
>   		goto eclkget;
>   	}
> +
> +	if (np && !of_property_read_u32(np, "renesas,clk-rate", &clk_rate)) {

    Doesn't the standard "clock-frequency" prop fit here?

WBR, Sergei


  parent reply	other threads:[~2014-11-12 13:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11  6:42 [PATCH/RFC] mmc: sh_mmcif: Increase MMCIF clock rate to 97.5MHz Yoshihiro Kaneko
2014-11-11  6:42 ` Yoshihiro Kaneko
2014-11-12  8:37 ` Ulf Hansson
2014-11-12  8:37   ` Ulf Hansson
2014-11-12 13:40 ` Sergei Shtylyov [this message]
2014-11-12 13:40   ` Sergei Shtylyov
2014-11-13  0:15 ` Kuninori Morimoto
2014-11-13  0:24   ` Simon Horman
2014-11-13  0:24     ` Simon Horman
2014-11-13  1:34     ` Kuninori Morimoto
2014-11-21  4:09       ` Simon Horman
2014-11-21  4:09         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5463636A.1060608@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=chris@printf.net \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=ulf.hansson@linaro.org \
    --cc=ykaneko0929@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.