[PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Andreas Färber]

The specification requires xlnx,data-width, but example and driver use
xlnx,datawidth. Change the specification to match the implementation.

Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Fixes: eebeac03db93 ("dma: Add Xilinx Video DMA DT Binding Documentation")
Signed-off-by: Andreas F?rber <afaerber@suse.de>
---
 This appears to have fallen through the cracks... resending to dmaengine.

 Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
index 1405ed071bb4..e4c4d47f8137 100644
--- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
+++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
@@ -25,7 +25,7 @@ Required child node properties:
 - compatible: It should be either "xlnx,axi-vdma-mm2s-channel" or
 	"xlnx,axi-vdma-s2mm-channel".
 - interrupts: Should contain per channel VDMA interrupts.
-- xlnx,data-width: Should contain the stream data width, take values
+- xlnx,datawidth: Should contain the stream data width, take values
 	{32,64...1024}.
 
 Optional child node properties:
-- 
2.1.2

[PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Andreas Färber]

The specification requires xlnx,data-width, but example and driver use
xlnx,datawidth. Change the specification to match the implementation.

Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Fixes: eebeac03db93 ("dma: Add Xilinx Video DMA DT Binding Documentation")
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 This appears to have fallen through the cracks... resending to dmaengine.

 Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
index 1405ed071bb4..e4c4d47f8137 100644
--- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
+++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
@@ -25,7 +25,7 @@ Required child node properties:
 - compatible: It should be either "xlnx,axi-vdma-mm2s-channel" or
 	"xlnx,axi-vdma-s2mm-channel".
 - interrupts: Should contain per channel VDMA interrupts.
-- xlnx,data-width: Should contain the stream data width, take values
+- xlnx,datawidth: Should contain the stream data width, take values
 	{32,64...1024}.
 
 Optional child node properties:
-- 
2.1.2

[PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Andreas Färber]

The specification requires xlnx,data-width, but example and driver use
xlnx,datawidth. Change the specification to match the implementation.

Reviewed-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Fixes: eebeac03db93 ("dma: Add Xilinx Video DMA DT Binding Documentation")
Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org>
---
 This appears to have fallen through the cracks... resending to dmaengine.

 Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
index 1405ed071bb4..e4c4d47f8137 100644
--- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
+++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
@@ -25,7 +25,7 @@ Required child node properties:
 - compatible: It should be either "xlnx,axi-vdma-mm2s-channel" or
 	"xlnx,axi-vdma-s2mm-channel".
 - interrupts: Should contain per channel VDMA interrupts.
-- xlnx,data-width: Should contain the stream data width, take values
+- xlnx,datawidth: Should contain the stream data width, take values
 	{32,64...1024}.
 
 Optional child node properties:
-- 
2.1.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Sören Brinkmann]

On Wed, 2014-11-12 at 02:51PM +0100, Andreas F?rber wrote:
> The specification requires xlnx,data-width, but example and driver use
> xlnx,datawidth. Change the specification to match the implementation.

Isn't this the wrong way around? The bindings are considered API, so
shouldn't the driver be fixed to match the spec?
Are there already dts files out there using either of these options?

	Soren

Re: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Sören Brinkmann]

On Wed, 2014-11-12 at 02:51PM +0100, Andreas Färber wrote:
> The specification requires xlnx,data-width, but example and driver use
> xlnx,datawidth. Change the specification to match the implementation.

Isn't this the wrong way around? The bindings are considered API, so
shouldn't the driver be fixed to match the spec?
Are there already dts files out there using either of these options?

	Soren

Re: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Sören Brinkmann]

On Wed, 2014-11-12 at 02:51PM +0100, Andreas Färber wrote:
> The specification requires xlnx,data-width, but example and driver use
> xlnx,datawidth. Change the specification to match the implementation.

Isn't this the wrong way around? The bindings are considered API, so
shouldn't the driver be fixed to match the spec?
Are there already dts files out there using either of these options?

	Soren

[PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Andreas Färber]

Am 12.11.2014 um 16:57 schrieb S?ren Brinkmann:
> On Wed, 2014-11-12 at 02:51PM +0100, Andreas F?rber wrote:
>> The specification requires xlnx,data-width, but example and driver use
>> xlnx,datawidth. Change the specification to match the implementation.
> 
> Isn't this the wrong way around? The bindings are considered API, so
> shouldn't the driver be fixed to match the spec?

In theory, patch review should've never let the two differ... ;)

It's not my driver, so I fixed the perceived inconsistency the least
invasive way; Michal and Srikanth seemed to concur at the time.

https://patchwork.kernel.org/patch/4620261/

> Are there already dts files out there using either of these options?

In upstream, no. microblaze and virtex440 use a
xlnx,include-datawidth-matching-0 property as precedence for the
spelling, whereas there is an fsl,data-width and an unused msix-data-width.

Downstream, yes: Beyond my own patch derived from the Parallella tree,
there's some in the ADI tree. None in the Xilinx tree on quick check.

I haven't encountered any using the documented xlnx,data-width - but
this patch was authored pre 3.17, haven't ran a full Web search again.

Regards,
Andreas

-- 
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 21284 AG N?rnberg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141112/d7c7c1f9/attachment.sig>

Re: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Andreas Färber]

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

Am 12.11.2014 um 16:57 schrieb Sören Brinkmann:
> On Wed, 2014-11-12 at 02:51PM +0100, Andreas Färber wrote:
>> The specification requires xlnx,data-width, but example and driver use
>> xlnx,datawidth. Change the specification to match the implementation.
> 
> Isn't this the wrong way around? The bindings are considered API, so
> shouldn't the driver be fixed to match the spec?

In theory, patch review should've never let the two differ... ;)

It's not my driver, so I fixed the perceived inconsistency the least
invasive way; Michal and Srikanth seemed to concur at the time.

https://patchwork.kernel.org/patch/4620261/

> Are there already dts files out there using either of these options?

In upstream, no. microblaze and virtex440 use a
xlnx,include-datawidth-matching-0 property as precedence for the
spelling, whereas there is an fsl,data-width and an unused msix-data-width.

Downstream, yes: Beyond my own patch derived from the Parallella tree,
there's some in the ADI tree. None in the Xilinx tree on quick check.

I haven't encountered any using the documented xlnx,data-width - but
this patch was authored pre 3.17, haven't ran a full Web search again.

Regards,
Andreas

-- 
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Sören Brinkmann]

On Wed, 2014-11-12 at 07:03PM +0100, Andreas F?rber wrote:
> Am 12.11.2014 um 16:57 schrieb S?ren Brinkmann:
> > On Wed, 2014-11-12 at 02:51PM +0100, Andreas F?rber wrote:
> >> The specification requires xlnx,data-width, but example and driver use
> >> xlnx,datawidth. Change the specification to match the implementation.
> > 
> > Isn't this the wrong way around? The bindings are considered API, so
> > shouldn't the driver be fixed to match the spec?
> 
> In theory, patch review should've never let the two differ... ;)
> 
> It's not my driver, so I fixed the perceived inconsistency the least
> invasive way; Michal and Srikanth seemed to concur at the time.
> 
> https://patchwork.kernel.org/patch/4620261/
> 
> > Are there already dts files out there using either of these options?
> 
> In upstream, no. microblaze and virtex440 use a
> xlnx,include-datawidth-matching-0 property as precedence for the
> spelling, whereas there is an fsl,data-width and an unused msix-data-width.
> 
> Downstream, yes: Beyond my own patch derived from the Parallella tree,
> there's some in the ADI tree. None in the Xilinx tree on quick check.
> 
> I haven't encountered any using the documented xlnx,data-width - but
> this patch was authored pre 3.17, haven't ran a full Web search again.

grepping through linux-next shows some usage of xlnx,datawidth, but
only the single hit in  Documentation for xlnx,data-width.
Other than VDMA the other hit seems to be just some DT
documentation which I can't find a driver for...
Anyhow, this patch is probably the best way of fixing this.

Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

	Thanks,
	S?ren

Re: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Sören Brinkmann]

On Wed, 2014-11-12 at 07:03PM +0100, Andreas Färber wrote:
> Am 12.11.2014 um 16:57 schrieb Sören Brinkmann:
> > On Wed, 2014-11-12 at 02:51PM +0100, Andreas Färber wrote:
> >> The specification requires xlnx,data-width, but example and driver use
> >> xlnx,datawidth. Change the specification to match the implementation.
> > 
> > Isn't this the wrong way around? The bindings are considered API, so
> > shouldn't the driver be fixed to match the spec?
> 
> In theory, patch review should've never let the two differ... ;)
> 
> It's not my driver, so I fixed the perceived inconsistency the least
> invasive way; Michal and Srikanth seemed to concur at the time.
> 
> https://patchwork.kernel.org/patch/4620261/
> 
> > Are there already dts files out there using either of these options?
> 
> In upstream, no. microblaze and virtex440 use a
> xlnx,include-datawidth-matching-0 property as precedence for the
> spelling, whereas there is an fsl,data-width and an unused msix-data-width.
> 
> Downstream, yes: Beyond my own patch derived from the Parallella tree,
> there's some in the ADI tree. None in the Xilinx tree on quick check.
> 
> I haven't encountered any using the documented xlnx,data-width - but
> this patch was authored pre 3.17, haven't ran a full Web search again.

grepping through linux-next shows some usage of xlnx,datawidth, but
only the single hit in  Documentation for xlnx,data-width.
Other than VDMA the other hit seems to be just some DT
documentation which I can't find a driver for...
Anyhow, this patch is probably the best way of fixing this.

Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

	Thanks,
	Sören

Re: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Sören Brinkmann]

On Wed, 2014-11-12 at 07:03PM +0100, Andreas Färber wrote:
> Am 12.11.2014 um 16:57 schrieb Sören Brinkmann:
> > On Wed, 2014-11-12 at 02:51PM +0100, Andreas Färber wrote:
> >> The specification requires xlnx,data-width, but example and driver use
> >> xlnx,datawidth. Change the specification to match the implementation.
> > 
> > Isn't this the wrong way around? The bindings are considered API, so
> > shouldn't the driver be fixed to match the spec?
> 
> In theory, patch review should've never let the two differ... ;)
> 
> It's not my driver, so I fixed the perceived inconsistency the least
> invasive way; Michal and Srikanth seemed to concur at the time.
> 
> https://patchwork.kernel.org/patch/4620261/
> 
> > Are there already dts files out there using either of these options?
> 
> In upstream, no. microblaze and virtex440 use a
> xlnx,include-datawidth-matching-0 property as precedence for the
> spelling, whereas there is an fsl,data-width and an unused msix-data-width.
> 
> Downstream, yes: Beyond my own patch derived from the Parallella tree,
> there's some in the ADI tree. None in the Xilinx tree on quick check.
> 
> I haven't encountered any using the documented xlnx,data-width - but
> this patch was authored pre 3.17, haven't ran a full Web search again.

grepping through linux-next shows some usage of xlnx,datawidth, but
only the single hit in  Documentation for xlnx,data-width.
Other than VDMA the other hit seems to be just some DT
documentation which I can't find a driver for...
Anyhow, this patch is probably the best way of fixing this.

Reviewed-by: Soren Brinkmann <soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>

	Thanks,
	Sören
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Vinod Koul]

On Wed, Nov 12, 2014 at 10:26:03AM -0800, S?ren Brinkmann wrote:
> On Wed, 2014-11-12 at 07:03PM +0100, Andreas F?rber wrote:
> > Am 12.11.2014 um 16:57 schrieb S?ren Brinkmann:
> > > On Wed, 2014-11-12 at 02:51PM +0100, Andreas F?rber wrote:
> > >> The specification requires xlnx,data-width, but example and driver use
> > >> xlnx,datawidth. Change the specification to match the implementation.
> > > 
> > > Isn't this the wrong way around? The bindings are considered API, so
> > > shouldn't the driver be fixed to match the spec?
> > 
> > In theory, patch review should've never let the two differ... ;)
> > 
> > It's not my driver, so I fixed the perceived inconsistency the least
> > invasive way; Michal and Srikanth seemed to concur at the time.
> > 
> > https://patchwork.kernel.org/patch/4620261/
> > 
> > > Are there already dts files out there using either of these options?
> > 
> > In upstream, no. microblaze and virtex440 use a
> > xlnx,include-datawidth-matching-0 property as precedence for the
> > spelling, whereas there is an fsl,data-width and an unused msix-data-width.
> > 
> > Downstream, yes: Beyond my own patch derived from the Parallella tree,
> > there's some in the ADI tree. None in the Xilinx tree on quick check.
> > 
> > I haven't encountered any using the documented xlnx,data-width - but
> > this patch was authored pre 3.17, haven't ran a full Web search again.
> 
> grepping through linux-next shows some usage of xlnx,datawidth, but
> only the single hit in  Documentation for xlnx,data-width.
> Other than VDMA the other hit seems to be just some DT
> documentation which I can't find a driver for...
> Anyhow, this patch is probably the best way of fixing this.
the driver had issues so want applied, I havent seen repot though. 
Will apply this now

-- 
~Vinod

> 
> Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> 
> 	Thanks,
> 	S?ren

-- 

Re: [PATCH RESEND] Documentation: devicetree: Fix Xilinx VDMA specification

[Vinod Koul]

On Wed, Nov 12, 2014 at 10:26:03AM -0800, Sören Brinkmann wrote:
> On Wed, 2014-11-12 at 07:03PM +0100, Andreas Färber wrote:
> > Am 12.11.2014 um 16:57 schrieb Sören Brinkmann:
> > > On Wed, 2014-11-12 at 02:51PM +0100, Andreas Färber wrote:
> > >> The specification requires xlnx,data-width, but example and driver use
> > >> xlnx,datawidth. Change the specification to match the implementation.
> > > 
> > > Isn't this the wrong way around? The bindings are considered API, so
> > > shouldn't the driver be fixed to match the spec?
> > 
> > In theory, patch review should've never let the two differ... ;)
> > 
> > It's not my driver, so I fixed the perceived inconsistency the least
> > invasive way; Michal and Srikanth seemed to concur at the time.
> > 
> > https://patchwork.kernel.org/patch/4620261/
> > 
> > > Are there already dts files out there using either of these options?
> > 
> > In upstream, no. microblaze and virtex440 use a
> > xlnx,include-datawidth-matching-0 property as precedence for the
> > spelling, whereas there is an fsl,data-width and an unused msix-data-width.
> > 
> > Downstream, yes: Beyond my own patch derived from the Parallella tree,
> > there's some in the ADI tree. None in the Xilinx tree on quick check.
> > 
> > I haven't encountered any using the documented xlnx,data-width - but
> > this patch was authored pre 3.17, haven't ran a full Web search again.
> 
> grepping through linux-next shows some usage of xlnx,datawidth, but
> only the single hit in  Documentation for xlnx,data-width.
> Other than VDMA the other hit seems to be just some DT
> documentation which I can't find a driver for...
> Anyhow, this patch is probably the best way of fixing this.
the driver had issues so want applied, I havent seen repot though. 
Will apply this now

-- 
~Vinod

> 
> Reviewed-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> 
> 	Thanks,
> 	Sören

--