From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/4] simplefb: Change simplefb_init from module_init to fs_initcall
Date: Thu, 13 Nov 2014 14:32:42 +0000 [thread overview]
Message-ID: <5464C10A.30709@ti.com> (raw)
In-Reply-To: <1415885645-24613-3-git-send-email-hdegoede@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
On 13/11/14 15:34, Hans de Goede wrote:
> One of the reasons for having the simplefb nodes in /chosen, and doing
> explicit enumeration of the nodes there, is too allow enumerating them sooner,
> so that we get a console earlier on.
>
> Doing this earlier then fs_initcall is not useful, since the fb only turns into
> a console when fbcon intializes, which is a fs_initcall too.
The above text is slightly confusing, as fbcon initializes at
module_init time. You only change it in the next patch. I can move the
fbcon change to be the first patch when applying, if there are no more
versions sent.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/4] simplefb: Change simplefb_init from module_init to fs_initcall
Date: Thu, 13 Nov 2014 16:32:42 +0200 [thread overview]
Message-ID: <5464C10A.30709@ti.com> (raw)
In-Reply-To: <1415885645-24613-3-git-send-email-hdegoede@redhat.com>
On 13/11/14 15:34, Hans de Goede wrote:
> One of the reasons for having the simplefb nodes in /chosen, and doing
> explicit enumeration of the nodes there, is too allow enumerating them sooner,
> so that we get a console earlier on.
>
> Doing this earlier then fs_initcall is not useful, since the fb only turns into
> a console when fbcon intializes, which is a fs_initcall too.
The above text is slightly confusing, as fbcon initializes at
module_init time. You only change it in the next patch. I can move the
fbcon change to be the first patch when applying, if there are no more
versions sent.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141113/ae9ffaad/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Jean-Christophe Plagniol-Villard
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Luc Verhaegen <libv-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
David Herrmann
<dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v3 3/4] simplefb: Change simplefb_init from module_init to fs_initcall
Date: Thu, 13 Nov 2014 16:32:42 +0200 [thread overview]
Message-ID: <5464C10A.30709@ti.com> (raw)
In-Reply-To: <1415885645-24613-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
On 13/11/14 15:34, Hans de Goede wrote:
> One of the reasons for having the simplefb nodes in /chosen, and doing
> explicit enumeration of the nodes there, is too allow enumerating them sooner,
> so that we get a console earlier on.
>
> Doing this earlier then fs_initcall is not useful, since the fb only turns into
> a console when fbcon intializes, which is a fs_initcall too.
The above text is slightly confusing, as fbcon initializes at
module_init time. You only change it in the next patch. I can move the
fbcon change to be the first patch when applying, if there are no more
versions sent.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-13 14:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 13:34 [PATCH v3 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Hans de Goede
2014-11-13 13:34 ` Hans de Goede
2014-11-13 13:34 ` Hans de Goede
2014-11-13 13:34 ` [PATCH v3 2/4] simplefb: Add support for enumerating simplefb dt nodes in /chosen Hans de Goede
2014-11-13 13:34 ` Hans de Goede
2014-11-13 13:34 ` Hans de Goede
2014-11-13 13:34 ` [PATCH v3 3/4] simplefb: Change simplefb_init from module_init to fs_initcall Hans de Goede
2014-11-13 13:34 ` Hans de Goede
2014-11-13 13:34 ` Hans de Goede
2014-11-13 14:32 ` Tomi Valkeinen [this message]
2014-11-13 14:32 ` Tomi Valkeinen
2014-11-13 14:32 ` Tomi Valkeinen
2014-11-13 14:47 ` Hans de Goede
2014-11-13 14:47 ` Hans de Goede
2014-11-13 14:47 ` Hans de Goede
2014-11-13 13:34 ` [PATCH v3 4/4] fbcon: Change fbcon_init " Hans de Goede
2014-11-13 13:34 ` Hans de Goede
2014-11-13 13:34 ` Hans de Goede
2014-11-13 14:34 ` Tomi Valkeinen
2014-11-13 14:34 ` Tomi Valkeinen
2014-11-13 14:34 ` Tomi Valkeinen
2014-11-13 14:28 ` [PATCH v3 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Tomi Valkeinen
2014-11-13 14:28 ` Tomi Valkeinen
2014-11-13 14:28 ` Tomi Valkeinen
2014-11-13 14:46 ` [linux-sunxi] Re: [PATCH v3 1/4] dt-bindings: simplefb: Specify node location and handoff relate Hans de Goede
2014-11-13 14:46 ` Re: [PATCH v3 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Hans de Goede
2014-11-13 14:46 ` [linux-sunxi] " Hans de Goede
2014-11-13 15:52 ` [linux-sunxi] Re: [PATCH v3 1/4] dt-bindings: simplefb: Specify node location and handoff relate Tomi Valkeinen
2014-11-13 15:52 ` Re: [PATCH v3 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Tomi Valkeinen
2014-11-13 15:52 ` [linux-sunxi] " Tomi Valkeinen
2014-11-13 16:07 ` [linux-sunxi] Re: [PATCH v3 1/4] dt-bindings: simplefb: Specify node location and handoff relate Grant Likely
2014-11-13 16:07 ` Re: [PATCH v3 1/4] dt-bindings: simplefb: Specify node location and handoff related properties Grant Likely
2014-11-13 16:07 ` [linux-sunxi] " Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5464C10A.30709@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.