From: elfring@users.sourceforge.net (SF Markus Elfring)
To: cocci@systeme.lip6.fr
Subject: [Cocci] spatch for trivial pointer comparison style?
Date: Fri, 14 Nov 2014 11:08:50 +0100 [thread overview]
Message-ID: <5465D4B2.4020000@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1411140700010.2035@localhost6.localdomain6>
> I don't think that the change is desirable in all cases. There are
> functions like kmalloc where NULL means failure and !p seems like the
> reasonable choice. But there maybe other cases where NULL is somehow
> a meaningful value.
How do you think about to adjust checks for null pointers not only
in Linux source files but also in other applications?
Are there any more software design challenges to consider with the
definition of the preprocessor symbol "NULL"?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <julia.lawall@lip6.fr>, Joe Perches <joe@perches.com>
Cc: Coccinelle <cocci@systeme.lip6.fr>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Cocci] spatch for trivial pointer comparison style?
Date: Fri, 14 Nov 2014 11:08:50 +0100 [thread overview]
Message-ID: <5465D4B2.4020000@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1411140700010.2035@localhost6.localdomain6>
> I don't think that the change is desirable in all cases. There are
> functions like kmalloc where NULL means failure and !p seems like the
> reasonable choice. But there maybe other cases where NULL is somehow
> a meaningful value.
How do you think about to adjust checks for null pointers not only
in Linux source files but also in other applications?
Are there any more software design challenges to consider with the
definition of the preprocessor symbol "NULL"?
Regards,
Markus
next prev parent reply other threads:[~2014-11-14 10:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 19:55 [Cocci] spatch for trivial pointer comparison style? Joe Perches
2014-11-13 19:55 ` Joe Perches
2014-11-14 6:06 ` [Cocci] " Julia Lawall
2014-11-14 6:06 ` Julia Lawall
2014-11-14 6:12 ` Joe Perches
2014-11-14 6:12 ` Joe Perches
2014-11-14 9:18 ` Julia Lawall
2014-11-14 9:18 ` Julia Lawall
2014-11-14 16:22 ` Joe Perches
2014-11-14 16:22 ` Joe Perches
2014-11-15 6:11 ` Julia Lawall
2014-11-15 6:11 ` Julia Lawall
2014-11-14 10:08 ` SF Markus Elfring [this message]
2014-11-14 10:08 ` SF Markus Elfring
2014-11-14 10:31 ` Julia Lawall
2014-11-14 10:31 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5465D4B2.4020000@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.