[Qemu-devel] [PATCH] usb: delete error_report() for usb-bot

[Qemu-devel] [PATCH] usb: delete error_report() for usb-bot

[Jun Li]

When no device under usb-bot bus, usb_msd_handle_data() will print "usb-msd: Bad
LUN 0". This is not correct hints. So delete error_report here. When
scsi_device_find() return NULL, just goto fail.

This patch fixes following bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1164665

Signed-off-by: Jun Li <junmuzi@gmail.com>
---
 hw/usb/dev-storage.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
index 4539733..f386d62 100644
--- a/hw/usb/dev-storage.c
+++ b/hw/usb/dev-storage.c
@@ -424,7 +424,6 @@ static void usb_msd_handle_data(USBDevice *dev, USBPacket *p)
             DPRINTF("Command on LUN %d\n", cbw.lun);
             scsi_dev = scsi_device_find(&s->bus, 0, 0, cbw.lun);
             if (scsi_dev == NULL) {
-                error_report("usb-msd: Bad LUN %d", cbw.lun);
                 goto fail;
             }
             tag = le32_to_cpu(cbw.tag);
-- 
1.9.3

Re: [Qemu-devel] [PATCH] usb: delete error_report() for usb-bot

[Gonglei]

On 2014/11/17 13:49, Jun Li wrote:

> When no device under usb-bot bus, usb_msd_handle_data() will print "usb-msd: Bad
> LUN 0". This is not correct hints. So delete error_report here. When
> scsi_device_find() return NULL, just goto fail.
> 

If the hints is incorrect, I think you should change the hint message, but not delete it,
because that's a recession.

Best regards,
-Gonglei

> This patch fixes following bug.
> https://bugzilla.redhat.com/show_bug.cgi?id=1164665
> 
> Signed-off-by: Jun Li <junmuzi@gmail.com>
> ---
>  hw/usb/dev-storage.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
> index 4539733..f386d62 100644
> --- a/hw/usb/dev-storage.c
> +++ b/hw/usb/dev-storage.c
> @@ -424,7 +424,6 @@ static void usb_msd_handle_data(USBDevice *dev, USBPacket *p)
>              DPRINTF("Command on LUN %d\n", cbw.lun);
>              scsi_dev = scsi_device_find(&s->bus, 0, 0, cbw.lun);
>              if (scsi_dev == NULL) {
> -                error_report("usb-msd: Bad LUN %d", cbw.lun);
>                  goto fail;
>              }
>              tag = le32_to_cpu(cbw.tag);