From: Paolo Bonzini <pbonzini@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, peter.huangpeng@huawei.com
Subject: Re: [Qemu-trivial] [PATCH] net: The third parameter of getsockname should be initialized
Date: Mon, 17 Nov 2014 12:00:49 +0100 [thread overview]
Message-ID: <5469D561.9000902@redhat.com> (raw)
In-Reply-To: <1416203645-2584-1-git-send-email-zhang.zhanghailiang@huawei.com>
On 17/11/2014 06:54, zhanghailiang wrote:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> net/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index fb21e20..ca4b8ba 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -352,7 +352,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer,
> {
> struct sockaddr_in saddr;
> int newfd;
> - socklen_t saddr_len;
> + socklen_t saddr_len = sizeof(saddr);
> NetClientState *nc;
> NetSocketState *s;
>
>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH] net: The third parameter of getsockname should be initialized
Date: Mon, 17 Nov 2014 12:00:49 +0100 [thread overview]
Message-ID: <5469D561.9000902@redhat.com> (raw)
In-Reply-To: <1416203645-2584-1-git-send-email-zhang.zhanghailiang@huawei.com>
On 17/11/2014 06:54, zhanghailiang wrote:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> net/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index fb21e20..ca4b8ba 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -352,7 +352,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer,
> {
> struct sockaddr_in saddr;
> int newfd;
> - socklen_t saddr_len;
> + socklen_t saddr_len = sizeof(saddr);
> NetClientState *nc;
> NetSocketState *s;
>
>
Applied, thanks.
next prev parent reply other threads:[~2014-11-17 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 5:54 [Qemu-trivial] [PATCH] net: The third parameter of getsockname should be initialized zhanghailiang
2014-11-17 5:54 ` [Qemu-devel] " zhanghailiang
2014-11-17 7:18 ` [Qemu-trivial] " Markus Armbruster
2014-11-17 7:18 ` Markus Armbruster
2014-11-17 11:00 ` Paolo Bonzini [this message]
2014-11-17 11:00 ` Paolo Bonzini
2014-11-17 16:59 ` [Qemu-trivial] " Stefan Hajnoczi
2014-11-17 16:59 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5469D561.9000902@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.