* [Qemu-devel] [PATCH] net: The third parameter of getsockname should be initialized
@ 2014-11-17 5:54 ` zhanghailiang
0 siblings, 0 replies; 8+ messages in thread
From: zhanghailiang @ 2014-11-17 5:54 UTC (permalink / raw)
To: qemu-trivial
Cc: pbonzini, zhanghailiang, qemu-devel, stefanha, peter.huangpeng
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
net/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/socket.c b/net/socket.c
index fb21e20..ca4b8ba 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -352,7 +352,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer,
{
struct sockaddr_in saddr;
int newfd;
- socklen_t saddr_len;
+ socklen_t saddr_len = sizeof(saddr);
NetClientState *nc;
NetSocketState *s;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] net: The third parameter of getsockname should be initialized
2014-11-17 5:54 ` [Qemu-devel] " zhanghailiang
@ 2014-11-17 7:18 ` Markus Armbruster
-1 siblings, 0 replies; 8+ messages in thread
From: Markus Armbruster @ 2014-11-17 7:18 UTC (permalink / raw)
To: zhanghailiang
Cc: qemu-trivial, pbonzini, qemu-devel, stefanha, peter.huangpeng
zhanghailiang <zhang.zhanghailiang@huawei.com> writes:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> net/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index fb21e20..ca4b8ba 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -352,7 +352,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer,
> {
> struct sockaddr_in saddr;
> int newfd;
> - socklen_t saddr_len;
> + socklen_t saddr_len = sizeof(saddr);
> NetClientState *nc;
> NetSocketState *s;
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] net: The third parameter of getsockname should be initialized
@ 2014-11-17 7:18 ` Markus Armbruster
0 siblings, 0 replies; 8+ messages in thread
From: Markus Armbruster @ 2014-11-17 7:18 UTC (permalink / raw)
To: zhanghailiang
Cc: qemu-trivial, pbonzini, qemu-devel, stefanha, peter.huangpeng
zhanghailiang <zhang.zhanghailiang@huawei.com> writes:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> net/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index fb21e20..ca4b8ba 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -352,7 +352,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer,
> {
> struct sockaddr_in saddr;
> int newfd;
> - socklen_t saddr_len;
> + socklen_t saddr_len = sizeof(saddr);
> NetClientState *nc;
> NetSocketState *s;
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] net: The third parameter of getsockname should be initialized
2014-11-17 5:54 ` [Qemu-devel] " zhanghailiang
@ 2014-11-17 11:00 ` Paolo Bonzini
-1 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2014-11-17 11:00 UTC (permalink / raw)
To: zhanghailiang, qemu-trivial; +Cc: qemu-devel, stefanha, peter.huangpeng
On 17/11/2014 06:54, zhanghailiang wrote:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> net/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index fb21e20..ca4b8ba 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -352,7 +352,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer,
> {
> struct sockaddr_in saddr;
> int newfd;
> - socklen_t saddr_len;
> + socklen_t saddr_len = sizeof(saddr);
> NetClientState *nc;
> NetSocketState *s;
>
>
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] net: The third parameter of getsockname should be initialized
@ 2014-11-17 11:00 ` Paolo Bonzini
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2014-11-17 11:00 UTC (permalink / raw)
To: zhanghailiang, qemu-trivial; +Cc: qemu-devel, stefanha, peter.huangpeng
On 17/11/2014 06:54, zhanghailiang wrote:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> net/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index fb21e20..ca4b8ba 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -352,7 +352,7 @@ static NetSocketState *net_socket_fd_init_dgram(NetClientState *peer,
> {
> struct sockaddr_in saddr;
> int newfd;
> - socklen_t saddr_len;
> + socklen_t saddr_len = sizeof(saddr);
> NetClientState *nc;
> NetSocketState *s;
>
>
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] net: The third parameter of getsockname should be initialized
2014-11-17 5:54 ` [Qemu-devel] " zhanghailiang
@ 2014-11-17 16:59 ` Stefan Hajnoczi
-1 siblings, 0 replies; 8+ messages in thread
From: Stefan Hajnoczi @ 2014-11-17 16:59 UTC (permalink / raw)
To: zhanghailiang
Cc: qemu-trivial, pbonzini, qemu-devel, stefanha, peter.huangpeng
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
On Mon, Nov 17, 2014 at 01:54:05PM +0800, zhanghailiang wrote:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> net/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] net: The third parameter of getsockname should be initialized
@ 2014-11-17 16:59 ` Stefan Hajnoczi
0 siblings, 0 replies; 8+ messages in thread
From: Stefan Hajnoczi @ 2014-11-17 16:59 UTC (permalink / raw)
To: zhanghailiang
Cc: qemu-trivial, pbonzini, qemu-devel, stefanha, peter.huangpeng
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
On Mon, Nov 17, 2014 at 01:54:05PM +0800, zhanghailiang wrote:
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> ---
> net/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread