From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Lokesh Vutla <lokeshvutla@ti.com>, linux-omap@vger.kernel.org
Cc: Nishanth Menon <nm@ti.com>,
devicetree@vger.kernel.org, tony@atomide.com, nsekhar@ti.com,
t-kristo@ti.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: DRA7: Add node for RTC
Date: Mon, 17 Nov 2014 19:12:14 +0300 [thread overview]
Message-ID: <546A1E5E.1040909@cogentembedded.com> (raw)
In-Reply-To: <5469F271.9080102@ti.com>
On 11/17/2014 4:04 PM, Lokesh Vutla wrote:
>> On 11/17/2014 7:45 AM, Lokesh Vutla wrote:
>>> Add node for RTC.
>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>> [nm@ti.com: update with rtc crossbar number]
>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>> ---
>>> arch/arm/boot/dts/dra7.dtsi | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>>> index 9cc9843..f98f9f0 100644
>>> --- a/arch/arm/boot/dts/dra7.dtsi
>>> +++ b/arch/arm/boot/dts/dra7.dtsi
>>> @@ -1075,6 +1075,15 @@
>>> status = "disabled";
>>> };
>>>
>>> + rtc: rtcss@48838000 {
>> Please just name the node "rtc@48838000", in accordance with ePAPR.
> Okay. will update it.
>>> + compatible = "ti,am3352-rtc";
>>> + reg = <0x48838000 0x100>;
>>> + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
>> 2 similar interrupts?
> both rtc timer and rtc alarm uses same interrupt on DRA7 Soc.
> Driver handles it accordingly.
> So passing the same interrupt.
I think it would have been better if the driver just handled a single
interrupt.
> Thanks and regards,
> Lokesh
>> [...]
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: DRA7: Add node for RTC
Date: Mon, 17 Nov 2014 19:12:14 +0300 [thread overview]
Message-ID: <546A1E5E.1040909@cogentembedded.com> (raw)
In-Reply-To: <5469F271.9080102@ti.com>
On 11/17/2014 4:04 PM, Lokesh Vutla wrote:
>> On 11/17/2014 7:45 AM, Lokesh Vutla wrote:
>>> Add node for RTC.
>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>> [nm at ti.com: update with rtc crossbar number]
>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>> ---
>>> arch/arm/boot/dts/dra7.dtsi | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
>>> index 9cc9843..f98f9f0 100644
>>> --- a/arch/arm/boot/dts/dra7.dtsi
>>> +++ b/arch/arm/boot/dts/dra7.dtsi
>>> @@ -1075,6 +1075,15 @@
>>> status = "disabled";
>>> };
>>>
>>> + rtc: rtcss at 48838000 {
>> Please just name the node "rtc at 48838000", in accordance with ePAPR.
> Okay. will update it.
>>> + compatible = "ti,am3352-rtc";
>>> + reg = <0x48838000 0x100>;
>>> + interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>;
>> 2 similar interrupts?
> both rtc timer and rtc alarm uses same interrupt on DRA7 Soc.
> Driver handles it accordingly.
> So passing the same interrupt.
I think it would have been better if the driver just handled a single
interrupt.
> Thanks and regards,
> Lokesh
>> [...]
WBR, Sergei
next prev parent reply other threads:[~2014-11-17 16:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 4:45 [PATCH] ARM: dts: DRA7: Add node for RTC Lokesh Vutla
2014-11-17 4:45 ` Lokesh Vutla
2014-11-17 12:17 ` Sergei Shtylyov
2014-11-17 12:17 ` Sergei Shtylyov
2014-11-17 13:04 ` Lokesh Vutla
2014-11-17 13:04 ` Lokesh Vutla
2014-11-17 16:12 ` Sergei Shtylyov [this message]
2014-11-17 16:12 ` Sergei Shtylyov
2014-11-18 5:01 ` Lokesh Vutla
2014-11-18 5:01 ` Lokesh Vutla
2014-11-18 10:55 ` Sergei Shtylyov
2014-11-18 10:55 ` Sergei Shtylyov
2014-11-19 12:23 ` [PATCH V2] " Lokesh Vutla
2014-11-19 12:23 ` Lokesh Vutla
2014-11-22 0:00 ` Tony Lindgren
2014-11-22 0:00 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546A1E5E.1040909@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.