From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-4.5 RFC] pygrub: Fix regression from c/s d1b93ea, attempt 2
Date: Mon, 17 Nov 2014 16:59:49 +0000 [thread overview]
Message-ID: <546A2985.5000106@citrix.com> (raw)
In-Reply-To: <1416243498.5466.27.camel@citrix.com>
On 17/11/14 16:58, Ian Campbell wrote:
> On Mon, 2014-11-17 at 15:19 +0000, Andrew Cooper wrote:
>> c/s d1b93ea causes substantial functional regressions in pygrub's ability to
>> parse bootloader configuration files.
> Please can you and Boris both provide examples of (ideally real-world)
> configuration files which exhibit these failures as patches against
> tools/pygrub/examples/.
>
> Boris, in your case I mean the one which caused you to write the
> original patch, which I should have remembered to ask for at the time.
>
> Andy, in your case it would make sense to include at least one in this
> patch I think.
>
> Ian.
>
examples/ doesn't help. The parsers themselves don't exhibit the bug.
It is only when pygrub itself attempts to interact with the parsed
config does the issue exhibits itself.
I would have provided an example if it would have helped.
~Andrew
next prev parent reply other threads:[~2014-11-17 16:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 15:19 [PATCH for-4.5 RFC] pygrub: Fix regression from c/s d1b93ea, attempt 2 Andrew Cooper
2014-11-17 16:41 ` Boris Ostrovsky
2014-11-17 16:50 ` Andrew Cooper
2014-11-17 16:58 ` Ian Campbell
2014-11-17 16:59 ` Andrew Cooper [this message]
2014-11-17 17:15 ` Boris Ostrovsky
2014-11-20 16:00 ` Ian Campbell
2014-11-20 16:08 ` Andrew Cooper
2014-11-20 16:15 ` Ian Campbell
2014-11-20 16:45 ` Boris Ostrovsky
2014-11-21 13:32 ` Andrew Cooper
2014-11-21 17:09 ` Konrad Rzeszutek Wilk
2014-11-21 17:25 ` Boris Ostrovsky
2014-11-25 14:14 ` Ian Campbell
2014-11-25 16:03 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546A2985.5000106@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.