Re: [PATCH for-4.5 RFC] pygrub: Fix regression from c/s d1b93ea, attempt 2

[Boris Ostrovsky <boris.ostrovsky@oracle.com>]

On 11/21/2014 12:09 PM, Konrad Rzeszutek Wilk wrote:
> On Fri, Nov 21, 2014 at 01:32:13PM +0000, Andrew Cooper wrote:
>> That does look plausibly like it would fix the issue.
>>
>> However, I can't help but feeing that this is hacking around a broken
>> patch in the first place.
> I cannot think of a reason you would ever feel that way!
> <surreptitiously checks the roll of Xen 4.5 band-aid>
>
> We know that the existing patches work fine for a host of Fedora
> families (15->21) (thought I need to double check that the testing framework
> that we have is using pygrub and not pvgrub), SLESs and RHEL5s, and OL6s.
>
> The ones that I am worried about are the ExtLinux and such which
> I didn't realize would use 'pygrub'.
>
> Thought I just remembered a bug with OL7 grub entries - that is if
> you go in the interactive menu things broke down. Boris, do you
> remember if that was fixed or just 'deferred'?

The only bug that I remember that had to do pygrub and OL7 was the fact 
that pygrub cannot parse grubenv (and therefore it's not really 
OL7-specific).

We decided not to fix it.


-boris