From: Alexander Graf <agraf@suse.de>
To: Paul Mackerras <paulus@samba.org>, kvm-ppc@vger.kernel.org
Cc: kvm@vger.kernel.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Add missing HPTE unlock
Date: Thu, 20 Nov 2014 17:23:51 +0000 [thread overview]
Message-ID: <546E23A7.9020705@suse.de> (raw)
In-Reply-To: <1415150473-28458-1-git-send-email-paulus@samba.org>
On 05.11.14 02:21, Paul Mackerras wrote:
> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>
> In kvm_test_clear_dirty(), if we find an invalid HPTE we move on to the
> next HPTE without unlocking the invalid one. In fact we should never
> find an invalid and unlocked HPTE in the rmap chain, but for robustness
> we should unlock it. This adds the missing unlock.
>
> Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
Thanks, applied to kvm-ppc-queue.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Paul Mackerras <paulus@samba.org>, kvm-ppc@vger.kernel.org
Cc: kvm@vger.kernel.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Add missing HPTE unlock
Date: Thu, 20 Nov 2014 18:23:51 +0100 [thread overview]
Message-ID: <546E23A7.9020705@suse.de> (raw)
In-Reply-To: <1415150473-28458-1-git-send-email-paulus@samba.org>
On 05.11.14 02:21, Paul Mackerras wrote:
> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>
> In kvm_test_clear_dirty(), if we find an invalid HPTE we move on to the
> next HPTE without unlocking the invalid one. In fact we should never
> find an invalid and unlocked HPTE in the rmap chain, but for robustness
> we should unlock it. This adds the missing unlock.
>
> Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
Thanks, applied to kvm-ppc-queue.
Alex
next prev parent reply other threads:[~2014-11-20 17:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-13 22:56 [PATCH] KVM: PPC: Book3S HV: Add missing code for transaction reclaim on guest exit Paul Mackerras
2014-04-13 22:56 ` Paul Mackerras
2014-04-16 12:39 ` Alexander Graf
2014-04-16 12:39 ` Alexander Graf
2014-11-05 1:21 ` [PATCH] KVM: PPC: Book3S HV: Add missing HPTE unlock Paul Mackerras
2014-11-05 1:21 ` Paul Mackerras
2014-11-20 17:23 ` Alexander Graf [this message]
2014-11-20 17:23 ` Alexander Graf
-- strict thread matches above, loose matches on Subject: below --
2014-10-20 9:25 Aneesh Kumar K.V
2014-10-20 9:37 ` Aneesh Kumar K.V
2014-10-20 9:25 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546E23A7.9020705@suse.de \
--to=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.