All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oded Gabbay <oded.gabbay@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Andrew Lewycky <Andrew.Lewycky@amd.com>
Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [patch] amdkfd: fix some error handling in ioctl
Date: Tue, 25 Nov 2014 12:27:30 +0000	[thread overview]
Message-ID: <547475B2.9040108@amd.com> (raw)
In-Reply-To: <20141125102129.GB23215@mwanda>

On 11/25/2014 12:21 PM, Dan Carpenter wrote:
> There is a typo here so the errors from kfd_bind_process_to_device()
> are not detected.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>

Patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@amd.com>
And applied to my 3.19-next-wip tree

	Oded

> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index 64c73ba..c5dd0ae 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -236,7 +236,7 @@ static long kfd_ioctl_create_queue(struct file *filep, struct kfd_process *p,
>   	mutex_lock(&p->mutex);
>
>   	pdd = kfd_bind_process_to_device(dev, p);
> -	if (IS_ERR(pdd) < 0) {
> +	if (IS_ERR(pdd)) {
>   		err = PTR_ERR(pdd);
>   		goto err_bind_process;
>   	}
> @@ -381,7 +381,7 @@ static long kfd_ioctl_set_memory_policy(struct file *filep,
>   	mutex_lock(&p->mutex);
>
>   	pdd = kfd_bind_process_to_device(dev, p);
> -	if (IS_ERR(pdd) < 0) {
> +	if (IS_ERR(pdd)) {
>   		err = PTR_ERR(pdd);
>   		goto out;
>   	}
>

WARNING: multiple messages have this Message-ID (diff)
From: Oded Gabbay <oded.gabbay@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Andrew Lewycky <Andrew.Lewycky@amd.com>
Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [patch] amdkfd: fix some error handling in ioctl
Date: Tue, 25 Nov 2014 14:27:30 +0200	[thread overview]
Message-ID: <547475B2.9040108@amd.com> (raw)
In-Reply-To: <20141125102129.GB23215@mwanda>

On 11/25/2014 12:21 PM, Dan Carpenter wrote:
> There is a typo here so the errors from kfd_bind_process_to_device()
> are not detected.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>

Patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@amd.com>
And applied to my 3.19-next-wip tree

	Oded

> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index 64c73ba..c5dd0ae 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -236,7 +236,7 @@ static long kfd_ioctl_create_queue(struct file *filep, struct kfd_process *p,
>   	mutex_lock(&p->mutex);
>
>   	pdd = kfd_bind_process_to_device(dev, p);
> -	if (IS_ERR(pdd) < 0) {
> +	if (IS_ERR(pdd)) {
>   		err = PTR_ERR(pdd);
>   		goto err_bind_process;
>   	}
> @@ -381,7 +381,7 @@ static long kfd_ioctl_set_memory_policy(struct file *filep,
>   	mutex_lock(&p->mutex);
>
>   	pdd = kfd_bind_process_to_device(dev, p);
> -	if (IS_ERR(pdd) < 0) {
> +	if (IS_ERR(pdd)) {
>   		err = PTR_ERR(pdd);
>   		goto out;
>   	}
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-11-25 12:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 10:21 [patch] amdkfd: fix some error handling in ioctl Dan Carpenter
2014-11-25 10:21 ` Dan Carpenter
2014-11-25 12:27 ` Oded Gabbay [this message]
2014-11-25 12:27   ` Oded Gabbay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547475B2.9040108@amd.com \
    --to=oded.gabbay@amd.com \
    --cc=Andrew.Lewycky@amd.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.