Re: [Qemu-devel] [PATCH] input: move input-send-event into experimental namespace

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

On 11/25/2014 04:58 AM, Markus Armbruster wrote:
> Amos Kong <akong@redhat.com> writes:
> 
>> On Tue, Nov 25, 2014 at 09:06:34AM +0100, Markus Armbruster wrote:
>>> Gerd Hoffmann <kraxel@redhat.com> writes:
>>>
>>>> Ongoing discussions on how we are going to specify the console,
>>>> so tag the command as experiemntal so we can refine things in
>>>> the 2.3 development cycle.
>>>>
>>>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>>>> ---
>>>>  qmp-commands.hx | 12 ++++++------
>>>
>>> Don't you need to patch qapi-schema.json, too?
>>
>> Not necessary in function level.
> 
> s/need to/want to/?

Yes, if you are going to mark the HMP command experimental, please also
mark the QMP command as experimental.

> 
>>> Do we actually explain "x- means experimental" anywhere?

Hmm, In my (not yet finished) series for improving qapi generation type
safety, I have added:

$ git grep -A1 'x-' docs/
...
docs/qapi-code-gen.txt:Any command, type, or field name beginning with
"x-" is marked
docs/qapi-code-gen.txt-experimental, and may be withdrawn in a future
release.  Downstream
...

but I obviously need to find time to revisit my series since that text
is not in upstream yet.

>>
>> What's the official way to make command experimental?
> 
> I think we have an understanding / convention that an "x-" prefix marks
> names as unstable API.  But I can't find it spelled out anywhere.
> Anyway, separate issue.

Yep, and on my plate to finish it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]