From: Markus Armbruster <armbru@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] input: move input-send-event into experimental namespace
Date: Tue, 25 Nov 2014 12:58:49 +0100 [thread overview]
Message-ID: <87fvd7lcee.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20141125083700.GA26731@air.redhat.com> (Amos Kong's message of "Tue, 25 Nov 2014 16:37:00 +0800")
Amos Kong <akong@redhat.com> writes:
> On Tue, Nov 25, 2014 at 09:06:34AM +0100, Markus Armbruster wrote:
>> Gerd Hoffmann <kraxel@redhat.com> writes:
>>
>> > Ongoing discussions on how we are going to specify the console,
>> > so tag the command as experiemntal so we can refine things in
>> > the 2.3 development cycle.
>> >
>> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> > ---
>> > qmp-commands.hx | 12 ++++++------
>>
>> Don't you need to patch qapi-schema.json, too?
>
> Not necessary in function level.
s/need to/want to/?
For consistency, especially because the QAPI schema also serves as QMP
command documentation.
>> Do we actually explain "x- means experimental" anywhere?
>
> What's the official way to make command experimental?
I think we have an understanding / convention that an "x-" prefix marks
names as unstable API. But I can't find it spelled out anywhere.
Anyway, separate issue.
> Quote from qapi-schema.json:
> | # Notes: This command is experimental and may change
> | syntax in future releases.
Next to the return type ObjectTypeInfo rathe than the command
qom-list-types, blech.
next prev parent reply other threads:[~2014-11-25 11:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 7:18 [Qemu-devel] [PATCH] input: move input-send-event into experimental namespace Gerd Hoffmann
2014-11-25 7:57 ` Amos Kong
2014-11-25 8:06 ` Markus Armbruster
2014-11-25 8:37 ` Amos Kong
2014-11-25 11:58 ` Markus Armbruster [this message]
2014-11-25 13:55 ` Markus Armbruster
2014-11-25 16:35 ` Eric Blake
2014-11-26 6:21 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvd7lcee.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=akong@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.