All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oded Gabbay <oded.gabbay@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [patch] amdkfd: delete some dead code
Date: Wed, 26 Nov 2014 08:57:10 +0000	[thread overview]
Message-ID: <547595E6.2030406@amd.com> (raw)
In-Reply-To: <20141125164329.GC19894@mwanda>



On 11/25/2014 06:43 PM, Dan Carpenter wrote:
> This is dead code.  We don't need to unbind here, we can just return
> directly.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
Patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@amd.com>
And applied to my 3.19-next-wip tree.
Thanks!

    Oded

> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index a17e2dd..b4f49ac 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -348,11 +348,6 @@ struct kfd_process_device *kfd_bind_process_to_device(struct kfd_dev *dev,
>  	if (err < 0)
>  		return ERR_PTR(err);
>  
> -	if (err < 0) {
> -		amd_iommu_unbind_pasid(dev->pdev, p->pasid);
> -		return ERR_PTR(err);
> -	}
> -
>  	pdd->bound = true;
>  
>  	return pdd;
> 

WARNING: multiple messages have this Message-ID (diff)
From: Oded Gabbay <oded.gabbay@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [patch] amdkfd: delete some dead code
Date: Wed, 26 Nov 2014 10:57:10 +0200	[thread overview]
Message-ID: <547595E6.2030406@amd.com> (raw)
In-Reply-To: <20141125164329.GC19894@mwanda>



On 11/25/2014 06:43 PM, Dan Carpenter wrote:
> This is dead code.  We don't need to unbind here, we can just return
> directly.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
Patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@amd.com>
And applied to my 3.19-next-wip tree.
Thanks!

    Oded

> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index a17e2dd..b4f49ac 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -348,11 +348,6 @@ struct kfd_process_device *kfd_bind_process_to_device(struct kfd_dev *dev,
>  	if (err < 0)
>  		return ERR_PTR(err);
>  
> -	if (err < 0) {
> -		amd_iommu_unbind_pasid(dev->pdev, p->pasid);
> -		return ERR_PTR(err);
> -	}
> -
>  	pdd->bound = true;
>  
>  	return pdd;
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2014-11-26  8:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 16:43 [patch] amdkfd: delete some dead code Dan Carpenter
2014-11-25 16:43 ` Dan Carpenter
2014-11-26  8:57 ` Oded Gabbay [this message]
2014-11-26  8:57   ` Oded Gabbay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547595E6.2030406@amd.com \
    --to=oded.gabbay@amd.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.