ipset website

ipset website

[Mike Wright]

Hi everybody,

I'm hoping this is the right list to contact the ipset developers.

I've made some updates to the ipset.netfilter.org website.  The changes 
are cosmetic, such as highlighting the menu link when on a specific 
page, and framing the man pages so that you don't have to use the "back" 
button to continue navigating the site (required adding four new pages).

To preview the changes visit:

     http://ipset.hostisimo.com/

To see the diffs between the original pages and mine:

     http://ipset.hostisimo.com/diffs

If you find the changes acceptable you may pull the bz from:

     http://ipset.hostisimo.com/ipset.netfilter.org.tar.bz2

I hope you like them,
Mike Wright

ps. any replies must be on list, the above email address goes to a bit 
bucket

Re: ipset website

[Jan Engelhardt]

On Saturday 2014-11-29 01:56, Mike Wright wrote:
>
> I've made some updates to the ipset.netfilter.org website.  The changes are
> cosmetic, such as highlighting the menu link when on a specific page,

The syntax for color= is probably incorrect, it is missing #.
But why do you even introduce the archaic <font> tag? The CSS
class "hot" seemed to be just right.

Forcing a scrollbar also seems backwards. If the table is to
have a consistent size irrespective of scrollbar, one would
probably use CSS's position: or float:.

> framing the man pages so that you don't have to use the "back" button to
> continue navigating the site (required adding four new pages).

It adds another scrollbar rather than just filling the page downards.
This would preferably call for something like SSI, or PHP's include(),
for avoiding the duplication of the menu.


> To see the diffs between the original pages and mine:
>
>    http://ipset.hostisimo.com/diffs

They are not in unified form.

Re: ipset website

[Mike Wright]

On 11/28/2014 05:23 PM, Jan Engelhardt wrote:
>
> On Saturday 2014-11-29 01:56, Mike Wright wrote:
>>
>> I've made some updates to the ipset.netfilter.org website.  The changes are
>> cosmetic, such as highlighting the menu link when on a specific page,
>
> The syntax for color= is probably incorrect, it is missing #.
> But why do you even introduce the archaic <font> tag? The CSS
> class "hot" seemed to be just right.
>
The <font> tags were in the original.  That was the first thing I removed.

> Forcing a scrollbar also seems backwards. If the table is to
> have a consistent size irrespective of scrollbar, one would
> probably use CSS's position: or float:.
 >
Those solutions won't work.  The scroll bar is added to the page by the 
browser, outside of the body, which causes the body width to narrow, 
specifically by different widths depending on which browser.  The only 
way to accomplish that is with javascript.  I feel that is an 
inappropriate addition to the pages.  I prefer that each page's body 
width be constant.  Six of the nine pages would have one anyway.

>> framing the man pages so that you don't have to use the "back" button to
>> continue navigating the site (required adding four new pages).
>
> It adds another scrollbar rather than just filling the page downards.
> This would preferably call for something like SSI, or PHP's include(),
> for avoiding the duplication of the menu.
>
Agreed.  The <iframe/> tags have been removed.  The ipset, ip(6)tables, 
and iptables-extensions pages are now php.

>
>> To see the diffs between the original pages and mine:
>
> They are not in unified form.

Just learned how to do that :) They are now.

The changes I made should now be in line with your comments.  Please review.

site:  http://ipset.hostisimo.com
diff:  http://ipset.hostisimo.com/diff
bzip:  http://ipset.hostisimo.com/ipset.netfilter.org.tar.bz2



> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>

Re: ipset website

[Jan Engelhardt]

On Saturday 2014-11-29 05:08, Mike Wright wrote:
>> Forcing a scrollbar also seems backwards. If the table is to
>> have a consistent size irrespective of scrollbar, one would
>> probably use CSS's position: or float:.
>>
> Those solutions won't work.  The scroll bar is added to the page by the
> browser, outside of the body, which causes the body width to narrow

Hm, too bad.

"overflow-y: scroll" though is better-suited than "height: 100.1%",
and according to http://stackoverflow.com/a/7607206 , should be on
the html object, not body.

Re: ipset website

[Mike Wright]

On 11/29/2014 03:33 AM, Jan Engelhardt wrote:
>
>> Those solutions won't work.  The scroll bar is added to the page by the
>> browser, outside of the body, which causes the body width to narrow
>
> "overflow-y: scroll" though is better-suited than "height: 100.1%",
> and according to http://stackoverflow.com/a/7607206 , should be on
> the html object, not body.
>
Much better solution.  Done.

Ready for review.

site: http://ipset.hostisimo.com
diff: http://ipset.hostisimo.com/diff
bzip: http://ipset.hostisimo.com/ipset.netfilter.org.tar.bz2

Does anybody else have any comments?

If not, please push the new site to the server.

Mike Wright

Re: ipset website

[Mike Wright]

On 11/29/2014 09:29 AM, Mike Wright wrote:
>
Upgraded to ipset-6.24
>
> Ready for review.
>
> site: http://ipset.hostisimo.com
> diff: http://ipset.hostisimo.com/diff
> bzip: http://ipset.hostisimo.com/ipset.netfilter.org.tar.bz2
>
> Does anybody else have any comments?
>
> If not, please push the new site to the server.
>
> Mike Wright
> --
> To unsubscribe from this list: send the line "unsubscribe
> netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>

Re: ipset website

[Jozsef Kadlecsik]

On Sat, 29 Nov 2014, Mike Wright wrote:

> On 11/29/2014 09:29 AM, Mike Wright wrote:
> > 
> Upgraded to ipset-6.24
> > 
> > Ready for review.
> > 
> > site: http://ipset.hostisimo.com
> > diff: http://ipset.hostisimo.com/diff
> > bzip: http://ipset.hostisimo.com/ipset.netfilter.org.tar.bz2
> > 
> > Does anybody else have any comments?

According to the diff:

Only in new/ipset.netfilter.org: ipset.php
Only in new/ipset.netfilter.org: iptables-extensions.php
Only in new/ipset.netfilter.org: iptables.php

There's no php at the site at all, it's totally static. Please keep 
the html files.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary

Re: ipset website

[Mike Wright]

On 11/30/2014 11:33 AM, Jozsef Kadlecsik wrote:
>
> According to the diff:
>
> Only in new/ipset.netfilter.org: ipset.php
> Only in new/ipset.netfilter.org: iptables-extensions.php
> Only in new/ipset.netfilter.org: iptables.php
>
> There's no php at the site at all, it's totally static. Please keep
> the html files.

Jó napot, József,

html restored.

site: http://ipset.hostisimo.com
diff: http://ipset.hostisimo.com/diff
bzip: http://ipset.hostisimo.com/ipset.netfilter.org.tar.bz2

Other comments?

If not, you may push the changes.

If you use wget to retrieve the site remove diff and 
ipset.netfilter.org.tar.bz2 before pushing.  If you retrieve the bzip 
nothing needs to be done.

Mike Wright
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ipset website

[Jozsef Kadlecsik]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 879 bytes --]

On Sun, 30 Nov 2014, Mike Wright wrote:

> Jó napot, József,

Üdvözletem! :-)

> html restored.
> 
> site: http://ipset.hostisimo.com
> diff: http://ipset.hostisimo.com/diff
> bzip: http://ipset.hostisimo.com/ipset.netfilter.org.tar.bz2
> 
> Other comments?

The htmlized manpages are renamed from <foo>.man.html to <foo>.html. 
That's not a problem, but you created the diff without the "-N" flag, so 
their contents are missing from the diff file.

However, the best were to separate the common parts (header, menu, 
footer) into files and use SSI to include them into the pages.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary

Re: ipset website

[Mike Wright]

On 12/02/2014 12:52 AM, Jozsef Kadlecsik wrote:
> On Sun, 30 Nov 2014, Mike Wright wrote:
>
>> Jó napot, József,
>
> Üdvözletem! :-)
>
>> html restored.
>>
>> site: http://ipset.hostisimo.com
>> diff: http://ipset.hostisimo.com/diff
>> bzip: http://ipset.hostisimo.com/ipset.netfilter.org.tar.bz2
>>
>> Other comments?
>
> The htmlized manpages are renamed from <foo>.man.html to <foo>.html.
> That's not a problem, but you created the diff without the "-N" flag, so
> their contents are missing from the diff file.

Not to worry.  The original man.html pages are still there, unchanged, 
and used as they are.
>
> However, the best were to separate the common parts (header, menu,
> footer) into files and use SSI to include them into the pages.

They are "included", not using SSI, but CSI (client side includes), 
which in HTML is the <iframe/> tag.

I did it this way so that whenever the man pages are regenerated using 
man2html absolutely nothing has to be done.  They will show up 
automagically.

The site is ready to publish.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html