From: Lars-Peter Clausen <lars@metafoo.de>
To: Timur Tabi <timur@tabi.org>, Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@lists.ozlabs.org, Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, Jiada Wang <jiada_wang@mentor.com>,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
nicoleotsuka@gmail.com, tiwai@suse.de, Li.Xiubo@freescale.com,
Markus Pargmann <mpa@pengutronix.de>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()
Date: Mon, 01 Dec 2014 21:30:47 +0100 [thread overview]
Message-ID: <547CCFF7.2000205@metafoo.de> (raw)
In-Reply-To: <547CCB78.5090007@tabi.org>
On 12/01/2014 09:11 PM, Timur Tabi wrote:
> On 12/01/2014 02:01 PM, Arnd Bergmann wrote:
>>> >Does this mean that fsl_ssi.c should not be calling
>>> >irq_of_parse_and_map? How else should it get the IRQ?
>> platform_get_irq()
>
> Ok, but that function also calls irq_create_of_mapping(). So it still
> appears that the only way to get the IRQ is to map it, but then we can't use
> devm_request_irq().
>
Hm... that's new. But it's not really a driver issue anymore if it is done
in the core. So I guess for now just use platform_get_irq() and ignore the
other issue.
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Timur Tabi <timur@tabi.org>, Arnd Bergmann <arnd@arndb.de>
Cc: alsa-devel@alsa-project.org, Jiada Wang <jiada_wang@mentor.com>,
Li.Xiubo@freescale.com, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com, nicoleotsuka@gmail.com, tiwai@suse.de,
Mark Brown <broonie@kernel.org>,
Markus Pargmann <mpa@pengutronix.de>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()
Date: Mon, 01 Dec 2014 21:30:47 +0100 [thread overview]
Message-ID: <547CCFF7.2000205@metafoo.de> (raw)
In-Reply-To: <547CCB78.5090007@tabi.org>
On 12/01/2014 09:11 PM, Timur Tabi wrote:
> On 12/01/2014 02:01 PM, Arnd Bergmann wrote:
>>> >Does this mean that fsl_ssi.c should not be calling
>>> >irq_of_parse_and_map? How else should it get the IRQ?
>> platform_get_irq()
>
> Ok, but that function also calls irq_create_of_mapping(). So it still
> appears that the only way to get the IRQ is to map it, but then we can't use
> devm_request_irq().
>
Hm... that's new. But it's not really a driver issue anymore if it is done
in the core. So I guess for now just use platform_get_irq() and ignore the
other issue.
next prev parent reply other threads:[~2014-12-01 20:30 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 2:50 [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping() Jiada Wang
2014-12-01 2:50 ` Jiada Wang
2014-12-01 2:50 ` Jiada Wang
2014-12-01 6:50 ` Markus Pargmann
2014-12-01 6:50 ` Markus Pargmann
2014-12-01 6:50 ` Markus Pargmann
2014-12-01 16:49 ` Lars-Peter Clausen
2014-12-01 16:49 ` [alsa-devel] " Lars-Peter Clausen
2014-12-01 16:49 ` Lars-Peter Clausen
2014-12-01 16:51 ` Timur Tabi
2014-12-01 16:51 ` Timur Tabi
2014-12-01 16:59 ` Lars-Peter Clausen
2014-12-01 16:59 ` [alsa-devel] " Lars-Peter Clausen
2014-12-01 16:59 ` Lars-Peter Clausen
2014-12-01 18:48 ` Timur Tabi
2014-12-01 18:48 ` Timur Tabi
2014-12-01 19:39 ` Lars-Peter Clausen
2014-12-01 19:39 ` Lars-Peter Clausen
2014-12-01 19:41 ` Mark Brown
2014-12-01 19:41 ` Mark Brown
2014-12-01 19:56 ` Arnd Bergmann
2014-12-01 19:56 ` Arnd Bergmann
2014-12-01 19:59 ` Timur Tabi
2014-12-01 19:59 ` Timur Tabi
2014-12-01 20:01 ` Arnd Bergmann
2014-12-01 20:01 ` Arnd Bergmann
2014-12-01 20:11 ` Timur Tabi
2014-12-01 20:11 ` Timur Tabi
2014-12-01 20:30 ` Lars-Peter Clausen [this message]
2014-12-01 20:30 ` Lars-Peter Clausen
2014-12-01 20:40 ` Fabio Estevam
2014-12-01 20:40 ` Fabio Estevam
2014-12-01 20:42 ` Timur Tabi
2014-12-01 20:42 ` Timur Tabi
2014-12-01 21:03 ` Fabio Estevam
2014-12-01 21:03 ` Fabio Estevam
2014-12-01 20:16 ` Mark Brown
2014-12-01 20:16 ` Mark Brown
2014-12-01 19:24 ` Mark Brown
2014-12-01 19:24 ` [alsa-devel] " Mark Brown
2014-12-01 19:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547CCFF7.2000205@metafoo.de \
--to=lars@metafoo.de \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=jiada_wang@mentor.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpa@pengutronix.de \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.