All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@tabi.org>
To: Fabio Estevam <festevam@gmail.com>, Lars-Peter Clausen <lars@metafoo.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Jiada Wang <jiada_wang@mentor.com>,
	Xiubo Li <Li.Xiubo@freescale.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>,
	Markus Pargmann <mpa@pengutronix.de>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()
Date: Mon, 01 Dec 2014 14:42:46 -0600	[thread overview]
Message-ID: <547CD2C6.2060107@tabi.org> (raw)
In-Reply-To: <CAOMZO5B7MxLSaETUW0QyajdHMMX2nLg=t=5dVCNRePb6UzizRQ@mail.gmail.com>

On 12/01/2014 02:40 PM, Fabio Estevam wrote:
>> >Hm... that's new. But it's not really a driver issue anymore if it is done
>> >in the core. So I guess for now just use platform_get_irq() and ignore the
>> >other issue.

> With the suggested changes below, the removal of the driver works fine on a mx6:

Would the mapping continue to exist after the driver is unloaded?  Can 
you try multiple loads/unloads and see if interrupts still work?

WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@tabi.org>
To: Fabio Estevam <festevam@gmail.com>, Lars-Peter Clausen <lars@metafoo.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Arnd Bergmann <arnd@arndb.de>, Jiada Wang <jiada_wang@mentor.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Takashi Iwai <tiwai@suse.de>, Xiubo Li <Li.Xiubo@freescale.com>,
	Markus Pargmann <mpa@pengutronix.de>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()
Date: Mon, 01 Dec 2014 14:42:46 -0600	[thread overview]
Message-ID: <547CD2C6.2060107@tabi.org> (raw)
In-Reply-To: <CAOMZO5B7MxLSaETUW0QyajdHMMX2nLg=t=5dVCNRePb6UzizRQ@mail.gmail.com>

On 12/01/2014 02:40 PM, Fabio Estevam wrote:
>> >Hm... that's new. But it's not really a driver issue anymore if it is done
>> >in the core. So I guess for now just use platform_get_irq() and ignore the
>> >other issue.

> With the suggested changes below, the removal of the driver works fine on a mx6:

Would the mapping continue to exist after the driver is unloaded?  Can 
you try multiple loads/unloads and see if interrupts still work?

  reply	other threads:[~2014-12-01 20:42 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01  2:50 [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping() Jiada Wang
2014-12-01  2:50 ` Jiada Wang
2014-12-01  2:50 ` Jiada Wang
2014-12-01  6:50 ` Markus Pargmann
2014-12-01  6:50   ` Markus Pargmann
2014-12-01  6:50   ` Markus Pargmann
2014-12-01 16:49   ` Lars-Peter Clausen
2014-12-01 16:49     ` [alsa-devel] " Lars-Peter Clausen
2014-12-01 16:49     ` Lars-Peter Clausen
2014-12-01 16:51     ` Timur Tabi
2014-12-01 16:51       ` Timur Tabi
2014-12-01 16:59       ` Lars-Peter Clausen
2014-12-01 16:59         ` [alsa-devel] " Lars-Peter Clausen
2014-12-01 16:59         ` Lars-Peter Clausen
2014-12-01 18:48     ` Timur Tabi
2014-12-01 18:48       ` Timur Tabi
2014-12-01 19:39       ` Lars-Peter Clausen
2014-12-01 19:39         ` Lars-Peter Clausen
2014-12-01 19:41         ` Mark Brown
2014-12-01 19:41           ` Mark Brown
2014-12-01 19:56           ` Arnd Bergmann
2014-12-01 19:56             ` Arnd Bergmann
2014-12-01 19:59             ` Timur Tabi
2014-12-01 19:59               ` Timur Tabi
2014-12-01 20:01               ` Arnd Bergmann
2014-12-01 20:01                 ` Arnd Bergmann
2014-12-01 20:11                 ` Timur Tabi
2014-12-01 20:11                   ` Timur Tabi
2014-12-01 20:30                   ` Lars-Peter Clausen
2014-12-01 20:30                     ` Lars-Peter Clausen
2014-12-01 20:40                     ` Fabio Estevam
2014-12-01 20:40                       ` Fabio Estevam
2014-12-01 20:42                       ` Timur Tabi [this message]
2014-12-01 20:42                         ` Timur Tabi
2014-12-01 21:03                         ` Fabio Estevam
2014-12-01 21:03                           ` Fabio Estevam
2014-12-01 20:16                 ` Mark Brown
2014-12-01 20:16                   ` Mark Brown
2014-12-01 19:24     ` Mark Brown
2014-12-01 19:24       ` [alsa-devel] " Mark Brown
2014-12-01 19:24       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547CD2C6.2060107@tabi.org \
    --to=timur@tabi.org \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=jiada_wang@mentor.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpa@pengutronix.de \
    --cc=nicoleotsuka@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.