From: Rik van Riel <riel@redhat.com>
To: Shachar Raindel <raindel@mellanox.com>, linux-mm@kvack.org
Cc: kirill.shutemov@linux.intel.com, mgorman@suse.de,
ak@linux.intel.com, matthew.r.wilcox@intel.com,
dave.hansen@linux.intel.com, n-horiguchi@ah.jp.nec.com,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
haggaie@mellanox.com, aarcange@redhat.com, pfeiner@google.com,
hannes@cmpxchg.org, sagig@mellanox.com, walken@google.com
Subject: Re: [PATCH v2 1/4] mm: Refactor do_wp_page, extract the reuse case
Date: Mon, 01 Dec 2014 17:23:35 -0500 [thread overview]
Message-ID: <547CEA67.1090405@redhat.com> (raw)
In-Reply-To: <1417467491-20071-2-git-send-email-raindel@mellanox.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/01/2014 03:58 PM, Shachar Raindel wrote:
> When do_wp_page is ending, in several cases it needs to reuse the
> existing page. This is achieved by making the page table writable,
> and possibly updating the page-cache state.
>
> Currently, this logic was "called" by using a goto jump. This
> makes following the control flow of the function harder. It is
> also against the coding style guidelines for using goto.
>
> As the code can easily be refactored into a specialized function,
> refactor it out and simplify the code flow in do_wp_page.
>
> Signed-off-by: Shachar Raindel <raindel@mellanox.com>
Acked-by: Rik van Riel <riel@redhat.com>
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJUfOpnAAoJEM553pKExN6DOB4H/iMUoIehI8cC+RF9mrwBlTg2
JUO7aH/Bgkgc/jSTWrFaBwjNPrrWuRQIKnQl/G48W9oLcj8njutH8lk6C8i337tK
PVhwmPZ+0cIZcSWJ7TCL2kFkovb4vA4pDnKGW78+QppjvoMRZRpuia4NVtRnmIp5
wuD7vKztZtfo4G10gnc09KfBYFZkWGn4NwJ+2cRei74K95anX0uXhq8cIOXf2fSJ
APDm+oZX8C/jdW7083k9yHPE46Ite2kZC9C6vLzv4kbHdH3D9lnT3mYkLUtyMeWh
a4pEJNnwAxkTdE5ghRUK+aqhMmq3k3VmAUo9QXcy7gNBZ7s02elruqIH6GjjE28=
=rVzj
-----END PGP SIGNATURE-----
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-12-01 22:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 20:58 [PATCH v2 0/4] Refactor do_wp_page, no functional change Shachar Raindel
2014-12-01 20:58 ` [PATCH v2 1/4] mm: Refactor do_wp_page, extract the reuse case Shachar Raindel
2014-12-01 22:23 ` Rik van Riel [this message]
2014-12-01 20:58 ` [PATCH v2 2/4] mm: Refactor do_wp_page - rewrite the unlock flow Shachar Raindel
2014-12-01 22:46 ` Rik van Riel
2014-12-01 20:58 ` [PATCH v2 3/4] mm: refactor do_wp_page, extract the page copy flow Shachar Raindel
2014-12-02 2:53 ` Rik van Riel
2014-12-02 9:09 ` Shachar Raindel
2014-12-02 14:56 ` Rik van Riel
2014-12-01 20:58 ` [PATCH v2 4/4] mm: Refactor do_wp_page handling of shared vma into a function Shachar Raindel
2014-12-02 2:57 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547CEA67.1090405@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=haggaie@mellanox.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=pfeiner@google.com \
--cc=raindel@mellanox.com \
--cc=sagig@mellanox.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.