From: Rik van Riel <riel@redhat.com>
To: Shachar Raindel <raindel@mellanox.com>, linux-mm@kvack.org
Cc: kirill.shutemov@linux.intel.com, mgorman@suse.de,
ak@linux.intel.com, matthew.r.wilcox@intel.com,
dave.hansen@linux.intel.com, n-horiguchi@ah.jp.nec.com,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
haggaie@mellanox.com, aarcange@redhat.com, pfeiner@google.com,
hannes@cmpxchg.org, sagig@mellanox.com, walken@google.com
Subject: Re: [PATCH v2 4/4] mm: Refactor do_wp_page handling of shared vma into a function
Date: Mon, 01 Dec 2014 21:57:56 -0500 [thread overview]
Message-ID: <547D2AB4.2040005@redhat.com> (raw)
In-Reply-To: <1417467491-20071-5-git-send-email-raindel@mellanox.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/01/2014 03:58 PM, Shachar Raindel wrote:
> The do_wp_page function is extremely long. Extract the logic for
> handling a page belonging to a shared vma into a function of its
> own.
>
> This helps the readability of the code, without doing any
> functional change in it.
>
> Signed-off-by: Shachar Raindel <raindel@mellanox.com>
Acked-by: Rik van Riel <riel@redhat.com>
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJUfSq0AAoJEM553pKExN6Dww4H+wX6I6UOeQoOtDZqxrpTyvSL
nDXpJ5ltj8eHOdkZKiq5tEzfQygXCAKKqbkfzD0Csqoj96HZFJ7V+uHcxtg8g6+g
0HUpj91XEkVqenBNEuJnlTrbs3XxxUn1fHecm+jD5konfVPaexSNONINsgvArZPd
a0YLMur9PXtuCRhEppfVwRB160BxpkIm4iTnnyF/oaZAz1S/pkiKrb1qhxOanrEP
o2Zry1f4cALiD/yT6+tQCs78pTt23BP0ig7qNQLDiriX2tFwCI37LnYhJzsawF5t
I3B2MD28GdwXYq+RBE3iA+FXdB7cxQIrCHh9OuH+yqm4coPFwJOYET9nCrBruns=
=JXx3
-----END PGP SIGNATURE-----
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-12-02 2:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 20:58 [PATCH v2 0/4] Refactor do_wp_page, no functional change Shachar Raindel
2014-12-01 20:58 ` [PATCH v2 1/4] mm: Refactor do_wp_page, extract the reuse case Shachar Raindel
2014-12-01 22:23 ` Rik van Riel
2014-12-01 20:58 ` [PATCH v2 2/4] mm: Refactor do_wp_page - rewrite the unlock flow Shachar Raindel
2014-12-01 22:46 ` Rik van Riel
2014-12-01 20:58 ` [PATCH v2 3/4] mm: refactor do_wp_page, extract the page copy flow Shachar Raindel
2014-12-02 2:53 ` Rik van Riel
2014-12-02 9:09 ` Shachar Raindel
2014-12-02 14:56 ` Rik van Riel
2014-12-01 20:58 ` [PATCH v2 4/4] mm: Refactor do_wp_page handling of shared vma into a function Shachar Raindel
2014-12-02 2:57 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547D2AB4.2040005@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=haggaie@mellanox.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=pfeiner@google.com \
--cc=raindel@mellanox.com \
--cc=sagig@mellanox.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.