From: Rik van Riel <riel@redhat.com>
To: Shachar Raindel <raindel@mellanox.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"matthew.r.wilcox@intel.com" <matthew.r.wilcox@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"n-horiguchi@ah.jp.nec.com" <n-horiguchi@ah.jp.nec.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
Haggai Eran <haggaie@mellanox.com>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"pfeiner@google.com" <pfeiner@google.com>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
Sagi Grimberg <sagig@mellanox.com>,
"walken@google.com" <walken@google.com>,
Jerome Glisse <j.glisse@gmail.com>
Subject: Re: [PATCH v2 3/4] mm: refactor do_wp_page, extract the page copy flow
Date: Tue, 02 Dec 2014 09:56:39 -0500 [thread overview]
Message-ID: <547DD327.6070708@redhat.com> (raw)
In-Reply-To: <b33f68fb290142379f1189efbd8ea557@AM3PR05MB0935.eurprd05.prod.outlook.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/02/2014 04:09 AM, Shachar Raindel wrote:
>> I believe the mmu_notifier_invalidate_range_start & _end
>> functions can be moved inside the pte_same(*page_table,
>> orig_pte) branch. There is no reason to call those functions if
>> we do not modify the page table entry.
>>
>
> There is a critical reason for this - moving the MMU notifiers
> there will make them unsleepable. This will prevent hardware
> devices that keep secondary PTEs from waiting for an interrupt to
> signal that the invalidation was completed. This is required for
> example by the ODP patch set
> (http://www.spinics.net/lists/linux-rdma/msg22044.html ) and by the
> HMM patch set
> (http://comments.gmane.org/gmane.linux.kernel.mm/116584 ).
Ahhhh, that explains!
Acked-by: Rik van Riel <riel@redhat.com>
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJUfdMnAAoJEM553pKExN6D6HQH/jYio5UBhlPhjp9XjWxwrDHy
7Pcf9nATYQhSN5IuxWp265yHMbFu9CwJefW2DLZLXbynImiy8rkl0HkaaDXEZnM4
ZizjCcxjgNVxD+F+EAsi/bj6kCtxNfmM0YxLCNHjOp835JQzQTbx94Joy1B10ba+
42sTbGBArBVVuDOfHpiUMCj8HFiRT2BNwpfu44eDLAJQiTZIYU5OlXmWnSJQXDDF
c648arGq75fyA8RHRZ/cTf0pztT+Gx5q/2LAxy+MkhiZjX9kXc1e98gWTOO70Qj+
IwP4YAfgScts+uqL2Q+EUVo0nBYAT1amyZft6j3aLQRrDcFhCkITk2VW0CdZHdE=
=IA5v
-----END PGP SIGNATURE-----
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-12-02 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 20:58 [PATCH v2 0/4] Refactor do_wp_page, no functional change Shachar Raindel
2014-12-01 20:58 ` [PATCH v2 1/4] mm: Refactor do_wp_page, extract the reuse case Shachar Raindel
2014-12-01 22:23 ` Rik van Riel
2014-12-01 20:58 ` [PATCH v2 2/4] mm: Refactor do_wp_page - rewrite the unlock flow Shachar Raindel
2014-12-01 22:46 ` Rik van Riel
2014-12-01 20:58 ` [PATCH v2 3/4] mm: refactor do_wp_page, extract the page copy flow Shachar Raindel
2014-12-02 2:53 ` Rik van Riel
2014-12-02 9:09 ` Shachar Raindel
2014-12-02 14:56 ` Rik van Riel [this message]
2014-12-01 20:58 ` [PATCH v2 4/4] mm: Refactor do_wp_page handling of shared vma into a function Shachar Raindel
2014-12-02 2:57 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547DD327.6070708@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=haggaie@mellanox.com \
--cc=hannes@cmpxchg.org \
--cc=j.glisse@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=pfeiner@google.com \
--cc=raindel@mellanox.com \
--cc=sagig@mellanox.com \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.