All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Peres <martin.peres-GANU6spQydw@public.gmane.org>
To: Alexandre Courbot
	<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Vince Hsu <vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	"nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	Peter De Schrijver
	<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RESEND PATCH nouveau 2/3] volt: allow non-bios voltage scaling
Date: Mon, 01 Dec 2014 23:57:39 +0100	[thread overview]
Message-ID: <547CF263.6070900@free.fr> (raw)
In-Reply-To: <CAAVeFuJp5pU62-=Bf=+i8nRX09vgZ4De00_f9kQjbp13jJa0+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 29/11/2014 09:22, Alexandre Courbot wrote:
> On Fri, Nov 28, 2014 at 8:12 PM, Vince Hsu <vinceh@nvidia.com> wrote:
>> Signed-off-by: Vince Hsu <vinceh@nvidia.com>
> Make sure you always write a short summary for your patches, even if
> the title sounds sufficient.

I agree. Something like "Move the vbios parsing out of init() and
call it conditionally if the platform has a vbios. Non-vbios platforms
can use the ctor() to init the data structures.".

> At the very least this patch makes the code easier to read, so:
>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
Acked-by: Martin Peres <martin.peres@free.fr>
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

WARNING: multiple messages have this Message-ID (diff)
From: Martin Peres <martin.peres@free.fr>
To: Alexandre Courbot <gnurou@gmail.com>, Vince Hsu <vinceh@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	Ben Skeggs <bskeggs@redhat.com>,
	"nouveau@lists.freedesktop.org" <nouveau@lists.freedesktop.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH nouveau 2/3] volt: allow non-bios voltage scaling
Date: Mon, 01 Dec 2014 23:57:39 +0100	[thread overview]
Message-ID: <547CF263.6070900@free.fr> (raw)
In-Reply-To: <CAAVeFuJp5pU62-=Bf=+i8nRX09vgZ4De00_f9kQjbp13jJa0+w@mail.gmail.com>

On 29/11/2014 09:22, Alexandre Courbot wrote:
> On Fri, Nov 28, 2014 at 8:12 PM, Vince Hsu <vinceh@nvidia.com> wrote:
>> Signed-off-by: Vince Hsu <vinceh@nvidia.com>
> Make sure you always write a short summary for your patches, even if
> the title sounds sufficient.

I agree. Something like "Move the vbios parsing out of init() and
call it conditionally if the platform has a vbios. Non-vbios platforms
can use the ctor() to init the data structures.".

> At the very least this patch makes the code easier to read, so:
>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
Acked-by: Martin Peres <martin.peres@free.fr>

  parent reply	other threads:[~2014-12-01 22:57 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28 11:12 [RESEND V2 PATCH 1/3] soc/tegra: fuse: export tegra_sku_info for module use Vince Hsu
2014-11-28 11:12 ` Vince Hsu
     [not found] ` <1417173180-21726-1-git-send-email-vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-11-28 11:12   ` [RESEND PATCH nouveau 2/3] volt: allow non-bios voltage scaling Vince Hsu
2014-11-28 11:12     ` Vince Hsu
     [not found]     ` <1417173180-21726-2-git-send-email-vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-11-29  8:22       ` Alexandre Courbot
2014-11-29  8:22         ` Alexandre Courbot
     [not found]         ` <CAAVeFuJp5pU62-=Bf=+i8nRX09vgZ4De00_f9kQjbp13jJa0+w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-01 22:57           ` Martin Peres [this message]
2014-12-01 22:57             ` Martin Peres
2014-11-28 11:13   ` [RESEND PATCH nouveau 3/3] volt: add support for GK20A Vince Hsu
2014-11-28 11:13     ` Vince Hsu
     [not found]     ` <1417173180-21726-3-git-send-email-vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-11-28 11:25       ` Roy Spliet
     [not found]         ` <54785BBA.50800-FA6nBp6kBxZzu6KWmfFNGwC/G2K4zDHf@public.gmane.org>
2014-11-28 11:57           ` Vince Hsu
     [not found]             ` <54786343.4000806-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-11-28 12:09               ` Roy Spliet
     [not found]                 ` <547865EA.10702-FA6nBp6kBxZzu6KWmfFNGwC/G2K4zDHf@public.gmane.org>
2014-11-29  8:44                   ` Alexandre Courbot
     [not found]                     ` <CAAVeFuKY7=WfhAWPiPMkWU8JMg0a7dACqu=BNE+S5SVtdF870w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-01  6:38                       ` Terje Bergström
     [not found]                         ` <547C0CDD.5090506-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-12-01  6:48                           ` Alexandre Courbot
     [not found]                             ` <CAAVeFuLBAyBv4u+op-9A7ZqW0wRwYyxHdd9QG_cu6a=x_hv+Sg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-01  6:52                               ` Alexandre Courbot
     [not found]                                 ` <CAAVeFuKH4LxqgwwtQHL4mZSBKPDnoxtdonK2GBO5pg1hCoHMtg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-01  6:57                                   ` Terje Bergström
2014-12-01 10:20                               ` Roy Spliet
2014-12-01 23:00       ` Martin Peres
2014-12-01 23:00         ` Martin Peres
     [not found]         ` <547CF2F9.6040905-GANU6spQydw@public.gmane.org>
2014-12-01 23:18           ` [Nouveau] " Ben Skeggs
2014-12-01 23:18             ` Ben Skeggs
2014-11-29  7:30   ` [RESEND V2 PATCH 1/3] soc/tegra: fuse: export tegra_sku_info for module use Alexandre Courbot
2014-11-29  7:30     ` Alexandre Courbot
2014-12-01 10:01   ` Thierry Reding
2014-12-01 10:01     ` Thierry Reding
2014-12-01 22:23     ` [Nouveau] " Ben Skeggs
2014-12-01 22:23       ` Ben Skeggs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547CF263.6070900@free.fr \
    --to=martin.peres-ganu6spqydw@public.gmane.org \
    --cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=vinceh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.