Re: [PATCH 2/3] can/peak_usb: CAN-FD: add new adapters specific files

[Oliver Hartkopp <socketcan@hartkopp.net>]

Hi Stephane,

when there are defines that are definitely only relevant for one C file these 
defines should go into this specific C file.

But defines that are (even potentially) relevant for more users should go into 
a .h file, e.g. the ucan defines - or when you have common USB functions that 
are used by PCAN USB and PCAN USB pro.

But definitions that are *only* PCAN USB pro specific should go into 
pcan_usb_pro.c then.

Regards,
Oliver


On 03.12.2014 10:38, Stephane Grosjean wrote:
> Hi Marc,
>
> Le 02/12/2014 16:17, Marc Kleine-Budde a écrit :
>> On 12/02/2014 04:08 PM, Stephane Grosjean wrote:
>>>>>    drivers/net/can/usb/peak_usb/pcan_ucan.h   | 208 +++++++
>>>>>    drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 955
>>>>> +++++++++++++++++++++++++++++
>>>>>    drivers/net/can/usb/peak_usb/pcan_usb_fd.h | 108 ++++
>>>> Please don't create a header file, if it's only included once. Please
>>>> merge into the correct .c file.
>>> Ok. So I merge both header files into the .c file. There will be only a
>>> single (and big) pcan_usb_fd.c file.
>> Yes, we only want code in header files that's used in more than one .c file.
>
> Is this rule quite recent? I mean, the current version of peak_usb contains
> "pcan_usb_pro.h" which is included only by "pcan_usb_pro.c"?
>
> Moreover, "pcan_ucan.h" defines some data structures that might be used by
> some other new "non USB" PEAK -FD devices (peak_pci, for example).
> So, how to manage to avoid to have to define several times the same data
> structures and constants, please?
>
> Stéphane
> --
> PEAK-System Technik GmbH
> Sitz der Gesellschaft Darmstadt
> Handelsregister Darmstadt HRB 9183 Geschaeftsfuehrung: Alexander Gach, Uwe
> Wilhelm
> --