Re: [PATCH 2/3] can/peak_usb: CAN-FD: add new adapters specific files

[Stephane Grosjean <s.grosjean@peak-system.com>]

Hi Oliver,

Le 03/12/2014 11:16, Oliver Hartkopp a écrit :
> Hi Stephane,
>
> when there are defines that are definitely only relevant for one C 
> file these defines should go into this specific C file.
>
> But defines that are (even potentially) relevant for more users should 
> go into a .h file, e.g. the ucan defines - or when you have common USB 
> functions that are used by PCAN USB and PCAN USB pro.
>
> But definitions that are *only* PCAN USB pro specific should go into 
> pcan_usb_pro.c then.

Well I know that. My remark was about two points:

- the *kernel 3.4* version of pcan_usb_pro.h defines some data struct 
and constants that are *only* used by pcan_usb_pro.c (see "struct 
pcan_usb_pro_fwinfo", for example). Since it has been acked in the 
mainline in these early times, I simply asked if and when this rule did 
evolve? Underlying question: what to do now? Should I (also) post 
patches to setup things right between pcan_usb_pro.c and pcan_usb_pro.h, 
in order to define (for ex) "struct pcan_usb_pro_fwinfo" in 
pcan_usb_pro.c instead? Or do we let things "as is"?

- pcan_ucan.h defines some data structs and constants that will be 
common across different kinds of CAN-FD hardwares. How should I include 
this "pcan_ucan.h" file from a future (for example) PCI CAN-FD driver 
(which, obvioulsy) won't be stored  under "usb/peak_usb" directory).

Regards,

Stéphane
>
> Regards,
> Oliver
>
>
> On 03.12.2014 10:38, Stephane Grosjean wrote:
>> Hi Marc,
>>
>> Le 02/12/2014 16:17, Marc Kleine-Budde a écrit :
>>> On 12/02/2014 04:08 PM, Stephane Grosjean wrote:
>>>>>> drivers/net/can/usb/peak_usb/pcan_ucan.h   | 208 +++++++
>>>>>>    drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 955
>>>>>> +++++++++++++++++++++++++++++
>>>>>>    drivers/net/can/usb/peak_usb/pcan_usb_fd.h | 108 ++++
>>>>> Please don't create a header file, if it's only included once. Please
>>>>> merge into the correct .c file.
>>>> Ok. So I merge both header files into the .c file. There will be 
>>>> only a
>>>> single (and big) pcan_usb_fd.c file.
>>> Yes, we only want code in header files that's used in more than one 
>>> .c file.
>>
>> Is this rule quite recent? I mean, the current version of peak_usb 
>> contains
>> "pcan_usb_pro.h" which is included only by "pcan_usb_pro.c"?
>>
>> Moreover, "pcan_ucan.h" defines some data structures that might be 
>> used by
>> some other new "non USB" PEAK -FD devices (peak_pci, for example).
>> So, how to manage to avoid to have to define several times the same data
>> structures and constants, please?
>>
>> Stéphane
>> -- 
>> PEAK-System Technik GmbH
>> Sitz der Gesellschaft Darmstadt
>> Handelsregister Darmstadt HRB 9183 Geschaeftsfuehrung: Alexander 
>> Gach, Uwe
>> Wilhelm
>> -- 

--
PEAK-System Technik GmbH
Sitz der Gesellschaft Darmstadt
Handelsregister Darmstadt HRB 9183 
Geschaeftsfuehrung: Alexander Gach, Uwe Wilhelm
--