Re: [PATCH 2/3] can/peak_usb: CAN-FD: add new adapters specific files

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]

On 12/03/2014 11:38 AM, Stephane Grosjean wrote:
> Well I know that. My remark was about two points:
> 
> - the *kernel 3.4* version of pcan_usb_pro.h defines some data struct
> and constants that are *only* used by pcan_usb_pro.c (see "struct
> pcan_usb_pro_fwinfo", for example). Since it has been acked in the
> mainline in these early times, I simply asked if and when this rule did
> evolve? Underlying question: what to do now? Should I (also) post
> patches to setup things right between pcan_usb_pro.c and pcan_usb_pro.h,
> in order to define (for ex) "struct pcan_usb_pro_fwinfo" in
> pcan_usb_pro.c instead? Or do we let things "as is"?

No need to clean up the .h files already in the kernel. But please stick
to the rule when adding new files.

> - pcan_ucan.h defines some data structs and constants that will be
> common across different kinds of CAN-FD hardwares. How should I include
> this "pcan_ucan.h" file from a future (for example) PCI CAN-FD driver
> (which, obvioulsy) won't be stored  under "usb/peak_usb" directory).

If it's CAN-FD relevant than it will go under include/linux/can/ somewhere.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]