All of lore.kernel.org
 help / color / mirror / Atom feed
From: frowand.list@gmail.com (Frank Rowand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] devicetree: of: Add bindings for chosen node, stdout-path
Date: Wed, 03 Dec 2014 11:46:09 -0800	[thread overview]
Message-ID: <547F6881.20400@gmail.com> (raw)
In-Reply-To: <CACxGe6vdbURE3=W3Uerwy90piGKhv7-m+-vpUhCiUTKB4AzTsw@mail.gmail.com>

On 12/3/2014 7:12 AM, Grant Likely wrote:
> On Wed, Dec 3, 2014 at 2:24 AM, Frank Rowand <frowand.list@gmail.com> wrote:
>> On 11/27/2014 9:56 AM, Leif Lindholm wrote:
>>> Add a global binding for the chosen node.
>>> Include a description of the stdout-path, and an explicit statement on
>>> its extra options in the context of a UART console.
>>>
>>> Opening description stolen from www.devicetree.org, and part of the
>>> remaining text provided by Mark Rutland.
>>>
>>> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>>> ---
>>>  Documentation/devicetree/bindings/chosen.txt |   42 ++++++++++++++++++++++++++
>>>  1 file changed, 42 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/chosen.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt
>>> new file mode 100644
>>> index 0000000..9cd74e9
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/chosen.txt
>>> @@ -0,0 +1,42 @@
>>> +The chosen node
>>> +---------------
>>> +
>>> +The chosen node does not represent a real device, but serves as a place
>>> +for passing data between firmware and the operating system, like boot
>>> +arguments. Data in the chosen node does not represent the hardware.
>>> +
>>> +
>>> +stdout-path property
>>
>> The code in patch 3/3 adds the extra options feature to the properties:
>>
>>   stdout-path
>>   linux,stdout-path
>>   stdout  [if (IS_ENABLED(CONFIG_PPC) ... ]
> 
> I don't understand what you mean here. Are you suggesting a change to
> this patch? Is there something deficient in it?

Assuming that the code change in patch 3 is as desired, then the chosen.txt
documentation applies to all three properties, not just stdout-path.  So
yes, a change is suggested for the documentation.

-Frank

WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list@gmail.com>
To: Grant Likely <grant.likely@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>, Ian Campbell <ijc@debian.org>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [PATCH v3 1/3] devicetree: of: Add bindings for chosen node, stdout-path
Date: Wed, 03 Dec 2014 11:46:09 -0800	[thread overview]
Message-ID: <547F6881.20400@gmail.com> (raw)
In-Reply-To: <CACxGe6vdbURE3=W3Uerwy90piGKhv7-m+-vpUhCiUTKB4AzTsw@mail.gmail.com>

On 12/3/2014 7:12 AM, Grant Likely wrote:
> On Wed, Dec 3, 2014 at 2:24 AM, Frank Rowand <frowand.list@gmail.com> wrote:
>> On 11/27/2014 9:56 AM, Leif Lindholm wrote:
>>> Add a global binding for the chosen node.
>>> Include a description of the stdout-path, and an explicit statement on
>>> its extra options in the context of a UART console.
>>>
>>> Opening description stolen from www.devicetree.org, and part of the
>>> remaining text provided by Mark Rutland.
>>>
>>> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>>> ---
>>>  Documentation/devicetree/bindings/chosen.txt |   42 ++++++++++++++++++++++++++
>>>  1 file changed, 42 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/chosen.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt
>>> new file mode 100644
>>> index 0000000..9cd74e9
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/chosen.txt
>>> @@ -0,0 +1,42 @@
>>> +The chosen node
>>> +---------------
>>> +
>>> +The chosen node does not represent a real device, but serves as a place
>>> +for passing data between firmware and the operating system, like boot
>>> +arguments. Data in the chosen node does not represent the hardware.
>>> +
>>> +
>>> +stdout-path property
>>
>> The code in patch 3/3 adds the extra options feature to the properties:
>>
>>   stdout-path
>>   linux,stdout-path
>>   stdout  [if (IS_ENABLED(CONFIG_PPC) ... ]
> 
> I don't understand what you mean here. Are you suggesting a change to
> this patch? Is there something deficient in it?

Assuming that the code change in patch 3 is as desired, then the chosen.txt
documentation applies to all three properties, not just stdout-path.  So
yes, a change is suggested for the documentation.

-Frank

  reply	other threads:[~2014-12-03 19:46 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 17:56 [PATCH v3 0/3] of: support passing console options with stdout-path Leif Lindholm
2014-11-27 17:56 ` Leif Lindholm
2014-11-27 17:56 ` Leif Lindholm
2014-11-27 17:56 ` [PATCH v3 1/3] devicetree: of: Add bindings for chosen node, stdout-path Leif Lindholm
2014-11-27 17:56   ` Leif Lindholm
2014-11-27 18:41   ` Mark Rutland
2014-11-27 18:41     ` Mark Rutland
2014-11-28  0:22     ` Grant Likely
2014-11-28  0:22       ` Grant Likely
2014-12-03  2:24   ` Frank Rowand
2014-12-03  2:24     ` Frank Rowand
2014-12-03  2:24     ` Frank Rowand
2014-12-03 15:12     ` Grant Likely
2014-12-03 15:12       ` Grant Likely
2014-12-03 15:12       ` Grant Likely
2014-12-03 19:46       ` Frank Rowand [this message]
2014-12-03 19:46         ` Frank Rowand
2014-12-03 21:45         ` Grant Likely
2014-12-03 21:45           ` Grant Likely
2014-12-03 23:07           ` Frank Rowand
2014-12-03 23:07             ` Frank Rowand
2014-12-03 23:07             ` Frank Rowand
2014-12-04 10:39             ` Grant Likely
2014-12-04 10:39               ` Grant Likely
2014-12-04 10:39               ` Grant Likely
2014-11-27 17:56 ` [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path() Leif Lindholm
2014-11-27 17:56   ` Leif Lindholm
2014-11-28  0:44   ` Grant Likely
2014-11-28  0:44     ` Grant Likely
2014-11-28  0:44     ` Grant Likely
2014-11-28 11:34     ` Leif Lindholm
2014-11-28 11:34       ` Leif Lindholm
2014-11-28 11:34       ` Leif Lindholm
2014-11-28 15:25       ` Grant Likely
2014-11-28 15:25         ` Grant Likely
2014-11-28 15:33         ` Grant Likely
2014-11-28 15:33           ` Grant Likely
2014-11-28 16:38         ` [PATCH v3 2/3] of: add optional options parameter to? of_find_node_by_path() Leif Lindholm
2014-11-28 16:38           ` Leif Lindholm
2014-11-28 16:38           ` Leif Lindholm
2014-11-28 23:57           ` Grant Likely
2014-11-28 23:57             ` Grant Likely
2014-11-28 23:57             ` Grant Likely
2015-03-04 15:45   ` [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path() Peter Hurley
2015-03-04 15:45     ` Peter Hurley
2015-03-06 16:52     ` Leif Lindholm
2015-03-06 16:52       ` Leif Lindholm
2015-03-06 16:52       ` Leif Lindholm
2015-03-06 18:11       ` Peter Hurley
2015-03-06 18:11         ` Peter Hurley
2015-03-06 18:59         ` Peter Hurley
2015-03-06 18:59           ` Peter Hurley
2015-03-13 15:23           ` Rob Herring
2015-03-13 15:23             ` Rob Herring
2014-11-27 17:56 ` [PATCH v3 3/3] of: support passing console options with stdout-path Leif Lindholm
2014-11-27 17:56   ` Leif Lindholm
2014-11-28 15:39   ` Grant Likely
2014-11-28 15:39     ` Grant Likely
2015-02-26 11:55   ` Peter Hurley
2015-02-26 11:55     ` Peter Hurley
2015-02-26 13:46     ` Andrew Lunn
2015-02-26 13:46       ` Andrew Lunn
2015-02-26 13:46       ` Andrew Lunn
2015-02-26 14:09       ` Peter Hurley
2015-02-26 14:09         ` Peter Hurley
2015-02-26 14:09         ` Peter Hurley
2015-02-26 14:44         ` Andrew Lunn
2015-02-26 14:44           ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547F6881.20400@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.