From: peter@hurleysoftware.com (Peter Hurley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()
Date: Fri, 06 Mar 2015 13:59:59 -0500 [thread overview]
Message-ID: <54F9F92F.7080900@hurleysoftware.com> (raw)
In-Reply-To: <54F9EDE8.1090902@hurleysoftware.com>
On 03/06/2015 01:11 PM, Peter Hurley wrote:
> On 03/06/2015 11:52 AM, Leif Lindholm wrote:
[...]
>> Could you give the below a spin, and if it works for you, send me the
>> above tests as a full patch so that I can post both as a series?
>
> Will do as soon as I finish testing.
All passed with your patch; patch for testcases below.
Regards,
Peter Hurley
--- >% ---
From: Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH] of: unittest: Add options string testcase variants
Add testcase variants with '/' in the options string to test for
scan beyond end path name terminated by ':'.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
drivers/of/unittest.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 0cf9a23..b2d7547 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -92,6 +92,11 @@ static void __init of_selftest_find_node_by_name(void)
"option path test failed\n");
of_node_put(np);
+ np = of_find_node_opts_by_path("/testcase-data:test/option", &options);
+ selftest(np && !strcmp("test/option", options),
+ "option path test, subcase #1 failed\n");
+ of_node_put(np);
+
np = of_find_node_opts_by_path("/testcase-data:testoption", NULL);
selftest(np, "NULL option path test failed\n");
of_node_put(np);
@@ -102,6 +107,12 @@ static void __init of_selftest_find_node_by_name(void)
"option alias path test failed\n");
of_node_put(np);
+ np = of_find_node_opts_by_path("testcase-alias:test/alias/option",
+ &options);
+ selftest(np && !strcmp("test/alias/option", options),
+ "option alias path test, subcase #1 failed\n");
+ of_node_put(np);
+
np = of_find_node_opts_by_path("testcase-alias:testaliasoption", NULL);
selftest(np, "NULL option alias path test failed\n");
of_node_put(np);
--
2.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter@hurleysoftware.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mark.rutland@arm.com,
grant.likely@linaro.org, robh+dt@kernel.org,
plagnioj@jcrosoft.com, ijc@debian.org, andrew@lunn.ch,
s.hauer@pengutronix.de
Subject: Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()
Date: Fri, 06 Mar 2015 13:59:59 -0500 [thread overview]
Message-ID: <54F9F92F.7080900@hurleysoftware.com> (raw)
In-Reply-To: <54F9EDE8.1090902@hurleysoftware.com>
On 03/06/2015 01:11 PM, Peter Hurley wrote:
> On 03/06/2015 11:52 AM, Leif Lindholm wrote:
[...]
>> Could you give the below a spin, and if it works for you, send me the
>> above tests as a full patch so that I can post both as a series?
>
> Will do as soon as I finish testing.
All passed with your patch; patch for testcases below.
Regards,
Peter Hurley
--- >% ---
From: Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH] of: unittest: Add options string testcase variants
Add testcase variants with '/' in the options string to test for
scan beyond end path name terminated by ':'.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
drivers/of/unittest.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 0cf9a23..b2d7547 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -92,6 +92,11 @@ static void __init of_selftest_find_node_by_name(void)
"option path test failed\n");
of_node_put(np);
+ np = of_find_node_opts_by_path("/testcase-data:test/option", &options);
+ selftest(np && !strcmp("test/option", options),
+ "option path test, subcase #1 failed\n");
+ of_node_put(np);
+
np = of_find_node_opts_by_path("/testcase-data:testoption", NULL);
selftest(np, "NULL option path test failed\n");
of_node_put(np);
@@ -102,6 +107,12 @@ static void __init of_selftest_find_node_by_name(void)
"option alias path test failed\n");
of_node_put(np);
+ np = of_find_node_opts_by_path("testcase-alias:test/alias/option",
+ &options);
+ selftest(np && !strcmp("test/alias/option", options),
+ "option alias path test, subcase #1 failed\n");
+ of_node_put(np);
+
np = of_find_node_opts_by_path("testcase-alias:testaliasoption", NULL);
selftest(np, "NULL option alias path test failed\n");
of_node_put(np);
--
2.3.1
next prev parent reply other threads:[~2015-03-06 18:59 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 17:56 [PATCH v3 0/3] of: support passing console options with stdout-path Leif Lindholm
2014-11-27 17:56 ` Leif Lindholm
2014-11-27 17:56 ` Leif Lindholm
2014-11-27 17:56 ` [PATCH v3 1/3] devicetree: of: Add bindings for chosen node, stdout-path Leif Lindholm
2014-11-27 17:56 ` Leif Lindholm
2014-11-27 18:41 ` Mark Rutland
2014-11-27 18:41 ` Mark Rutland
2014-11-28 0:22 ` Grant Likely
2014-11-28 0:22 ` Grant Likely
2014-12-03 2:24 ` Frank Rowand
2014-12-03 2:24 ` Frank Rowand
2014-12-03 2:24 ` Frank Rowand
2014-12-03 15:12 ` Grant Likely
2014-12-03 15:12 ` Grant Likely
2014-12-03 15:12 ` Grant Likely
2014-12-03 19:46 ` Frank Rowand
2014-12-03 19:46 ` Frank Rowand
2014-12-03 21:45 ` Grant Likely
2014-12-03 21:45 ` Grant Likely
2014-12-03 23:07 ` Frank Rowand
2014-12-03 23:07 ` Frank Rowand
2014-12-03 23:07 ` Frank Rowand
2014-12-04 10:39 ` Grant Likely
2014-12-04 10:39 ` Grant Likely
2014-12-04 10:39 ` Grant Likely
2014-11-27 17:56 ` [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path() Leif Lindholm
2014-11-27 17:56 ` Leif Lindholm
2014-11-28 0:44 ` Grant Likely
2014-11-28 0:44 ` Grant Likely
2014-11-28 0:44 ` Grant Likely
2014-11-28 11:34 ` Leif Lindholm
2014-11-28 11:34 ` Leif Lindholm
2014-11-28 11:34 ` Leif Lindholm
2014-11-28 15:25 ` Grant Likely
2014-11-28 15:25 ` Grant Likely
2014-11-28 15:33 ` Grant Likely
2014-11-28 15:33 ` Grant Likely
2014-11-28 16:38 ` [PATCH v3 2/3] of: add optional options parameter to? of_find_node_by_path() Leif Lindholm
2014-11-28 16:38 ` Leif Lindholm
2014-11-28 16:38 ` Leif Lindholm
2014-11-28 23:57 ` Grant Likely
2014-11-28 23:57 ` Grant Likely
2014-11-28 23:57 ` Grant Likely
2015-03-04 15:45 ` [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path() Peter Hurley
2015-03-04 15:45 ` Peter Hurley
2015-03-06 16:52 ` Leif Lindholm
2015-03-06 16:52 ` Leif Lindholm
2015-03-06 16:52 ` Leif Lindholm
2015-03-06 18:11 ` Peter Hurley
2015-03-06 18:11 ` Peter Hurley
2015-03-06 18:59 ` Peter Hurley [this message]
2015-03-06 18:59 ` Peter Hurley
2015-03-13 15:23 ` Rob Herring
2015-03-13 15:23 ` Rob Herring
2014-11-27 17:56 ` [PATCH v3 3/3] of: support passing console options with stdout-path Leif Lindholm
2014-11-27 17:56 ` Leif Lindholm
2014-11-28 15:39 ` Grant Likely
2014-11-28 15:39 ` Grant Likely
2015-02-26 11:55 ` Peter Hurley
2015-02-26 11:55 ` Peter Hurley
2015-02-26 13:46 ` Andrew Lunn
2015-02-26 13:46 ` Andrew Lunn
2015-02-26 13:46 ` Andrew Lunn
2015-02-26 14:09 ` Peter Hurley
2015-02-26 14:09 ` Peter Hurley
2015-02-26 14:09 ` Peter Hurley
2015-02-26 14:44 ` Andrew Lunn
2015-02-26 14:44 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F9F92F.7080900@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.