All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oded Gabbay <oded.gabbay@amd.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Andrew.Lewycky@amd.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, alexander.deucher@amd.com
Subject: Re: [PATCH] amdkfd: use atomic allocations within srcu callbacks
Date: Thu, 4 Dec 2014 14:27:44 +0200	[thread overview]
Message-ID: <54805340.9010003@amd.com> (raw)
In-Reply-To: <1417619976-8498-1-git-send-email-sasha.levin@oracle.com>



On 12/03/2014 05:19 PM, Sasha Levin wrote:
> srcu callbacks are running in atomic context, we can't allocate using
> __GFP_WAIT.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index b4f49ac..b85eb0b 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -196,7 +196,7 @@ static void kfd_process_destroy_delayed(struct rcu_head *rcu)
>   	mmdrop(p->mm);
>
>   	work = (struct kfd_process_release_work *)
> -		kmalloc(sizeof(struct kfd_process_release_work), GFP_KERNEL);
> +		kmalloc(sizeof(struct kfd_process_release_work), GFP_ATOMIC);
>
>   	if (work) {
>   		INIT_WORK((struct work_struct *) work, kfd_process_wq_release);
>

Thanks!
Applied to my -next tree.

Oded
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Oded Gabbay <oded.gabbay@amd.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: <airlied@linux.ie>, <alexander.deucher@amd.com>,
	<j.glisse@gmail.com>, <linux-kernel@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>, <John.Bridgman@amd.com>,
	<Andrew.Lewycky@amd.com>, <joro@8bytes.org>
Subject: Re: [PATCH] amdkfd: use atomic allocations within srcu callbacks
Date: Thu, 4 Dec 2014 14:27:44 +0200	[thread overview]
Message-ID: <54805340.9010003@amd.com> (raw)
In-Reply-To: <1417619976-8498-1-git-send-email-sasha.levin@oracle.com>



On 12/03/2014 05:19 PM, Sasha Levin wrote:
> srcu callbacks are running in atomic context, we can't allocate using
> __GFP_WAIT.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index b4f49ac..b85eb0b 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -196,7 +196,7 @@ static void kfd_process_destroy_delayed(struct rcu_head *rcu)
>   	mmdrop(p->mm);
>
>   	work = (struct kfd_process_release_work *)
> -		kmalloc(sizeof(struct kfd_process_release_work), GFP_KERNEL);
> +		kmalloc(sizeof(struct kfd_process_release_work), GFP_ATOMIC);
>
>   	if (work) {
>   		INIT_WORK((struct work_struct *) work, kfd_process_wq_release);
>

Thanks!
Applied to my -next tree.

Oded

  reply	other threads:[~2014-12-04 12:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03 15:19 [PATCH] amdkfd: use atomic allocations within srcu callbacks Sasha Levin
2014-12-04 12:27 ` Oded Gabbay [this message]
2014-12-04 12:27   ` Oded Gabbay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54805340.9010003@amd.com \
    --to=oded.gabbay@amd.com \
    --cc=Andrew.Lewycky@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.