From: josh.wu@atmel.com (Josh Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] media: ov2640: add a master clock for sensor
Date: Tue, 9 Dec 2014 11:03:40 +0800 [thread overview]
Message-ID: <5486668C.3000808@atmel.com> (raw)
In-Reply-To: <CAOMZO5ASNUCz908esJ3iTQ6VEQGeNi-HOmqMOf12c633Q8pavw@mail.gmail.com>
Hi, Fabio
On 12/8/2014 11:10 PM, Fabio Estevam wrote:
> On Mon, Dec 8, 2014 at 9:29 AM, Josh Wu <josh.wu@atmel.com> wrote:
>
>> + priv->master_clk = devm_clk_get(&client->dev, "xvclk");
>> + if (IS_ERR(priv->master_clk))
>> + return -EINVAL;
> You should return PTR_ERR(priv->master_clk) instead.
sure. I'll fix it in next version. Thanks.
Best Regards,
Josh Wu
WARNING: multiple messages have this Message-ID (diff)
From: Josh Wu <josh.wu@atmel.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-media <linux-media@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 4/5] media: ov2640: add a master clock for sensor
Date: Tue, 9 Dec 2014 11:03:40 +0800 [thread overview]
Message-ID: <5486668C.3000808@atmel.com> (raw)
In-Reply-To: <CAOMZO5ASNUCz908esJ3iTQ6VEQGeNi-HOmqMOf12c633Q8pavw@mail.gmail.com>
Hi, Fabio
On 12/8/2014 11:10 PM, Fabio Estevam wrote:
> On Mon, Dec 8, 2014 at 9:29 AM, Josh Wu <josh.wu@atmel.com> wrote:
>
>> + priv->master_clk = devm_clk_get(&client->dev, "xvclk");
>> + if (IS_ERR(priv->master_clk))
>> + return -EINVAL;
> You should return PTR_ERR(priv->master_clk) instead.
sure. I'll fix it in next version. Thanks.
Best Regards,
Josh Wu
next prev parent reply other threads:[~2014-12-09 3:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 11:29 [PATCH 0/5] media: ov2640: add device tree support Josh Wu
2014-12-08 11:29 ` Josh Wu
2014-12-08 11:29 ` [PATCH 1/5] media: soc-camera: use icd->control instead of icd->pdev for reset() Josh Wu
2014-12-08 11:29 ` Josh Wu
2014-12-08 11:29 ` [PATCH 2/5] media: ov2640: add async probe function Josh Wu
2014-12-08 11:29 ` Josh Wu
2014-12-08 11:29 ` [PATCH 3/5] media: ov2640: add primary dt support Josh Wu
2014-12-08 11:29 ` Josh Wu
2014-12-08 11:29 ` Josh Wu
2014-12-08 18:39 ` Laurent Pinchart
2014-12-08 18:39 ` Laurent Pinchart
2014-12-09 3:10 ` Josh Wu
2014-12-09 3:10 ` Josh Wu
2014-12-09 3:10 ` Josh Wu
2014-12-09 8:07 ` Laurent Pinchart
2014-12-09 8:07 ` Laurent Pinchart
2014-12-09 8:07 ` Laurent Pinchart
2014-12-08 11:29 ` [PATCH 4/5] media: ov2640: add a master clock for sensor Josh Wu
2014-12-08 11:29 ` Josh Wu
2014-12-08 11:29 ` Josh Wu
2014-12-08 15:10 ` Fabio Estevam
2014-12-08 15:10 ` Fabio Estevam
2014-12-09 3:03 ` Josh Wu [this message]
2014-12-09 3:03 ` Josh Wu
2014-12-08 11:29 ` [PATCH 5/5] media: ov2640: dt: add the device tree binding document Josh Wu
2014-12-08 11:29 ` Josh Wu
2014-12-08 11:29 ` Josh Wu
2014-12-08 18:59 ` Laurent Pinchart
2014-12-08 18:59 ` Laurent Pinchart
2014-12-09 3:19 ` Josh Wu
2014-12-09 3:19 ` Josh Wu
2014-12-09 3:19 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5486668C.3000808@atmel.com \
--to=josh.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.