All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	brcm80211-dev-list <brcm80211-dev-list@broadcom.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Will Deacon <Will.Deacon@arm.com>,
	"Hante Meuleman" <meuleman@broadcom.com>,
	"hauke@hauke-m.de" <hauke@hauke-m.de>,
	David Miller <davem@davemloft.net>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: using DMA-API on ARM
Date: Tue, 9 Dec 2014 12:07:27 +0100	[thread overview]
Message-ID: <5486D7EF.6010902@broadcom.com> (raw)
In-Reply-To: <20141209102904.GJ11285@n2100.arm.linux.org.uk>

On 12/09/14 11:29, Russell King - ARM Linux wrote:
> On Tue, Dec 09, 2014 at 11:19:40AM +0100, Arend van Spriel wrote:
>> The issue did not trigger overnight so it seems setting bit 22<Shared
>> Attribute _Override_ Enable>  solves the issue over here. Now the question is
>> how to move forward with this. As I understood from Catalin this patch was
>> not included as it was not considered responsibility of the linux kernel.
>
> It is preferable for firmware to configure the L2 cache appropriately,
> which includes things like the prefetch offsets as well as feature bits
> like bit 22.
>
> I think what I'll do is queue up a patch which adds a warning if bit 22
> is not set, suggesting that firmware is updated to set this bit.

I was thinking in the same direction. Thanks to you all for looking into 
this. It did not feel right to use the dma_sync_single_for_cpu() for 
memory allocated with dma_alloc_coherent() and I am glad this got 
cleared up.

Regards,
Arend


WARNING: multiple messages have this Message-ID (diff)
From: arend@broadcom.com (Arend van Spriel)
To: linux-arm-kernel@lists.infradead.org
Subject: using DMA-API on ARM
Date: Tue, 9 Dec 2014 12:07:27 +0100	[thread overview]
Message-ID: <5486D7EF.6010902@broadcom.com> (raw)
In-Reply-To: <20141209102904.GJ11285@n2100.arm.linux.org.uk>

On 12/09/14 11:29, Russell King - ARM Linux wrote:
> On Tue, Dec 09, 2014 at 11:19:40AM +0100, Arend van Spriel wrote:
>> The issue did not trigger overnight so it seems setting bit 22<Shared
>> Attribute _Override_ Enable>  solves the issue over here. Now the question is
>> how to move forward with this. As I understood from Catalin this patch was
>> not included as it was not considered responsibility of the linux kernel.
>
> It is preferable for firmware to configure the L2 cache appropriately,
> which includes things like the prefetch offsets as well as feature bits
> like bit 22.
>
> I think what I'll do is queue up a patch which adds a warning if bit 22
> is not set, suggesting that firmware is updated to set this bit.

I was thinking in the same direction. Thanks to you all for looking into 
this. It did not feel right to use the dma_sync_single_for_cpu() for 
memory allocated with dma_alloc_coherent() and I am glad this got 
cleared up.

Regards,
Arend

  reply	other threads:[~2014-12-09 11:07 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05  9:22 using DMA-API on ARM Arend van Spriel
2014-12-05  9:22 ` Arend van Spriel
2014-12-05  9:45 ` Russell King - ARM Linux
2014-12-05  9:45   ` Russell King - ARM Linux
2014-12-05 12:24   ` Will Deacon
2014-12-05 12:24     ` Will Deacon
2014-12-05 12:56     ` Hante Meuleman
2014-12-05 12:56       ` Hante Meuleman
2014-12-05 13:23       ` Russell King - ARM Linux
2014-12-05 13:23         ` Russell King - ARM Linux
2014-12-05 14:20         ` Hante Meuleman
2014-12-05 14:20           ` Hante Meuleman
2014-12-05 14:47           ` Arend van Spriel
2014-12-05 14:47             ` Arend van Spriel
2014-12-08 13:47           ` Hante Meuleman
2014-12-08 13:47             ` Hante Meuleman
2014-12-08 15:01             ` Arnd Bergmann
2014-12-08 15:01               ` Arnd Bergmann
2014-12-08 15:17               ` Russell King - ARM Linux
2014-12-08 15:17                 ` Russell King - ARM Linux
2014-12-08 15:22                 ` Arnd Bergmann
2014-12-08 15:22                   ` Arnd Bergmann
2014-12-08 16:03               ` Catalin Marinas
2014-12-08 16:03                 ` Catalin Marinas
2014-12-08 17:01                 ` Arend van Spriel
2014-12-08 17:01                   ` Arend van Spriel
2014-12-09 10:19                   ` Arend van Spriel
2014-12-09 10:19                     ` Arend van Spriel
2014-12-09 10:29                     ` Russell King - ARM Linux
2014-12-09 10:29                       ` Russell King - ARM Linux
2014-12-09 11:07                       ` Arend van Spriel [this message]
2014-12-09 11:07                         ` Arend van Spriel
2014-12-09 11:54                       ` Catalin Marinas
2014-12-09 11:54                         ` Catalin Marinas
2015-01-20 15:22                       ` Fabio Estevam
2015-01-20 15:22                         ` Fabio Estevam
2014-12-08 16:22               ` Arend van Spriel
2014-12-08 16:22                 ` Arend van Spriel
2014-12-08 16:38                 ` Arnd Bergmann
2014-12-08 16:38                   ` Arnd Bergmann
2014-12-08 16:47                   ` Russell King - ARM Linux
2014-12-08 16:47                     ` Russell King - ARM Linux
2014-12-08 16:50                   ` Catalin Marinas
2014-12-08 16:50                     ` Catalin Marinas
2014-12-08 16:54                     ` Russell King - ARM Linux
2014-12-08 16:54                       ` Russell King - ARM Linux
2014-12-05 15:06         ` Russell King - ARM Linux
2014-12-05 15:06           ` Russell King - ARM Linux
2014-12-05 18:28           ` Catalin Marinas
2014-12-05 18:28             ` Catalin Marinas
2014-12-05 19:22             ` Arend van Spriel
2014-12-05 19:22               ` Arend van Spriel
2014-12-05 19:25               ` Russell King - ARM Linux
2014-12-05 19:25                 ` Russell King - ARM Linux
2014-12-05 12:43   ` Arend van Spriel
2014-12-05 12:43     ` Arend van Spriel
2014-12-05 12:59     ` Russell King - ARM Linux
2014-12-05 12:59       ` Russell King - ARM Linux
2014-12-05  9:52 ` Arnd Bergmann
2014-12-05  9:52   ` Arnd Bergmann
2014-12-05 11:11   ` Russell King - ARM Linux
2014-12-05 11:11     ` Russell King - ARM Linux
2014-12-05 11:49     ` Hante Meuleman
2014-12-05 11:49       ` Hante Meuleman
2014-12-05 17:38     ` Catalin Marinas
2014-12-05 17:38       ` Catalin Marinas
2014-12-05 18:24       ` Russell King - ARM Linux
2014-12-05 18:24         ` Russell King - ARM Linux
2014-12-05 18:31         ` Catalin Marinas
2014-12-05 18:31           ` Catalin Marinas
2014-12-05 18:39 ` Catalin Marinas
2014-12-05 18:39   ` Catalin Marinas
2014-12-05 18:53   ` Catalin Marinas
2014-12-05 18:53     ` Catalin Marinas
2014-12-05 19:50     ` Arend van Spriel
2014-12-05 19:50       ` Arend van Spriel
2014-12-08 12:55     ` Johannes Stezenbach
2014-12-08 12:55       ` Johannes Stezenbach
2014-12-08 15:55       ` Catalin Marinas
2014-12-08 15:55         ` Catalin Marinas
2014-12-08 16:50         ` Johannes Stezenbach
2014-12-08 16:50           ` Johannes Stezenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5486D7EF.6010902@broadcom.com \
    --to=arend@broadcom.com \
    --cc=Will.Deacon@arm.com \
    --cc=arnd@arndb.de \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=hauke@hauke-m.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=meuleman@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.