All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>,  qemu-trivial@nongnu.org
Cc: sw@weilnetz.de, armbru@redhat.com, qemu-devel@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	peter.huangpeng@huawei.com, afaerber@suse.de
Subject: Re: [Qemu-trivial] [PATCH v2] vt82c686: fix coverity warning about out-of-bounds write
Date: Wed, 10 Dec 2014 11:57:36 +0300	[thread overview]
Message-ID: <54880B00.3030108@msgid.tls.msk.ru> (raw)
In-Reply-To: <1418109359-2364-1-git-send-email-zhang.zhanghailiang@huawei.com>

09.12.2014 10:15, zhanghailiang wrote:
> Refactor superio_ioport_writeb to fix the out of bounds write warning.

Is it just a warning, or real oob write?
From the code it looks like it's just a warning...

[]
> +
> +        }
> +        if (can_write == true) {

09.12.2014 17:08, Paolo Bonzini wrote:
> Michael, can you remove "== true" when applying this patch?

Sure, just did.  Does it mean I can add your R-b too? ;)

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-trivial@nongnu.org
Cc: sw@weilnetz.de, armbru@redhat.com, qemu-devel@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>,
	peter.huangpeng@huawei.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] vt82c686: fix coverity warning about out-of-bounds write
Date: Wed, 10 Dec 2014 11:57:36 +0300	[thread overview]
Message-ID: <54880B00.3030108@msgid.tls.msk.ru> (raw)
In-Reply-To: <1418109359-2364-1-git-send-email-zhang.zhanghailiang@huawei.com>

09.12.2014 10:15, zhanghailiang wrote:
> Refactor superio_ioport_writeb to fix the out of bounds write warning.

Is it just a warning, or real oob write?
>From the code it looks like it's just a warning...

[]
> +
> +        }
> +        if (can_write == true) {

09.12.2014 17:08, Paolo Bonzini wrote:
> Michael, can you remove "== true" when applying this patch?

Sure, just did.  Does it mean I can add your R-b too? ;)

Thanks,

/mjt

  parent reply	other threads:[~2014-12-10  8:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09  7:15 [Qemu-trivial] [PATCH v2] vt82c686: fix coverity warning about out-of-bounds write zhanghailiang
2014-12-09  7:15 ` [Qemu-devel] " zhanghailiang
2014-12-09 14:08 ` [Qemu-trivial] " Paolo Bonzini
2014-12-09 14:08   ` [Qemu-devel] " Paolo Bonzini
2014-12-10  8:57 ` Michael Tokarev [this message]
2014-12-10  8:57   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-12-10  9:14   ` Paolo Bonzini
2014-12-10  9:14     ` [Qemu-devel] " Paolo Bonzini
2014-12-10  9:20   ` zhanghailiang
2014-12-10  9:20     ` [Qemu-devel] " zhanghailiang
2014-12-10  9:53   ` Paolo Bonzini
2014-12-10  9:53     ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54880B00.3030108@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.