From: Tero Kristo <t-kristo@ti.com>
To: Kevin Hilman <khilman@kernel.org>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/2] ARM: OMAP3: clock: fix boot breakage in legacy mode
Date: Mon, 15 Dec 2014 09:56:07 +0200 [thread overview]
Message-ID: <548E9417.50502@ti.com> (raw)
In-Reply-To: <7hvblgk7q0.fsf@deeprootsystems.com>
On 12/12/2014 09:07 PM, Kevin Hilman wrote:
> Hi Tero,
>
> Tero Kristo <t-kristo@ti.com> writes:
>
>> The new usage of determine_rate and set_rate_and_parent calls for
>> OMAP DPLLs assumes the DPLLs must have two parents defined, even
>> if it is the same clock. Legacy clock data did not fullfill this
>> requirement and caused a boot crash. Fixed by adding the missing
>> parent information to the DPLL clocks.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>> Fixes: 2e1a7b014f ("ARM: OMAP3+: DPLL: use determine_rate() and...")
>> Cc: Kevin Hilman <khilman@kernel.org>
>
> I tested this on linux-next (next-20141210, same version where I found
> the bug) and this doesn't fix the boot problem.
>
> BTW, in testing this, I noticed that the OMAP clock code is still
> spitting out compile warnings[1]. These should cleaned up too.
Did you apply both of my patches from this set?
I think the DPLL fix might be required also to get this working properly
on OMAP3 legacy.
-Tero
>
> Kevin
>
> [1]
> ../arch/arm/mach-omap2/cclock3xxx_data.c:263:2: warning: initialization from incompatible pointer type [enabled by default]
> ../arch/arm/mach-omap2/cclock3xxx_data.c:263:2: warning: (near initialization for 'dpll1_ck_ops.determine_rate') [enabled by default]
> ../arch/arm/mach-omap2/cclock3xxx_data.c:376:2: warning: initialization from incompatible pointer type [enabled by default]
> ../arch/arm/mach-omap2/cclock3xxx_data.c:376:2: warning: (near initialization for 'dpll4_ck_ops.determine_rate') [enabled by default]
>
WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP3: clock: fix boot breakage in legacy mode
Date: Mon, 15 Dec 2014 09:56:07 +0200 [thread overview]
Message-ID: <548E9417.50502@ti.com> (raw)
In-Reply-To: <7hvblgk7q0.fsf@deeprootsystems.com>
On 12/12/2014 09:07 PM, Kevin Hilman wrote:
> Hi Tero,
>
> Tero Kristo <t-kristo@ti.com> writes:
>
>> The new usage of determine_rate and set_rate_and_parent calls for
>> OMAP DPLLs assumes the DPLLs must have two parents defined, even
>> if it is the same clock. Legacy clock data did not fullfill this
>> requirement and caused a boot crash. Fixed by adding the missing
>> parent information to the DPLL clocks.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>> Fixes: 2e1a7b014f ("ARM: OMAP3+: DPLL: use determine_rate() and...")
>> Cc: Kevin Hilman <khilman@kernel.org>
>
> I tested this on linux-next (next-20141210, same version where I found
> the bug) and this doesn't fix the boot problem.
>
> BTW, in testing this, I noticed that the OMAP clock code is still
> spitting out compile warnings[1]. These should cleaned up too.
Did you apply both of my patches from this set?
I think the DPLL fix might be required also to get this working properly
on OMAP3 legacy.
-Tero
>
> Kevin
>
> [1]
> ../arch/arm/mach-omap2/cclock3xxx_data.c:263:2: warning: initialization from incompatible pointer type [enabled by default]
> ../arch/arm/mach-omap2/cclock3xxx_data.c:263:2: warning: (near initialization for 'dpll1_ck_ops.determine_rate') [enabled by default]
> ../arch/arm/mach-omap2/cclock3xxx_data.c:376:2: warning: initialization from incompatible pointer type [enabled by default]
> ../arch/arm/mach-omap2/cclock3xxx_data.c:376:2: warning: (near initialization for 'dpll4_ck_ops.determine_rate') [enabled by default]
>
next prev parent reply other threads:[~2014-12-15 7:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 13:21 [PATCH 0/2] ARM: OMAP2+: quick clock fixes for linux-next Tero Kristo
2014-12-12 13:21 ` Tero Kristo
2014-12-12 13:22 ` [PATCH 1/2] ARM: OMAP2+: clock: fix DPLL code to use new determine rate APIs Tero Kristo
2014-12-12 13:22 ` Tero Kristo
2014-12-12 13:22 ` [PATCH 2/2] ARM: OMAP3: clock: fix boot breakage in legacy mode Tero Kristo
2014-12-12 13:22 ` Tero Kristo
2014-12-12 19:07 ` Kevin Hilman
2014-12-12 19:07 ` Kevin Hilman
2014-12-15 7:56 ` Tero Kristo [this message]
2014-12-15 7:56 ` Tero Kristo
2014-12-15 18:23 ` Kevin Hilman
2014-12-15 18:23 ` Kevin Hilman
2014-12-15 22:58 ` Tony Lindgren
2014-12-15 22:58 ` Tony Lindgren
2014-12-16 0:52 ` Tony Lindgren
2014-12-16 0:52 ` Tony Lindgren
2014-12-15 4:35 ` [PATCH 0/2] ARM: OMAP2+: quick clock fixes for linux-next Vignesh R
2014-12-15 4:35 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548E9417.50502@ti.com \
--to=t-kristo@ti.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.