All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Kozłowski" <k.kozlowski@samsung.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c
Date: Thu, 18 Dec 2014 10:26:47 +0000	[thread overview]
Message-ID: <5492ABE7.1060900@samsung.com> (raw)
In-Reply-To: <54920A54.2060608@gmail.com>

On 17.12.2014 23:57, nick wrote:
> Greetings Fellow Maintainers,
> Sorry if I wasting your time but it seems there is a unneeded call to msleep

Hi,

1. Please describe exactly why do you think this is not needed.
2. Do you have Exynos-based hardware to test your changes?

Best regards,
Krzysztof

> and rather trivial fix me to fix in the file,exynos_mipi_dsi_common.c for the function,exynos_mipi_dsi_wr_data . If there is a valid reason for this call please let me known when any of you  have some free time. Otherwise I will send in a patch to remove this unneeded
> call to msleep.
> Thanks,
> Nick  



WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Kozłowski" <k.kozlowski@samsung.com>
To: nick <xerofoify@gmail.com>, inki.dae@samsung.com
Cc: linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	dh09.lee@samsung.com, linux-kernel@vger.kernel.org,
	kyungmin.park@samsung.com, tomi.valkeinen@ti.com,
	kgene@kernel.org, plagnioj@jcrosoft.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c
Date: Thu, 18 Dec 2014 11:26:47 +0100	[thread overview]
Message-ID: <5492ABE7.1060900@samsung.com> (raw)
In-Reply-To: <54920A54.2060608@gmail.com>

On 17.12.2014 23:57, nick wrote:
> Greetings Fellow Maintainers,
> Sorry if I wasting your time but it seems there is a unneeded call to msleep

Hi,

1. Please describe exactly why do you think this is not needed.
2. Do you have Exynos-based hardware to test your changes?

Best regards,
Krzysztof

> and rather trivial fix me to fix in the file,exynos_mipi_dsi_common.c for the function,exynos_mipi_dsi_wr_data . If there is a valid reason for this call please let me known when any of you  have some free time. Otherwise I will send in a patch to remove this unneeded
> call to msleep.
> Thanks,
> Nick  

WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozłowski)
To: linux-arm-kernel@lists.infradead.org
Subject: Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c
Date: Thu, 18 Dec 2014 11:26:47 +0100	[thread overview]
Message-ID: <5492ABE7.1060900@samsung.com> (raw)
In-Reply-To: <54920A54.2060608@gmail.com>

On 17.12.2014 23:57, nick wrote:
> Greetings Fellow Maintainers,
> Sorry if I wasting your time but it seems there is a unneeded call to msleep

Hi,

1. Please describe exactly why do you think this is not needed.
2. Do you have Exynos-based hardware to test your changes?

Best regards,
Krzysztof

> and rather trivial fix me to fix in the file,exynos_mipi_dsi_common.c for the function,exynos_mipi_dsi_wr_data . If there is a valid reason for this call please let me known when any of you  have some free time. Otherwise I will send in a patch to remove this unneeded
> call to msleep.
> Thanks,
> Nick  

  reply	other threads:[~2014-12-18 10:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17 22:57 Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c nick
2014-12-17 22:57 ` nick
2014-12-18 10:26 ` Krzysztof Kozłowski [this message]
2014-12-18 10:26   ` Krzysztof Kozłowski
2014-12-18 10:26   ` Krzysztof Kozłowski
2014-12-18 13:35   ` nick
2014-12-18 13:35     ` nick
2014-12-18 13:39     ` Lucas Stach
2014-12-18 13:39       ` Lucas Stach
2014-12-18 13:39       ` Lucas Stach
2014-12-18 13:48       ` nick
2014-12-18 13:48         ` nick
2014-12-18 14:05         ` Tomi Valkeinen
2014-12-18 14:05           ` Tomi Valkeinen
2014-12-18 14:05           ` Tomi Valkeinen
2014-12-18 14:08           ` nick
2014-12-18 14:08             ` nick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5492ABE7.1060900@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.