From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c
Date: Thu, 18 Dec 2014 14:05:01 +0000 [thread overview]
Message-ID: <5492DF0D.3080607@ti.com> (raw)
In-Reply-To: <5492DB1A.2020704@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]
On 18/12/14 15:48, nick wrote:
> Lucas,
> That's fair do you known of anyone who does have the hardware so we can test my patch. If you do then we can get this fixed rather
> easily.
> Cheers Nick
>
> On 2014-12-18 08:39 AM, Lucas Stach wrote:
>> Am Donnerstag, den 18.12.2014, 08:35 -0500 schrieb nick:
>>> Krzysztof,
>>> If we look at the code for this function, it already is handling the data correctly. In addition the locks
>>> seem to be better protection then msleep. Further more is no reason for this delay as we are neither resetting
>>> the hardware or waiting for the hardware here so why is it needed? I don't have Exynos based hardware lying
>>> around through to test it.
>>
>> If you can't test it, don't touch it. It's that simple.
There seems to be multiple msleep(20)s in exynos_mipi_dsi_common.c, a
few with /* FIXME */ and a few without any comments. Looks like bad (but
relatively harmless) code to me, but as Lucas said, if you can't test
it, don't touch it.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: nick <xerofoify@gmail.com>
Cc: "Lucas Stach" <l.stach@pengutronix.de>,
"Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
inki.dae@samsung.com, linux-fbdev@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, dh09.lee@samsung.com,
linux-kernel@vger.kernel.org, kyungmin.park@samsung.com,
kgene@kernel.org, plagnioj@jcrosoft.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c
Date: Thu, 18 Dec 2014 16:05:01 +0200 [thread overview]
Message-ID: <5492DF0D.3080607@ti.com> (raw)
In-Reply-To: <5492DB1A.2020704@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]
On 18/12/14 15:48, nick wrote:
> Lucas,
> That's fair do you known of anyone who does have the hardware so we can test my patch. If you do then we can get this fixed rather
> easily.
> Cheers Nick
>
> On 2014-12-18 08:39 AM, Lucas Stach wrote:
>> Am Donnerstag, den 18.12.2014, 08:35 -0500 schrieb nick:
>>> Krzysztof,
>>> If we look at the code for this function, it already is handling the data correctly. In addition the locks
>>> seem to be better protection then msleep. Further more is no reason for this delay as we are neither resetting
>>> the hardware or waiting for the hardware here so why is it needed? I don't have Exynos based hardware lying
>>> around through to test it.
>>
>> If you can't test it, don't touch it. It's that simple.
There seems to be multiple msleep(20)s in exynos_mipi_dsi_common.c, a
few with /* FIXME */ and a few without any comments. Looks like bad (but
relatively harmless) code to me, but as Lucas said, if you can't test
it, don't touch it.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c
Date: Thu, 18 Dec 2014 16:05:01 +0200 [thread overview]
Message-ID: <5492DF0D.3080607@ti.com> (raw)
In-Reply-To: <5492DB1A.2020704@gmail.com>
On 18/12/14 15:48, nick wrote:
> Lucas,
> That's fair do you known of anyone who does have the hardware so we can test my patch. If you do then we can get this fixed rather
> easily.
> Cheers Nick
>
> On 2014-12-18 08:39 AM, Lucas Stach wrote:
>> Am Donnerstag, den 18.12.2014, 08:35 -0500 schrieb nick:
>>> Krzysztof,
>>> If we look at the code for this function, it already is handling the data correctly. In addition the locks
>>> seem to be better protection then msleep. Further more is no reason for this delay as we are neither resetting
>>> the hardware or waiting for the hardware here so why is it needed? I don't have Exynos based hardware lying
>>> around through to test it.
>>
>> If you can't test it, don't touch it. It's that simple.
There seems to be multiple msleep(20)s in exynos_mipi_dsi_common.c, a
few with /* FIXME */ and a few without any comments. Looks like bad (but
relatively harmless) code to me, but as Lucas said, if you can't test
it, don't touch it.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141218/0ff61970/attachment.sig>
next prev parent reply other threads:[~2014-12-18 14:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 22:57 Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c nick
2014-12-17 22:57 ` nick
2014-12-18 10:26 ` Krzysztof Kozłowski
2014-12-18 10:26 ` Krzysztof Kozłowski
2014-12-18 10:26 ` Krzysztof Kozłowski
2014-12-18 13:35 ` nick
2014-12-18 13:35 ` nick
2014-12-18 13:39 ` Lucas Stach
2014-12-18 13:39 ` Lucas Stach
2014-12-18 13:39 ` Lucas Stach
2014-12-18 13:48 ` nick
2014-12-18 13:48 ` nick
2014-12-18 14:05 ` Tomi Valkeinen [this message]
2014-12-18 14:05 ` Tomi Valkeinen
2014-12-18 14:05 ` Tomi Valkeinen
2014-12-18 14:08 ` nick
2014-12-18 14:08 ` nick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5492DF0D.3080607@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.