All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] SPI flash ID patches
@ 2014-11-17 14:51 Ben Dooks
  2014-11-17 14:51 ` [U-Boot] [PATCH 1/2] SPI: Add S25FL064A and S25FL116K flash information Ben Dooks
  2014-11-17 14:52 ` [U-Boot] [PATCH 2/2] SPI: Add S25FL164K flash identifier info Ben Dooks
  0 siblings, 2 replies; 7+ messages in thread
From: Ben Dooks @ 2014-11-17 14:51 UTC (permalink / raw)
  To: u-boot

These are a pair of patches adding some SPI flashes that were evaluated
on a Marvell Kirkwood system.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 1/2] SPI: Add S25FL064A and S25FL116K flash information
  2014-11-17 14:51 [U-Boot] SPI flash ID patches Ben Dooks
@ 2014-11-17 14:51 ` Ben Dooks
  2014-12-18 12:14   ` Jagan Teki
  2014-11-17 14:52 ` [U-Boot] [PATCH 2/2] SPI: Add S25FL164K flash identifier info Ben Dooks
  1 sibling, 1 reply; 7+ messages in thread
From: Ben Dooks @ 2014-11-17 14:51 UTC (permalink / raw)
  To: u-boot

From: Adnan Ali <adnan.ali@codethink.co.uk>

Add S25FL064A and S25FL116K flash indentifiers.

Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk>
---
 drivers/mtd/spi/sf_params.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
index 61545ca..462e5c2 100644
--- a/drivers/mtd/spi/sf_params.c
+++ b/drivers/mtd/spi/sf_params.c
@@ -51,6 +51,8 @@ const struct spi_flash_params spi_flash_params_table[] = {
 	{"S25FL016A",	   0x010214, 0x0,	64 * 1024,    32,	0,			  0},
 	{"S25FL032A",	   0x010215, 0x0,	64 * 1024,    64,	0,			  0},
 	{"S25FL064A",	   0x010216, 0x0,	64 * 1024,   128,	0,			  0},
+	{"S25FL064A",      0x010216, 0x0,       64 * 1024,   128,       0,                        0},
+	{"S25FL116k",      0x014015, 0x0,       64 * 1024,   128,       0,                        0},
 	{"S25FL128P_256K", 0x012018, 0x0300,   256 * 1024,    64, RD_FULL,		     WR_QPP},
 	{"S25FL128P_64K",  0x012018, 0x0301,    64 * 1024,   256, RD_FULL,		     WR_QPP},
 	{"S25FL032P",	   0x010215, 0x4d00,    64 * 1024,    64, RD_FULL,		     WR_QPP},
-- 
2.1.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] SPI: Add S25FL164K flash identifier info
  2014-11-17 14:51 [U-Boot] SPI flash ID patches Ben Dooks
  2014-11-17 14:51 ` [U-Boot] [PATCH 1/2] SPI: Add S25FL064A and S25FL116K flash information Ben Dooks
@ 2014-11-17 14:52 ` Ben Dooks
  2014-12-18 13:23   ` Jagan Teki
  1 sibling, 1 reply; 7+ messages in thread
From: Ben Dooks @ 2014-11-17 14:52 UTC (permalink / raw)
  To: u-boot

Add the necessary flash entry for the Spansion S25FL164K
flash. Tested on Marvell 88F6218 based design.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 drivers/mtd/spi/sf_params.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
index 462e5c2..c1f243b 100644
--- a/drivers/mtd/spi/sf_params.c
+++ b/drivers/mtd/spi/sf_params.c
@@ -53,6 +53,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
 	{"S25FL064A",	   0x010216, 0x0,	64 * 1024,   128,	0,			  0},
 	{"S25FL064A",      0x010216, 0x0,       64 * 1024,   128,       0,                        0},
 	{"S25FL116k",      0x014015, 0x0,       64 * 1024,   128,       0,                        0},
+	{"S25FL164K",      0x014017, 0x0140,    64 * 1024,   128,       0,                        0},
 	{"S25FL128P_256K", 0x012018, 0x0300,   256 * 1024,    64, RD_FULL,		     WR_QPP},
 	{"S25FL128P_64K",  0x012018, 0x0301,    64 * 1024,   256, RD_FULL,		     WR_QPP},
 	{"S25FL032P",	   0x010215, 0x4d00,    64 * 1024,    64, RD_FULL,		     WR_QPP},
-- 
2.1.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 1/2] SPI: Add S25FL064A and S25FL116K flash information
  2014-11-17 14:51 ` [U-Boot] [PATCH 1/2] SPI: Add S25FL064A and S25FL116K flash information Ben Dooks
@ 2014-12-18 12:14   ` Jagan Teki
  2014-12-18 13:08     ` Ben Dooks
  0 siblings, 1 reply; 7+ messages in thread
From: Jagan Teki @ 2014-12-18 12:14 UTC (permalink / raw)
  To: u-boot

On 17 November 2014 at 20:21, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> From: Adnan Ali <adnan.ali@codethink.co.uk>
>
> Add S25FL064A and S25FL116K flash indentifiers.
>
> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk>
> ---
>  drivers/mtd/spi/sf_params.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
> index 61545ca..462e5c2 100644
> --- a/drivers/mtd/spi/sf_params.c
> +++ b/drivers/mtd/spi/sf_params.c
> @@ -51,6 +51,8 @@ const struct spi_flash_params spi_flash_params_table[] = {
>         {"S25FL016A",      0x010214, 0x0,       64 * 1024,    32,       0,                        0},
>         {"S25FL032A",      0x010215, 0x0,       64 * 1024,    64,       0,                        0},
>         {"S25FL064A",      0x010216, 0x0,       64 * 1024,   128,       0,                        0},
> +       {"S25FL064A",      0x010216, 0x0,       64 * 1024,   128,       0,                        0},

What is this, already there the same part - any new?

> +       {"S25FL116k",      0x014015, 0x0,       64 * 1024,   128,       0,                        0},

Is this tested! can you rebase master and send the same patches.

>         {"S25FL128P_256K", 0x012018, 0x0300,   256 * 1024,    64, RD_FULL,                   WR_QPP},
>         {"S25FL128P_64K",  0x012018, 0x0301,    64 * 1024,   256, RD_FULL,                   WR_QPP},
>         {"S25FL032P",      0x010215, 0x4d00,    64 * 1024,    64, RD_FULL,                   WR_QPP},
> --
> 2.1.1
>

thanks!
-- 
Jagan.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 1/2] SPI: Add S25FL064A and S25FL116K flash information
  2014-12-18 12:14   ` Jagan Teki
@ 2014-12-18 13:08     ` Ben Dooks
  2014-12-18 13:22       ` Jagan Teki
  0 siblings, 1 reply; 7+ messages in thread
From: Ben Dooks @ 2014-12-18 13:08 UTC (permalink / raw)
  To: u-boot

On 18/12/14 12:14, Jagan Teki wrote:
> On 17 November 2014 at 20:21, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>> From: Adnan Ali <adnan.ali@codethink.co.uk>
>>
>> Add S25FL064A and S25FL116K flash indentifiers.
>>
>> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk>
>> ---
>>  drivers/mtd/spi/sf_params.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
>> index 61545ca..462e5c2 100644
>> --- a/drivers/mtd/spi/sf_params.c
>> +++ b/drivers/mtd/spi/sf_params.c
>> @@ -51,6 +51,8 @@ const struct spi_flash_params spi_flash_params_table[] = {
>>         {"S25FL016A",      0x010214, 0x0,       64 * 1024,    32,       0,                        0},
>>         {"S25FL032A",      0x010215, 0x0,       64 * 1024,    64,       0,                        0},
>>         {"S25FL064A",      0x010216, 0x0,       64 * 1024,   128,       0,                        0},
>> +       {"S25FL064A",      0x010216, 0x0,       64 * 1024,   128,       0,                        0},
> 
> What is this, already there the same part - any new?

I must have missed this when re-basing off the previous u-boot.

>> +       {"S25FL116k",      0x014015, 0x0,       64 * 1024,   128,       0,                        0},
> 
> Is this tested! can you rebase master and send the same patches.

Yes, it was one of the devices we looked at and tested on a Marvell
88F6281 based system.

>>         {"S25FL128P_256K", 0x012018, 0x0300,   256 * 1024,    64, RD_FULL,                   WR_QPP},
>>         {"S25FL128P_64K",  0x012018, 0x0301,    64 * 1024,   256, RD_FULL,                   WR_QPP},
>>         {"S25FL032P",      0x010215, 0x4d00,    64 * 1024,    64, RD_FULL,                   WR_QPP},
>> --
>> 2.1.1
>>
> 
> thanks!
> 


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 1/2] SPI: Add S25FL064A and S25FL116K flash information
  2014-12-18 13:08     ` Ben Dooks
@ 2014-12-18 13:22       ` Jagan Teki
  0 siblings, 0 replies; 7+ messages in thread
From: Jagan Teki @ 2014-12-18 13:22 UTC (permalink / raw)
  To: u-boot

On 18 December 2014 at 18:38, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> On 18/12/14 12:14, Jagan Teki wrote:
>> On 17 November 2014 at 20:21, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>>> From: Adnan Ali <adnan.ali@codethink.co.uk>
>>>
>>> Add S25FL064A and S25FL116K flash indentifiers.
>>>
>>> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk>
>>> ---
>>>  drivers/mtd/spi/sf_params.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
>>> index 61545ca..462e5c2 100644
>>> --- a/drivers/mtd/spi/sf_params.c
>>> +++ b/drivers/mtd/spi/sf_params.c
>>> @@ -51,6 +51,8 @@ const struct spi_flash_params spi_flash_params_table[] = {
>>>         {"S25FL016A",      0x010214, 0x0,       64 * 1024,    32,       0,                        0},
>>>         {"S25FL032A",      0x010215, 0x0,       64 * 1024,    64,       0,                        0},
>>>         {"S25FL064A",      0x010216, 0x0,       64 * 1024,   128,       0,                        0},
>>> +       {"S25FL064A",      0x010216, 0x0,       64 * 1024,   128,       0,                        0},
>>
>> What is this, already there the same part - any new?
>
> I must have missed this when re-basing off the previous u-boot.
>
>>> +       {"S25FL116k",      0x014015, 0x0,       64 * 1024,   128,       0,                        0},
>>
>> Is this tested! can you rebase master and send the same patches.
>
> Yes, it was one of the devices we looked at and tested on a Marvell
> 88F6281 based system.
>
>>>         {"S25FL128P_256K", 0x012018, 0x0300,   256 * 1024,    64, RD_FULL,                   WR_QPP},
>>>         {"S25FL128P_64K",  0x012018, 0x0301,    64 * 1024,   256, RD_FULL,                   WR_QPP},
>>>         {"S25FL032P",      0x010215, 0x4d00,    64 * 1024,    64, RD_FULL,                   WR_QPP},
>>> --
>>> 2.1.1
>>>

Applied to u-boot-spi/master

thanks!
-- 
Jagan.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] SPI: Add S25FL164K flash identifier info
  2014-11-17 14:52 ` [U-Boot] [PATCH 2/2] SPI: Add S25FL164K flash identifier info Ben Dooks
@ 2014-12-18 13:23   ` Jagan Teki
  0 siblings, 0 replies; 7+ messages in thread
From: Jagan Teki @ 2014-12-18 13:23 UTC (permalink / raw)
  To: u-boot

On 17 November 2014 at 20:22, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> Add the necessary flash entry for the Spansion S25FL164K
> flash. Tested on Marvell 88F6218 based design.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
>  drivers/mtd/spi/sf_params.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
> index 462e5c2..c1f243b 100644
> --- a/drivers/mtd/spi/sf_params.c
> +++ b/drivers/mtd/spi/sf_params.c
> @@ -53,6 +53,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
>         {"S25FL064A",      0x010216, 0x0,       64 * 1024,   128,       0,                        0},
>         {"S25FL064A",      0x010216, 0x0,       64 * 1024,   128,       0,                        0},
>         {"S25FL116k",      0x014015, 0x0,       64 * 1024,   128,       0,                        0},
> +       {"S25FL164K",      0x014017, 0x0140,    64 * 1024,   128,       0,                        0},
>         {"S25FL128P_256K", 0x012018, 0x0300,   256 * 1024,    64, RD_FULL,                   WR_QPP},
>         {"S25FL128P_64K",  0x012018, 0x0301,    64 * 1024,   256, RD_FULL,                   WR_QPP},
>         {"S25FL032P",      0x010215, 0x4d00,    64 * 1024,    64, RD_FULL,                   WR_QPP},
> --
> 2.1.1
>

Applied to u-boot-spi/master

thanks!
-- 
Jagan.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-12-18 13:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-17 14:51 [U-Boot] SPI flash ID patches Ben Dooks
2014-11-17 14:51 ` [U-Boot] [PATCH 1/2] SPI: Add S25FL064A and S25FL116K flash information Ben Dooks
2014-12-18 12:14   ` Jagan Teki
2014-12-18 13:08     ` Ben Dooks
2014-12-18 13:22       ` Jagan Teki
2014-11-17 14:52 ` [U-Boot] [PATCH 2/2] SPI: Add S25FL164K flash identifier info Ben Dooks
2014-12-18 13:23   ` Jagan Teki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.