From: Steve Longerbeam <slongerbeam@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org, David Airlie <airlied@linux.ie>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Fabio Estevam <fabio.estevam@freescale.com>,
Shawn Guo <shawn.guo@linaro.org>,
Denis Carikli <denis@eukrea.com>,
Jiada Wang <jiada_wang@mentor.com>,
Steve Longerbeam <steve_longerbeam@mentor.com>
Subject: Re: [PATCH v2 3/7] drm_modes: add videomode_from_drm_display_mode
Date: Fri, 19 Dec 2014 19:10:31 +0000 [thread overview]
Message-ID: <54947827.5050104@gmail.com> (raw)
In-Reply-To: <1418986984.3165.64.camel@pengutronix.de>
On 12/19/2014 03:03 AM, Philipp Zabel wrote:
>
> +EXPORT_SYMBOL_GPL(videomode_from_drm_display_mode);
> Is it ok for drm_modes to export a function that doesn't start with
> drm_ ? We could just rename this to drm_display_mode_to_videomode if
> necessary. I can fix it up as I apply it, but I'd like to know which is
> preferred.
Yeah, drm_display_mode_to_videomode() is probably better,
makes it more clear it's part of the DRM kernel interfaces.
Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steve Longerbeam <slongerbeam@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org, David Airlie <airlied@linux.ie>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Fabio Estevam <fabio.estevam@freescale.com>,
Shawn Guo <shawn.guo@linaro.org>,
Denis Carikli <denis@eukrea.com>,
Jiada Wang <jiada_wang@mentor.com>,
Steve Longerbeam <steve_longerbeam@mentor.com>
Subject: Re: [PATCH v2 3/7] drm_modes: add videomode_from_drm_display_mode
Date: Fri, 19 Dec 2014 11:10:31 -0800 [thread overview]
Message-ID: <54947827.5050104@gmail.com> (raw)
In-Reply-To: <1418986984.3165.64.camel@pengutronix.de>
On 12/19/2014 03:03 AM, Philipp Zabel wrote:
>
> +EXPORT_SYMBOL_GPL(videomode_from_drm_display_mode);
> Is it ok for drm_modes to export a function that doesn't start with
> drm_ ? We could just rename this to drm_display_mode_to_videomode if
> necessary. I can fix it up as I apply it, but I'd like to know which is
> preferred.
Yeah, drm_display_mode_to_videomode() is probably better,
makes it more clear it's part of the DRM kernel interfaces.
Steve
next prev parent reply other threads:[~2014-12-19 19:10 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 2:00 [PATCH v2 0/7] imx-drm: ipuv3-crtc: Implement mode_fixup Steve Longerbeam
2014-12-19 2:00 ` Steve Longerbeam
2014-12-19 2:00 ` [PATCH v2 1/7] gpu: ipu-di: Add ipu_di_adjust_videomode() Steve Longerbeam
2014-12-19 2:00 ` Steve Longerbeam
2014-12-19 11:07 ` Philipp Zabel
2014-12-19 11:07 ` Philipp Zabel
2014-12-19 11:07 ` Philipp Zabel
2014-12-19 2:00 ` [PATCH v2 2/7] gpu: ipu-di: remove some non-functional code Steve Longerbeam
2014-12-19 2:00 ` Steve Longerbeam
2014-12-19 2:00 ` [PATCH v2 3/7] drm_modes: add videomode_from_drm_display_mode Steve Longerbeam
2014-12-19 2:00 ` Steve Longerbeam
2014-12-19 11:03 ` Philipp Zabel
2014-12-19 11:03 ` Philipp Zabel
2014-12-19 11:03 ` Philipp Zabel
2014-12-19 19:03 ` Emil Velikov
2014-12-19 19:03 ` Emil Velikov
2014-12-19 19:03 ` Emil Velikov
2014-12-19 19:10 ` Steve Longerbeam [this message]
2014-12-19 19:10 ` Steve Longerbeam
2014-12-19 2:00 ` [PATCH v2 4/7] imx-drm: ipuv3-crtc: Implement mode_fixup Steve Longerbeam
2014-12-19 2:00 ` Steve Longerbeam
2014-12-20 15:52 ` Russell King - ARM Linux
2014-12-20 15:52 ` Russell King - ARM Linux
2014-12-20 15:52 ` Russell King - ARM Linux
2014-12-22 15:53 ` Philipp Zabel
2014-12-22 15:53 ` Philipp Zabel
2014-12-19 2:00 ` [PATCH v2 5/7] imx-drm: encoder prepare/mode_set must use adjusted mode Steve Longerbeam
2014-12-19 2:00 ` Steve Longerbeam
2014-12-19 2:00 ` [PATCH v2 6/7] gpu: ipu-v3: Use videomode in struct ipu_di_signal_cfg Steve Longerbeam
2014-12-19 2:00 ` Steve Longerbeam
2014-12-19 2:00 ` [PATCH v2 7/7] gpu: ipu-di: Switch to DIV_ROUND_CLOSEST for DI clock divider calc Steve Longerbeam
2014-12-19 2:00 ` Steve Longerbeam
2015-01-07 18:27 ` [PATCH v2 0/7] imx-drm: ipuv3-crtc: Implement mode_fixup Philipp Zabel
2015-01-07 18:27 ` Philipp Zabel
2015-01-23 2:56 ` Liu Ying
2015-01-23 2:56 ` Liu Ying
2015-01-23 2:56 ` Liu Ying
2015-01-23 10:50 ` Philipp Zabel
2015-01-23 10:50 ` Philipp Zabel
2015-01-23 10:50 ` Philipp Zabel
2015-01-23 14:44 ` Fabio Estevam
2015-01-23 14:44 ` Fabio Estevam
2015-01-23 14:44 ` Fabio Estevam
2015-01-23 15:06 ` Fabio Estevam
2015-01-23 15:06 ` Fabio Estevam
2015-01-23 15:06 ` Fabio Estevam
2015-01-23 16:18 ` Philipp Zabel
2015-01-23 16:18 ` Philipp Zabel
2015-01-23 16:27 ` Fabio Estevam
2015-01-23 16:27 ` Fabio Estevam
2015-01-23 16:27 ` Fabio Estevam
2015-01-23 16:39 ` Philipp Zabel
2015-01-23 16:39 ` Philipp Zabel
2015-01-23 16:39 ` Philipp Zabel
2015-01-23 16:41 ` Fabio Estevam
2015-01-23 16:41 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54947827.5050104@gmail.com \
--to=slongerbeam@gmail.com \
--cc=airlied@linux.ie \
--cc=denis@eukrea.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=jiada_wang@mentor.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=plagnioj@jcrosoft.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=shawn.guo@linaro.org \
--cc=steve_longerbeam@mentor.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.