All of lore.kernel.org
 help / color / mirror / Atom feed
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/5] media: ov2640: dt: add the device tree binding document
Date: Mon, 22 Dec 2014 12:47:37 +0100	[thread overview]
Message-ID: <549804D9.4010504@samsung.com> (raw)
In-Reply-To: <5497F327.4040903@atmel.com>

Hi Josh,

On 22/12/14 11:32, Josh Wu wrote:
>>> +Required Properties:
>>> >> +- compatible: Must be "ovti,ov2640"
>> > I believe it is preferred to put it as "Should contain", rather than
>> > "Must be".
>
> I don't have a strong opinion here. After check many documents, it seems 
> many people use "Should be".
> Is it okay?

That's probably slightly better. In general, the point is that the
'compatible' property could potentially contain multiple values, e.g. when
there is introduced a common more generic compatible value for a set
of sensors. However your documentation now says that only one specific value
is allowed. I'm adding Mark at Cc, perhaps he can explain it better.

Please don't consider it as an objection from my side, since we now have
mixture of "must be", "should be", "should contain", etc. across the
DT binding documentation files.

--
Regards,
Sylwester

WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: linux-media@vger.kernel.org, g.liakhovetski@gmx.de,
	m.chehab@samsung.com, linux-arm-kernel@lists.infradead.org,
	laurent.pinchart@ideasonboard.com, festevam@gmail.com,
	devicetree@vger.kernel.org, Mark Rutland <Mark.Rutland@arm.com>
Subject: Re: [PATCH v4 5/5] media: ov2640: dt: add the device tree binding document
Date: Mon, 22 Dec 2014 12:47:37 +0100	[thread overview]
Message-ID: <549804D9.4010504@samsung.com> (raw)
In-Reply-To: <5497F327.4040903@atmel.com>

Hi Josh,

On 22/12/14 11:32, Josh Wu wrote:
>>> +Required Properties:
>>> >> +- compatible: Must be "ovti,ov2640"
>> > I believe it is preferred to put it as "Should contain", rather than
>> > "Must be".
>
> I don't have a strong opinion here. After check many documents, it seems 
> many people use "Should be".
> Is it okay?

That's probably slightly better. In general, the point is that the
'compatible' property could potentially contain multiple values, e.g. when
there is introduced a common more generic compatible value for a set
of sensors. However your documentation now says that only one specific value
is allowed. I'm adding Mark at Cc, perhaps he can explain it better.

Please don't consider it as an objection from my side, since we now have
mixture of "must be", "should be", "should contain", etc. across the
DT binding documentation files.

--
Regards,
Sylwester

  reply	other threads:[~2014-12-22 11:47 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18  2:27 [PATCH v4 0/5] media: ov2640: add device tree support Josh Wu
2014-12-18  2:27 ` Josh Wu
2014-12-18  2:27 ` [PATCH v4 1/5] media: soc-camera: use icd->control instead of icd->pdev for reset() Josh Wu
2014-12-18  2:27   ` Josh Wu
2014-12-18  2:27 ` [PATCH v4 2/5] media: ov2640: add async probe function Josh Wu
2014-12-18  2:27   ` Josh Wu
2014-12-18 21:59   ` Guennadi Liakhovetski
2014-12-18 21:59     ` Guennadi Liakhovetski
2014-12-19  6:11     ` Josh Wu
2014-12-19  6:11       ` Josh Wu
2014-12-19 22:16       ` Guennadi Liakhovetski
2014-12-19 22:16         ` Guennadi Liakhovetski
2014-12-22 10:27         ` Josh Wu
2014-12-22 10:27           ` Josh Wu
2014-12-24 22:39           ` Guennadi Liakhovetski
2014-12-24 22:39             ` Guennadi Liakhovetski
2014-12-26  6:37             ` Josh Wu
2014-12-26  6:37               ` Josh Wu
2014-12-26  9:01               ` Laurent Pinchart
2014-12-26  9:01                 ` Laurent Pinchart
2014-12-26  9:14                 ` Guennadi Liakhovetski
2014-12-26  9:14                   ` Guennadi Liakhovetski
2014-12-26 10:06                   ` Laurent Pinchart
2014-12-26 10:06                     ` Laurent Pinchart
2014-12-26 10:38                     ` Guennadi Liakhovetski
2014-12-26 10:38                       ` Guennadi Liakhovetski
2014-12-30  0:23                       ` Laurent Pinchart
2014-12-30  0:23                         ` Laurent Pinchart
2014-12-30  8:36                         ` Guennadi Liakhovetski
2014-12-30  8:36                           ` Guennadi Liakhovetski
2014-12-30  8:58                           ` Laurent Pinchart
2014-12-30  8:58                             ` Laurent Pinchart
2014-12-30 10:08                           ` Josh Wu
2014-12-30 10:08                             ` Josh Wu
2014-12-30 12:12                             ` Guennadi Liakhovetski
2014-12-30 12:12                               ` Guennadi Liakhovetski
2015-01-01 17:44                               ` Laurent Pinchart
2015-01-01 17:44                                 ` Laurent Pinchart
2014-12-29  8:28                     ` Josh Wu
2014-12-29  8:28                       ` Josh Wu
2014-12-30  0:15                       ` Laurent Pinchart
2014-12-30  0:15                         ` Laurent Pinchart
2014-12-30 10:02                         ` Josh Wu
2014-12-30 10:02                           ` Josh Wu
2015-01-01 17:43                           ` Laurent Pinchart
2015-01-01 17:43                             ` Laurent Pinchart
2014-12-18  2:27 ` [PATCH v4 3/5] media: ov2640: add primary dt support Josh Wu
2014-12-18  2:27   ` Josh Wu
2014-12-18  2:27   ` Josh Wu
2014-12-18  2:27 ` [PATCH v4 4/5] media: ov2640: add a master clock for sensor Josh Wu
2014-12-18  2:27   ` Josh Wu
2014-12-18  2:27   ` Josh Wu
2014-12-18  2:27 ` [PATCH v4 5/5] media: ov2640: dt: add the device tree binding document Josh Wu
2014-12-18  2:27   ` Josh Wu
2014-12-18  2:27   ` Josh Wu
2014-12-18 11:56   ` Laurent Pinchart
2014-12-18 11:56     ` Laurent Pinchart
2014-12-18 12:13   ` Sylwester Nawrocki
2014-12-18 12:13     ` Sylwester Nawrocki
2014-12-18 12:21     ` Fabio Estevam
2014-12-18 12:21       ` Fabio Estevam
2014-12-22 10:32     ` Josh Wu
2014-12-22 10:32       ` Josh Wu
2014-12-22 10:32       ` Josh Wu
2014-12-22 11:47       ` Sylwester Nawrocki [this message]
2014-12-22 11:47         ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549804D9.4010504@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.