All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oded Gabbay <oded.gabbay@amd.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Dana Elifaz" <Dana.Elifaz@amd.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	iommu@lists.linux-foundation.org,
	"Alexander Deucher" <Alexander.Deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 1/2] drivers: Move iommu/ before gpu/ in Makefile
Date: Tue, 23 Dec 2014 14:09:07 +0200	[thread overview]
Message-ID: <54995B63.5090808@amd.com> (raw)
In-Reply-To: <1419246435-7050-2-git-send-email-oded.gabbay@amd.com>

Hello Linus,
Dave Airlie asked me to send this patch to you for review.
See link below for cover-letter for this patch that explains the background a 
bit more:
http://lists.freedesktop.org/archives/dri-devel/2014-December/074452.html

Thanks,
	Oded


On 12/22/2014 01:07 PM, Oded Gabbay wrote:
> AMD GPU devices are dependent on AMD IOMMU controller functionality to allow
> the GPU to access a process's virtual memory address space, without the need
> for pinning the memory.
>
> This patch changes the order in the drivers makefile, so iommu/ subsystem is
> linked before gpu/ subsystem. That way, if the gpu and iommu drivers are
> compiled inside the kernel image (not as modules), the correct order of device
> loading is still maintained (iommu module is loaded before gpu module).
>
> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
> ---
>   drivers/Makefile | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index ebee555..106200f 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -50,7 +50,10 @@ obj-$(CONFIG_RESET_CONTROLLER)	+= reset/
>   obj-y				+= tty/
>   obj-y				+= char/
>
> -# gpu/ comes after char for AGP vs DRM startup
> +# iommu/ comes before gpu as gpu are using iommu controllers
> +obj-$(CONFIG_IOMMU_SUPPORT)	+= iommu/
> +
> +# gpu/ comes after char for AGP vs DRM startup and after iommu
>   obj-y				+= gpu/
>
>   obj-$(CONFIG_CONNECTOR)		+= connector/
> @@ -141,7 +144,6 @@ obj-y				+= clk/
>
>   obj-$(CONFIG_MAILBOX)		+= mailbox/
>   obj-$(CONFIG_HWSPINLOCK)	+= hwspinlock/
> -obj-$(CONFIG_IOMMU_SUPPORT)	+= iommu/
>   obj-$(CONFIG_REMOTEPROC)	+= remoteproc/
>   obj-$(CONFIG_RPMSG)		+= rpmsg/
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Oded Gabbay <oded.gabbay@amd.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "David Airlie" <airlied@linux.ie>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Dana Elifaz" <Dana.Elifaz@amd.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Alexander Deucher" <Alexander.Deucher@amd.com>,
	iommu@lists.linux-foundation.org,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 1/2] drivers: Move iommu/ before gpu/ in Makefile
Date: Tue, 23 Dec 2014 14:09:07 +0200	[thread overview]
Message-ID: <54995B63.5090808@amd.com> (raw)
In-Reply-To: <1419246435-7050-2-git-send-email-oded.gabbay@amd.com>

Hello Linus,
Dave Airlie asked me to send this patch to you for review.
See link below for cover-letter for this patch that explains the background a 
bit more:
http://lists.freedesktop.org/archives/dri-devel/2014-December/074452.html

Thanks,
	Oded


On 12/22/2014 01:07 PM, Oded Gabbay wrote:
> AMD GPU devices are dependent on AMD IOMMU controller functionality to allow
> the GPU to access a process's virtual memory address space, without the need
> for pinning the memory.
>
> This patch changes the order in the drivers makefile, so iommu/ subsystem is
> linked before gpu/ subsystem. That way, if the gpu and iommu drivers are
> compiled inside the kernel image (not as modules), the correct order of device
> loading is still maintained (iommu module is loaded before gpu module).
>
> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
> ---
>   drivers/Makefile | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/Makefile b/drivers/Makefile
> index ebee555..106200f 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -50,7 +50,10 @@ obj-$(CONFIG_RESET_CONTROLLER)	+= reset/
>   obj-y				+= tty/
>   obj-y				+= char/
>
> -# gpu/ comes after char for AGP vs DRM startup
> +# iommu/ comes before gpu as gpu are using iommu controllers
> +obj-$(CONFIG_IOMMU_SUPPORT)	+= iommu/
> +
> +# gpu/ comes after char for AGP vs DRM startup and after iommu
>   obj-y				+= gpu/
>
>   obj-$(CONFIG_CONNECTOR)		+= connector/
> @@ -141,7 +144,6 @@ obj-y				+= clk/
>
>   obj-$(CONFIG_MAILBOX)		+= mailbox/
>   obj-$(CONFIG_HWSPINLOCK)	+= hwspinlock/
> -obj-$(CONFIG_IOMMU_SUPPORT)	+= iommu/
>   obj-$(CONFIG_REMOTEPROC)	+= remoteproc/
>   obj-$(CONFIG_RPMSG)		+= rpmsg/
>
>

  reply	other threads:[~2014-12-23 12:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-22 11:07 [PATCH 0/2] Change order of linkage in kernel makefiles for amdkfd Oded Gabbay
2014-12-22 11:07 ` Oded Gabbay
2014-12-22 11:07 ` [PATCH 1/2] drivers: Move iommu/ before gpu/ in Makefile Oded Gabbay
2014-12-22 11:07   ` Oded Gabbay
2014-12-23 12:09   ` Oded Gabbay [this message]
2014-12-23 12:09     ` Oded Gabbay
2014-12-26  0:18     ` Linus Torvalds
2014-12-26  0:18       ` Linus Torvalds
     [not found] ` <1419246435-7050-1-git-send-email-oded.gabbay-5C7GfCeVMHo@public.gmane.org>
2014-12-22 11:07   ` [PATCH 2/2] drm: Put amdkfd before radeon in drm Makefile Oded Gabbay
2014-12-22 11:07     ` Oded Gabbay
2014-12-22 11:56 ` [PATCH 0/2] Change order of linkage in kernel makefiles for amdkfd Christian König
2014-12-22 11:56   ` Christian König
2014-12-25 13:20 ` Thierry Reding
2014-12-25 13:20   ` Thierry Reding
2014-12-26  9:19   ` Laurent Pinchart
2014-12-26  9:19     ` Laurent Pinchart
2014-12-28 11:36     ` Oded Gabbay
2014-12-28 11:36       ` Oded Gabbay
2014-12-29  8:16       ` Laurent Pinchart
2014-12-29  8:16         ` Laurent Pinchart
2014-12-29  9:34         ` Christian König
2014-12-29  9:34           ` Christian König
     [not found]           ` <54A12028.7020303-5C7GfCeVMHo@public.gmane.org>
2015-01-05 15:46             ` Thierry Reding
2015-01-05 15:46               ` Thierry Reding
2015-01-08 14:15               ` Oded Gabbay
2015-01-08 14:15                 ` Oded Gabbay
     [not found]                 ` <54AE910E.5060803-5C7GfCeVMHo@public.gmane.org>
2015-01-09  9:56                   ` Thierry Reding
2015-01-09  9:56                     ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54995B63.5090808@amd.com \
    --to=oded.gabbay@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Dana.Elifaz@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.