All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Nicholas Krause <xerofoify@gmail.com>, stefano.brivio@polimi.it
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	b43-dev@lists.infradead.org, kvalo@codeaurora.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] drivers:net:wireless: Add proper locking for the function,  b43_op_beacon_set_tim in main.c
Date: Fri, 02 Jan 2015 10:40:04 -0600	[thread overview]
Message-ID: <54A6C9E4.80009@lwfinger.net> (raw)
In-Reply-To: <1420184041-6788-1-git-send-email-xerofoify@gmail.com>

On 01/02/2015 01:34 AM, Nicholas Krause wrote:
> This adds proper locking for the function, b43_op_beacon_set_tim in main.c by using the mutex lock
> in the structure pointer wl, as embedded into this pointer as a mutex in order to protect against
> multiple access to the pointer wl when updating the templates for this pointer in the function,
> b43_update_templates internally in the function, b43_op_beacon_set_tim.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>

Although this patch has already been rejected, I want to comment on the subject 
you have chosen. As you are submitting it to the maintainer of 
drivers/net/wireless/, there is no need to place those entities in the subject. 
A better subject would have been "b43: Add proper locking for 
b43_op_beacon_set_tim()".

Larry

WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Nicholas Krause <xerofoify@gmail.com>, stefano.brivio@polimi.it
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	b43-dev@lists.infradead.org, kvalo@codeaurora.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c
Date: Fri, 02 Jan 2015 10:40:04 -0600	[thread overview]
Message-ID: <54A6C9E4.80009@lwfinger.net> (raw)
In-Reply-To: <1420184041-6788-1-git-send-email-xerofoify@gmail.com>

On 01/02/2015 01:34 AM, Nicholas Krause wrote:
> This adds proper locking for the function, b43_op_beacon_set_tim in main.c by using the mutex lock
> in the structure pointer wl, as embedded into this pointer as a mutex in order to protect against
> multiple access to the pointer wl when updating the templates for this pointer in the function,
> b43_update_templates internally in the function, b43_op_beacon_set_tim.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>

Although this patch has already been rejected, I want to comment on the subject 
you have chosen. As you are submitting it to the maintainer of 
drivers/net/wireless/, there is no need to place those entities in the subject. 
A better subject would have been "b43: Add proper locking for 
b43_op_beacon_set_tim()".

Larry



  parent reply	other threads:[~2015-01-02 16:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-02  7:34 [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c Nicholas Krause
2015-01-02  7:34 ` Nicholas Krause
2015-01-02  9:27 ` Michael Büsch
2015-01-02  9:27   ` Michael Büsch
2015-01-02 11:19   ` Rafał Miłecki
2015-01-02 11:19     ` Rafał Miłecki
2015-01-02 11:42     ` Michael Büsch
2015-01-02 11:42       ` Michael Büsch
2015-01-02 17:13   ` nick
2015-01-02 17:13     ` nick
2015-01-02 16:40 ` Larry Finger [this message]
2015-01-02 16:40   ` Larry Finger
2015-01-05  9:29 ` Kalle Valo
2015-01-05  9:29   ` Kalle Valo
2015-01-05 17:16   ` nick
2015-01-05 17:16     ` nick
2015-01-05 17:46     ` Larry Finger
2015-01-05 17:46       ` Larry Finger
2015-01-05 18:21       ` nick
2015-01-05 18:21         ` nick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54A6C9E4.80009@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=b43-dev@lists.infradead.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefano.brivio@polimi.it \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.