From: Oded Gabbay <oded.gabbay@amd.com>
To: lkp@lists.01.org
Subject: Re: [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel
Date: Sun, 11 Jan 2015 13:57:59 +0200 [thread overview]
Message-ID: <54B26547.2030400@amd.com> (raw)
In-Reply-To: <87mw5v4iug.fsf@rustcorp.com.au>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On 01/07/2015 12:58 AM, Rusty Russell wrote:
> Kees Cook <keescook@chromium.org> writes:
>> On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>>> Kees, as far as I can tell you need another 0-terminated vmlinux.relocs
>>> section for weak symbols. These should not be relocated if already 0.
>>
>> A few questions:
>>
>> Why doesn't this break on 32-bit without kASLR? 32-bit does relocation
>> by default, even without CONFIG_RANDOMIZE_BASE.
>
> Well, the offset was 0 until I removed CONFIG_HIBERNATE.
>
>> Are there any symbols that are NULL that aren't weak? I'd expect all
>> strong symbols to have non-zero offsets, but I must be
>> misunderstanding something here.
>
> I don't think there would be. Anyway, you might be able to filter them
> out in x86/tools/relocs itself.
>
> Cheers,
> Rusty.
>
Hi Kees,
Did you had time to look at the problem ?
Oded
WARNING: multiple messages have this Message-ID (diff)
From: Oded Gabbay <oded.gabbay@amd.com>
To: Kees Cook <keescook@chromium.org>
Cc: Andi Kleen <ak@linux.intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Alexander Deucher <Alexander.Deucher@amd.com>,
LKP ML <lkp@01.org>
Subject: Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel
Date: Sun, 11 Jan 2015 13:57:59 +0200 [thread overview]
Message-ID: <54B26547.2030400@amd.com> (raw)
In-Reply-To: <87mw5v4iug.fsf@rustcorp.com.au>
On 01/07/2015 12:58 AM, Rusty Russell wrote:
> Kees Cook <keescook@chromium.org> writes:
>> On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>>> Kees, as far as I can tell you need another 0-terminated vmlinux.relocs
>>> section for weak symbols. These should not be relocated if already 0.
>>
>> A few questions:
>>
>> Why doesn't this break on 32-bit without kASLR? 32-bit does relocation
>> by default, even without CONFIG_RANDOMIZE_BASE.
>
> Well, the offset was 0 until I removed CONFIG_HIBERNATE.
>
>> Are there any symbols that are NULL that aren't weak? I'd expect all
>> strong symbols to have non-zero offsets, but I must be
>> misunderstanding something here.
>
> I don't think there would be. Anyway, you might be able to filter them
> out in x86/tools/relocs itself.
>
> Cheers,
> Rusty.
>
Hi Kees,
Did you had time to look at the problem ?
Oded
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Oded Gabbay <oded.gabbay@amd.com>
To: Kees Cook <keescook@chromium.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Andi Kleen <ak@linux.intel.com>,
Alex Deucher <alexdeucher@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Dana Elifaz" <Dana.Elifaz@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
Alexander Deucher <Alexander.Deucher@amd.com>,
LKP ML <lkp@01.org>
Subject: Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel
Date: Sun, 11 Jan 2015 13:57:59 +0200 [thread overview]
Message-ID: <54B26547.2030400@amd.com> (raw)
In-Reply-To: <87mw5v4iug.fsf@rustcorp.com.au>
On 01/07/2015 12:58 AM, Rusty Russell wrote:
> Kees Cook <keescook@chromium.org> writes:
>> On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>>> Kees, as far as I can tell you need another 0-terminated vmlinux.relocs
>>> section for weak symbols. These should not be relocated if already 0.
>>
>> A few questions:
>>
>> Why doesn't this break on 32-bit without kASLR? 32-bit does relocation
>> by default, even without CONFIG_RANDOMIZE_BASE.
>
> Well, the offset was 0 until I removed CONFIG_HIBERNATE.
>
>> Are there any symbols that are NULL that aren't weak? I'd expect all
>> strong symbols to have non-zero offsets, but I must be
>> misunderstanding something here.
>
> I don't think there would be. Anyway, you might be able to filter them
> out in x86/tools/relocs itself.
>
> Cheers,
> Rusty.
>
Hi Kees,
Did you had time to look at the problem ?
Oded
next prev parent reply other threads:[~2015-01-11 11:57 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 11:11 [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel Oded Gabbay
2014-12-22 11:11 ` Oded Gabbay
2014-12-22 11:11 ` Oded Gabbay
2014-12-22 16:58 ` Alex Deucher
2014-12-22 16:58 ` Alex Deucher
2014-12-22 16:58 ` Alex Deucher
2014-12-22 18:49 ` Andi Kleen
2014-12-22 18:49 ` [LKP] " Andi Kleen
2014-12-22 19:00 ` Andi Kleen
2014-12-22 19:00 ` [LKP] " Andi Kleen
2014-12-22 19:18 ` Oded Gabbay
2014-12-22 19:18 ` [LKP] " Oded Gabbay
2014-12-22 19:18 ` Oded Gabbay
2014-12-23 23:01 ` Rusty Russell
2014-12-23 23:01 ` [LKP] " Rusty Russell
2014-12-24 9:16 ` Oded Gabbay
2014-12-24 9:22 ` Oded Gabbay
2014-12-24 9:22 ` [LKP] " Oded Gabbay
2015-01-05 4:28 ` Rusty Russell
2015-01-05 4:28 ` [LKP] " Rusty Russell
2015-01-06 20:14 ` Kees Cook
2015-01-06 20:14 ` [LKP] " Kees Cook
2015-01-06 22:58 ` Rusty Russell
2015-01-06 22:58 ` [LKP] " Rusty Russell
2015-01-11 11:57 ` Oded Gabbay [this message]
2015-01-11 11:57 ` Oded Gabbay
2015-01-11 11:57 ` Oded Gabbay
2015-01-13 17:15 ` Kees Cook
2015-01-13 17:15 ` [LKP] " Kees Cook
2015-01-16 0:27 ` Kees Cook
2015-01-16 0:27 ` [LKP] " Kees Cook
2015-01-16 11:27 ` Oded Gabbay
2015-01-16 11:27 ` [LKP] " Oded Gabbay
2015-01-16 11:27 ` Oded Gabbay
2015-01-23 4:10 ` Rusty Russell
2015-01-23 4:10 ` [LKP] " Rusty Russell
2014-12-25 12:31 ` Christian König
2014-12-25 12:31 ` [LKP] " Christian König
2014-12-25 12:31 ` Christian König
2014-12-28 9:05 ` Oded Gabbay
2014-12-28 9:05 ` [LKP] " Oded Gabbay
2014-12-28 9:05 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B26547.2030400@amd.com \
--to=oded.gabbay@amd.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.