From: Philipp Hahn <hahn@univention.de>
To: xen-devel@lists.xen.org
Subject: Re: Backport request for "tools/hotplug: set mtu from bridge for tap interface" - for Xen 4.4, 4.5, and unstable
Date: Tue, 13 Jan 2015 08:15:52 +0100 [thread overview]
Message-ID: <54B4C628.2030302@univention.de> (raw)
In-Reply-To: <21683.65102.700004.973125@mariner.uk.xensource.com>
Hello,
On 12.01.2015 18:03, Ian Jackson wrote:
> Charles Arnold writes ("Re: Backport request for "tools/hotplug: set mtu from bridge for tap interface" - for Xen 4.4, 4.5, and unstable"):
>> Add quotes around $bridge and $dev to handle spaces in names.
>> This should go into 4.4, 4.5 and unstable.
>
> Is this really necessary for backporting ?
>
> Frankly I think if you put spaces in your network device names an
> awful lot of things are going to break.
Luckily for you at least Linux does not allow space characters in
interface names: net/core/dev.c:936 dev_valid_name
On the other hand I find not caring about quoting somehow dangerous, as
I already expeienced one desaster caused by missing quotes. Just my 2¢.
Philipp
next prev parent reply other threads:[~2015-01-13 7:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 9:05 delaying 4.4.2 and 4.3.4 Jan Beulich
2014-11-18 18:03 ` Daniel Kiper
2014-11-18 18:24 ` Backport request for "tools/hotplug: set mtu from bridge for tap interface" Ian Jackson
2014-11-18 19:20 ` Charles Arnold
2014-11-19 8:35 ` Daniel Kiper
2015-01-12 15:44 ` Ian Jackson
2015-01-12 16:37 ` Backport request for "tools/hotplug: set mtu from bridge for tap interface" - for Xen 4.3 Charles Arnold
2015-01-12 17:06 ` Ian Jackson
2015-01-13 15:09 ` Daniel Kiper
2015-01-12 16:37 ` Backport request for "tools/hotplug: set mtu from bridge for tap interface" - for Xen 4.4, 4.5, and unstable Charles Arnold
2015-01-12 17:03 ` Ian Jackson
2015-01-12 17:15 ` Charles Arnold
2015-01-13 7:15 ` Philipp Hahn [this message]
2015-01-12 16:44 ` Backport request for "tools/hotplug: set mtu from bridge for tap interface" Charles Arnold
2015-01-13 15:06 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B4C628.2030302@univention.de \
--to=hahn@univention.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.