All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qais Yousef <qais.yousef@imgtec.com>
To: alsa-devel@alsa-project.org
Cc: Vinod Koul <vinod.koul@intel.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly
Date: Tue, 13 Jan 2015 11:42:07 +0000	[thread overview]
Message-ID: <54B5048F.2070709@imgtec.com> (raw)
In-Reply-To: <1418989110-10011-1-git-send-email-qais.yousef@imgtec.com>

Ping

On 12/19/2014 11:38 AM, Qais Yousef wrote:
> Fixes the following compilation error:
>
>     include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’:
>     include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration]
>       if (snd_BUG_ON(!stream))
>
> snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly,
> so include it.
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: linux-kernel@vger.kernel.org
>
> ---
>   include/sound/compress_driver.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h
> index 396e8f73670a..1e2531058b7e 100644
> --- a/include/sound/compress_driver.h
> +++ b/include/sound/compress_driver.h
> @@ -27,6 +27,7 @@
>   
>   #include <linux/types.h>
>   #include <linux/sched.h>
> +#include <sound/core.h>
>   #include <sound/compress_offload.h>
>   #include <sound/asound.h>
>   #include <sound/pcm.h>

WARNING: multiple messages have this Message-ID (diff)
From: Qais Yousef <qais.yousef@imgtec.com>
To: <alsa-devel@alsa-project.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly
Date: Tue, 13 Jan 2015 11:42:07 +0000	[thread overview]
Message-ID: <54B5048F.2070709@imgtec.com> (raw)
In-Reply-To: <1418989110-10011-1-git-send-email-qais.yousef@imgtec.com>

Ping

On 12/19/2014 11:38 AM, Qais Yousef wrote:
> Fixes the following compilation error:
>
>     include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’:
>     include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration]
>       if (snd_BUG_ON(!stream))
>
> snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly,
> so include it.
>
> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: linux-kernel@vger.kernel.org
>
> ---
>   include/sound/compress_driver.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h
> index 396e8f73670a..1e2531058b7e 100644
> --- a/include/sound/compress_driver.h
> +++ b/include/sound/compress_driver.h
> @@ -27,6 +27,7 @@
>   
>   #include <linux/types.h>
>   #include <linux/sched.h>
> +#include <sound/core.h>
>   #include <sound/compress_offload.h>
>   #include <sound/asound.h>
>   #include <sound/pcm.h>


  reply	other threads:[~2015-01-13 11:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 11:38 [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly Qais Yousef
2014-12-19 11:38 ` Qais Yousef
2015-01-13 11:42 ` Qais Yousef [this message]
2015-01-13 11:42   ` Qais Yousef
2015-01-13 14:45   ` Vinod Koul
2015-01-13 14:45     ` Vinod Koul
2015-01-13 16:22     ` Takashi Iwai
2015-01-13 16:22       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B5048F.2070709@imgtec.com \
    --to=qais.yousef@imgtec.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.