All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, Qais Yousef <qais.yousef@imgtec.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly
Date: Tue, 13 Jan 2015 17:22:13 +0100	[thread overview]
Message-ID: <s5hh9vuirbe.wl-tiwai@suse.de> (raw)
In-Reply-To: <20150113144549.GC3085@intel.com>

At Tue, 13 Jan 2015 20:15:49 +0530,
Vinod Koul wrote:
> 
> On Tue, Jan 13, 2015 at 11:42:07AM +0000, Qais Yousef wrote:
> > Ping
> > 
> > On 12/19/2014 11:38 AM, Qais Yousef wrote:
> > >Fixes the following compilation error:
> > >
> > >    include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’:
> > >    include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration]
> > >      if (snd_BUG_ON(!stream))
> > >
> > >snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly,
> > >so include it.
> > >
> > >Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> > >Cc: Vinod Koul <vinod.koul@intel.com>
> > >Cc: Jaroslav Kysela <perex@perex.cz>
> > >Cc: Takashi Iwai <tiwai@suse.de>
> > >Cc: linux-kernel@vger.kernel.org
> > >
> Looks okay to me
> 
> Acked-by: Vinod Koul <vinod.koul@intel.com>

Applied now.  Thanks.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Qais Yousef <qais.yousef@imgtec.com>,
	alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly
Date: Tue, 13 Jan 2015 17:22:13 +0100	[thread overview]
Message-ID: <s5hh9vuirbe.wl-tiwai@suse.de> (raw)
In-Reply-To: <20150113144549.GC3085@intel.com>

At Tue, 13 Jan 2015 20:15:49 +0530,
Vinod Koul wrote:
> 
> On Tue, Jan 13, 2015 at 11:42:07AM +0000, Qais Yousef wrote:
> > Ping
> > 
> > On 12/19/2014 11:38 AM, Qais Yousef wrote:
> > >Fixes the following compilation error:
> > >
> > >    include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’:
> > >    include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration]
> > >      if (snd_BUG_ON(!stream))
> > >
> > >snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly,
> > >so include it.
> > >
> > >Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> > >Cc: Vinod Koul <vinod.koul@intel.com>
> > >Cc: Jaroslav Kysela <perex@perex.cz>
> > >Cc: Takashi Iwai <tiwai@suse.de>
> > >Cc: linux-kernel@vger.kernel.org
> > >
> Looks okay to me
> 
> Acked-by: Vinod Koul <vinod.koul@intel.com>

Applied now.  Thanks.


Takashi

  reply	other threads:[~2015-01-13 16:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 11:38 [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly Qais Yousef
2014-12-19 11:38 ` Qais Yousef
2015-01-13 11:42 ` Qais Yousef
2015-01-13 11:42   ` Qais Yousef
2015-01-13 14:45   ` Vinod Koul
2015-01-13 14:45     ` Vinod Koul
2015-01-13 16:22     ` Takashi Iwai [this message]
2015-01-13 16:22       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hh9vuirbe.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qais.yousef@imgtec.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.