[PATCH] tools/configure: Check if pixman is present on the system

[PATCH] tools/configure: Check if pixman is present on the system

[Julien Grall]

QEMU upstream requires the use of pixman. When pixman is not present the
system, the configure of QEMU will fail with:

ERROR: pixman not present. Your options:
         (1) Preferred: Install the pixman devel package (any recent
             distro should have packages as Xorg needs pixman too).
         (2) Fetch the pixman submodule, using:
             git submodule update --init pixman

I think we can use by default the version on the system. So check it
a Xen configuration time to avoid a build issue later.

Signed-off-by: Julien Grall <julien.grall@linaro.org>

---
    This patch requires to regenerate tools/configure.
---
 tools/configure.ac | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/configure.ac b/tools/configure.ac
index 1ac63a3..321b645 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -325,6 +325,7 @@ esac
  AX_CHECK_UUID
  AX_CHECK_CURSES
 PKG_CHECK_MODULES(glib, [glib-2.0 >= 2.12])
+PKG_CHECK_MODULES(pixman, pixman-1)
 AX_CHECK_FETCHER
 
 # Checks for libraries.
-- 
2.1.4

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Jan Beulich]

>>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>>
>QEMU upstream requires the use of pixman. When pixman is not present the
>system, the configure of QEMU will fail with:
>
>ERROR: pixman not present. Your options:
>(1) Preferred: Install the pixman devel package (any recent
>distro should have packages as Xorg needs pixman too).
>(2) Fetch the pixman submodule, using:
>git submodule update --init pixman
>
>I think we can use by default the version on the system. So check it
>a Xen configuration time to avoid a build issue later.

Since qemu building isn't a required part of building the tools, is a check in
the tools configure process really an appropriate thing to do?

Jan

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Ian Campbell]

On Wed, 2015-01-14 at 07:11 +0000, Jan Beulich wrote:
> >>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>>
> >QEMU upstream requires the use of pixman. When pixman is not present the
> >system, the configure of QEMU will fail with:
> >
> >ERROR: pixman not present. Your options:
> >(1) Preferred: Install the pixman devel package (any recent
> >distro should have packages as Xorg needs pixman too).
> >(2) Fetch the pixman submodule, using:
> >git submodule update --init pixman
> >
> >I think we can use by default the version on the system. So check it
> >a Xen configuration time to avoid a build issue later.
> 
> Since qemu building isn't a required part of building the tools, is a check in
> the tools configure process really an appropriate thing to do?

It's quite annoying as a user to have configure appear to succeed and
then the build to fail due to a missing dependency (whether in a 3rd
party component or not).

We could make this check conditional on --with-qemu-system not being
given, but given the library is readily available I don't think its the
end of the world to have a potentially unnecessary check.

A far more heavy weight (but probably better) solution would be to
arrange for the clone (and necessary downloads) + submodule configure to
happen at configure rather than build time. That's a much bigger job
though and I wouldn't expect anyone to take that on unless they are
super duper keen.

Ian.

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Wei Liu]

On Wed, Jan 14, 2015 at 10:39:45AM +0000, Ian Campbell wrote:
> On Wed, 2015-01-14 at 07:11 +0000, Jan Beulich wrote:
> > >>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>>
> > >QEMU upstream requires the use of pixman. When pixman is not present the
> > >system, the configure of QEMU will fail with:
> > >
> > >ERROR: pixman not present. Your options:
> > >(1) Preferred: Install the pixman devel package (any recent
> > >distro should have packages as Xorg needs pixman too).
> > >(2) Fetch the pixman submodule, using:
> > >git submodule update --init pixman
> > >
> > >I think we can use by default the version on the system. So check it
> > >a Xen configuration time to avoid a build issue later.
> > 
> > Since qemu building isn't a required part of building the tools, is a check in
> > the tools configure process really an appropriate thing to do?
> 
> It's quite annoying as a user to have configure appear to succeed and
> then the build to fail due to a missing dependency (whether in a 3rd
> party component or not).
> 
> We could make this check conditional on --with-qemu-system not being
> given, but given the library is readily available I don't think its the
> end of the world to have a potentially unnecessary check.
> 
> A far more heavy weight (but probably better) solution would be to
> arrange for the clone (and necessary downloads) + submodule configure to
> happen at configure rather than build time. That's a much bigger job
> though and I wouldn't expect anyone to take that on unless they are
> super duper keen.
> 

Or we can state clearly in README / INSTALL that Xen's configure doesn't
check for external projects' dependencies so that we don't end up adding
check for every new dependency in QEMU. Just my 2 cents.

Wei.

> Ian.
> 

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Ian Campbell]

On Wed, 2015-01-14 at 10:43 +0000, Wei Liu wrote:
> On Wed, Jan 14, 2015 at 10:39:45AM +0000, Ian Campbell wrote:
> > On Wed, 2015-01-14 at 07:11 +0000, Jan Beulich wrote:
> > > >>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>>
> > > >QEMU upstream requires the use of pixman. When pixman is not present the
> > > >system, the configure of QEMU will fail with:
> > > >
> > > >ERROR: pixman not present. Your options:
> > > >(1) Preferred: Install the pixman devel package (any recent
> > > >distro should have packages as Xorg needs pixman too).
> > > >(2) Fetch the pixman submodule, using:
> > > >git submodule update --init pixman
> > > >
> > > >I think we can use by default the version on the system. So check it
> > > >a Xen configuration time to avoid a build issue later.
> > > 
> > > Since qemu building isn't a required part of building the tools, is a check in
> > > the tools configure process really an appropriate thing to do?
> > 
> > It's quite annoying as a user to have configure appear to succeed and
> > then the build to fail due to a missing dependency (whether in a 3rd
> > party component or not).
> > 
> > We could make this check conditional on --with-qemu-system not being
> > given, but given the library is readily available I don't think its the
> > end of the world to have a potentially unnecessary check.
> > 
> > A far more heavy weight (but probably better) solution would be to
> > arrange for the clone (and necessary downloads) + submodule configure to
> > happen at configure rather than build time. That's a much bigger job
> > though and I wouldn't expect anyone to take that on unless they are
> > super duper keen.
> > 
> 
> Or we can state clearly in README / INSTALL that Xen's configure doesn't
> check for external projects' dependencies so that we don't end up adding
> check for every new dependency in QEMU. Just my 2 cents.

Having it written down doesn't make it any less annoying when you trip
over it though ;-)

(I'm fine if this is the consensus though)

Ian.

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Stefano Stabellini]

On Wed, 14 Jan 2015, Wei Liu wrote:
> On Wed, Jan 14, 2015 at 10:39:45AM +0000, Ian Campbell wrote:
> > On Wed, 2015-01-14 at 07:11 +0000, Jan Beulich wrote:
> > > >>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>>
> > > >QEMU upstream requires the use of pixman. When pixman is not present the
> > > >system, the configure of QEMU will fail with:
> > > >
> > > >ERROR: pixman not present. Your options:
> > > >(1) Preferred: Install the pixman devel package (any recent
> > > >distro should have packages as Xorg needs pixman too).
> > > >(2) Fetch the pixman submodule, using:
> > > >git submodule update --init pixman
> > > >
> > > >I think we can use by default the version on the system. So check it
> > > >a Xen configuration time to avoid a build issue later.
> > > 
> > > Since qemu building isn't a required part of building the tools, is a check in
> > > the tools configure process really an appropriate thing to do?
> > 
> > It's quite annoying as a user to have configure appear to succeed and
> > then the build to fail due to a missing dependency (whether in a 3rd
> > party component or not).
> > 
> > We could make this check conditional on --with-qemu-system not being
> > given, but given the library is readily available I don't think its the
> > end of the world to have a potentially unnecessary check.
> > 
> > A far more heavy weight (but probably better) solution would be to
> > arrange for the clone (and necessary downloads) + submodule configure to
> > happen at configure rather than build time. That's a much bigger job
> > though and I wouldn't expect anyone to take that on unless they are
> > super duper keen.
> > 
> 
> Or we can state clearly in README / INSTALL that Xen's configure doesn't
> check for external projects' dependencies so that we don't end up adding
> check for every new dependency in QEMU. Just my 2 cents.

I think it would be use unfriendly.

In the vast majority of cases users are going to try to build QEMU as
part of the Xen build, so we might as well try to make it a bit easier
for them listing all dependencies up front.

If I were to download the tarball of a given project, pass all the
configure checks, only to find that the build still fails because of a
missing dependency, I would be quite annoyed.

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Olaf Hering]

On Wed, Jan 14, Ian Campbell wrote:

> A far more heavy weight (but probably better) solution would be to
> arrange for the clone (and necessary downloads) + submodule configure to
> happen at configure rather than build time. That's a much bigger job
> though and I wouldn't expect anyone to take that on unless they are
> super duper keen.

There are not that many dependencies. And having such checks in
tools/configure.ac for essential requirements is actually on my todo
list.

Olaf

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Julien Grall]

Hi Jan,

On 14/01/15 07:11, Jan Beulich wrote:
>>>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>>
>> QEMU upstream requires the use of pixman. When pixman is not present the
>> system, the configure of QEMU will fail with:
>>
>> ERROR: pixman not present. Your options:
>> (1) Preferred: Install the pixman devel package (any recent
>> distro should have packages as Xorg needs pixman too).
>> (2) Fetch the pixman submodule, using:
>> git submodule update --init pixman
>>
>> I think we can use by default the version on the system. So check it
>> a Xen configuration time to avoid a build issue later.
> 
> Since qemu building isn't a required part of building the tools, is a check in
> the tools configure process really an appropriate thing to do?

QEMU is a required part of building the tools. Any failure to build QEMU
will make Xen tools build fail. It's reproductible with "make
install-tools" and pixman not installed.

Regards,

-- 
Julien Grall

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Ian Campbell]

On Wed, 2015-01-14 at 12:13 +0000, Julien Grall wrote:
> Hi Jan,
> 
> On 14/01/15 07:11, Jan Beulich wrote:
> >>>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>>
> >> QEMU upstream requires the use of pixman. When pixman is not present the
> >> system, the configure of QEMU will fail with:
> >>
> >> ERROR: pixman not present. Your options:
> >> (1) Preferred: Install the pixman devel package (any recent
> >> distro should have packages as Xorg needs pixman too).
> >> (2) Fetch the pixman submodule, using:
> >> git submodule update --init pixman
> >>
> >> I think we can use by default the version on the system. So check it
> >> a Xen configuration time to avoid a build issue later.
> > 
> > Since qemu building isn't a required part of building the tools, is a check in
> > the tools configure process really an appropriate thing to do?
> 
> QEMU is a required part of building the tools.

Not stricty true. Pass --with-system-qemu if you wish to avoid it.

>  Any failure to build QEMU
> will make Xen tools build fail. It's reproductible with "make
> install-tools" and pixman not installed.
> 
> Regards,
> 

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Julien Grall]

On 14/01/15 12:24, Ian Campbell wrote:
> On Wed, 2015-01-14 at 12:13 +0000, Julien Grall wrote:
>> Hi Jan,
>>
>> On 14/01/15 07:11, Jan Beulich wrote:
>>>>>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>>
>>>> QEMU upstream requires the use of pixman. When pixman is not present the
>>>> system, the configure of QEMU will fail with:
>>>>
>>>> ERROR: pixman not present. Your options:
>>>> (1) Preferred: Install the pixman devel package (any recent
>>>> distro should have packages as Xorg needs pixman too).
>>>> (2) Fetch the pixman submodule, using:
>>>> git submodule update --init pixman
>>>>
>>>> I think we can use by default the version on the system. So check it
>>>> a Xen configuration time to avoid a build issue later.
>>>
>>> Since qemu building isn't a required part of building the tools, is a check in
>>> the tools configure process really an appropriate thing to do?
>>
>> QEMU is a required part of building the tools.
> 
> Not stricty true. Pass --with-system-qemu if you wish to avoid it.

Right. So the check for glib in the configure for ARM is not necessary
when --with-system-qemu is used.

Might be interesting to avoid checking dependency that is not useful.

Regards,

-- 
Julien Grall

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Ian Campbell]

On Wed, 2015-01-14 at 12:28 +0000, Julien Grall wrote:
> On 14/01/15 12:24, Ian Campbell wrote:
> > On Wed, 2015-01-14 at 12:13 +0000, Julien Grall wrote:
> >> Hi Jan,
> >>
> >> On 14/01/15 07:11, Jan Beulich wrote:
> >>>>>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>>
> >>>> QEMU upstream requires the use of pixman. When pixman is not present the
> >>>> system, the configure of QEMU will fail with:
> >>>>
> >>>> ERROR: pixman not present. Your options:
> >>>> (1) Preferred: Install the pixman devel package (any recent
> >>>> distro should have packages as Xorg needs pixman too).
> >>>> (2) Fetch the pixman submodule, using:
> >>>> git submodule update --init pixman
> >>>>
> >>>> I think we can use by default the version on the system. So check it
> >>>> a Xen configuration time to avoid a build issue later.
> >>>
> >>> Since qemu building isn't a required part of building the tools, is a check in
> >>> the tools configure process really an appropriate thing to do?
> >>
> >> QEMU is a required part of building the tools.
> > 
> > Not stricty true. Pass --with-system-qemu if you wish to avoid it.
> 
> Right. So the check for glib in the configure for ARM is not necessary
> when --with-system-qemu is used.
> 
> Might be interesting to avoid checking dependency that is not useful.

I didn't think it was worth it, but given the objections perhaps putting
all the checks which are there solely for qemu-upstream under a
conditional based on --with-system-qemu is the way to go.

Ian.

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Julien Grall]

On 14/01/15 12:31, Ian Campbell wrote:
> On Wed, 2015-01-14 at 12:28 +0000, Julien Grall wrote:
>> On 14/01/15 12:24, Ian Campbell wrote:
>>> On Wed, 2015-01-14 at 12:13 +0000, Julien Grall wrote:
>>>> Hi Jan,
>>>>
>>>> On 14/01/15 07:11, Jan Beulich wrote:
>>>>>>>> Julien Grall <julien.grall@linaro.org> 01/13/15 7:17 PM >>>
>>>>>> QEMU upstream requires the use of pixman. When pixman is not present the
>>>>>> system, the configure of QEMU will fail with:
>>>>>>
>>>>>> ERROR: pixman not present. Your options:
>>>>>> (1) Preferred: Install the pixman devel package (any recent
>>>>>> distro should have packages as Xorg needs pixman too).
>>>>>> (2) Fetch the pixman submodule, using:
>>>>>> git submodule update --init pixman
>>>>>>
>>>>>> I think we can use by default the version on the system. So check it
>>>>>> a Xen configuration time to avoid a build issue later.
>>>>>
>>>>> Since qemu building isn't a required part of building the tools, is a check in
>>>>> the tools configure process really an appropriate thing to do?
>>>>
>>>> QEMU is a required part of building the tools.
>>>
>>> Not stricty true. Pass --with-system-qemu if you wish to avoid it.
>>
>> Right. So the check for glib in the configure for ARM is not necessary
>> when --with-system-qemu is used.
>>
>> Might be interesting to avoid checking dependency that is not useful.
> 
> I didn't think it was worth it, but given the objections perhaps putting
> all the checks which are there solely for qemu-upstream under a
> conditional based on --with-system-qemu is the way to go.

On x86, glib seems to be required for seabios and ipxe.

Regards,

-- 
Julien Grall

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Ian Campbell]

On Wed, 2015-01-14 at 12:32 +0000, Julien Grall wrote:
> On x86, glib seems to be required for seabios

Only for make gtkconfig, I think? (surely the actual BIOS doesn't need
glib!). We won't use that in our own builds I think.

>  and ipxe.

Really?

If true then there'd be nothing wrong with
AC_IF(using our seabios || using our qemu || whatever)
AC_CHECK ... glib

Ian.

Re: [PATCH] tools/configure: Check if pixman is present on the system

[Julien Grall]

On 14/01/15 12:38, Ian Campbell wrote:
> On Wed, 2015-01-14 at 12:32 +0000, Julien Grall wrote:
>> On x86, glib seems to be required for seabios
> 
> Only for make gtkconfig, I think? (surely the actual BIOS doesn't need
> glib!). We won't use that in our own builds I think.

Ok.

> 
>>  and ipxe.
> 
> Really?

My mistake I grepped too quickly.

So I will change this patch for checking if qemu-system is used.

Regards,

-- 
Julien Grall