All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>
Cc: "Wang, Jiada (ESD)" <Jiada_Wang@mentor.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Frkuska, Joshua" <Joshua_Frkuska@mentor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Subject: Re: unload Audio drivers while playback stream is active case kernel crash
Date: Wed, 14 Jan 2015 13:57:03 +0100	[thread overview]
Message-ID: <54B6679F.1030706@metafoo.de> (raw)
In-Reply-To: <20150114120228.GT4160@sirena.org.uk>

On 01/14/2015 01:02 PM, Mark Brown wrote:
[...]
>>> I don't think that we need to prevent module unload when a stream is active.
>>>   From a framework point of view is not different from hot-unplug. I don't
>>> see a reason why we'd jump through hoops to actively forbid removing the
>>> module once it works just fine.
>
>> Well, the module unload means a more drastic cleanup.  Even if you
>> unbind, the code and data are still there while module unload may
>> clean them up all.
>
>> Above all, disallowing the module unload while using is the common
>> behavior of any other drivers.  Why do we have to be a rebel against
>> all civil manner? :)
>
> That's not true for everything and for ASoC I'd tend to assume that the
> user knows what they're doing and has a good reason for it; it's
> certainly something that can be helpful in development.


My personal opinion on this is that disallowing module removal while a 
driver registered by the module when is in use, while there is no technical 
reason to do so, is a anti-feature. Whether in ALSA or elsewhere.

But looking at the source it seems that this is a core feature of ALSA and 
at least for the card module itself it will do the ref-counting when a 
stream is started/stopped. And we even support setting the owner of a card 
in ASoC. It's just that pretty much no ASoC card driver bothers to set the 
owner field in the snd_soc_card struct. So this particular problem can be 
fixed by updating the imx-wm8962 driver to set the owner field.

- Lars

WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Wang, Jiada (ESD)" <Jiada_Wang@mentor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"Frkuska, Joshua" <Joshua_Frkuska@mentor.com>
Subject: Re: [alsa-devel] unload Audio drivers while playback stream is active case kernel crash
Date: Wed, 14 Jan 2015 13:57:03 +0100	[thread overview]
Message-ID: <54B6679F.1030706@metafoo.de> (raw)
In-Reply-To: <20150114120228.GT4160@sirena.org.uk>

On 01/14/2015 01:02 PM, Mark Brown wrote:
[...]
>>> I don't think that we need to prevent module unload when a stream is active.
>>>   From a framework point of view is not different from hot-unplug. I don't
>>> see a reason why we'd jump through hoops to actively forbid removing the
>>> module once it works just fine.
>
>> Well, the module unload means a more drastic cleanup.  Even if you
>> unbind, the code and data are still there while module unload may
>> clean them up all.
>
>> Above all, disallowing the module unload while using is the common
>> behavior of any other drivers.  Why do we have to be a rebel against
>> all civil manner? :)
>
> That's not true for everything and for ASoC I'd tend to assume that the
> user knows what they're doing and has a good reason for it; it's
> certainly something that can be helpful in development.


My personal opinion on this is that disallowing module removal while a 
driver registered by the module when is in use, while there is no technical 
reason to do so, is a anti-feature. Whether in ALSA or elsewhere.

But looking at the source it seems that this is a core feature of ALSA and 
at least for the card module itself it will do the ref-counting when a 
stream is started/stopped. And we even support setting the owner of a card 
in ASoC. It's just that pretty much no ASoC card driver bothers to set the 
owner field in the snd_soc_card struct. So this particular problem can be 
fixed by updating the imx-wm8962 driver to set the owner field.

- Lars


  reply	other threads:[~2015-01-14 12:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 11:39 unload Audio drivers while playback stream is active case kernel crash Wang, Jiada (ESD)
2015-01-09 11:39 ` Wang, Jiada (ESD)
2015-01-13 17:24 ` Takashi Iwai
2015-01-13 17:24   ` [alsa-devel] " Takashi Iwai
2015-01-13 21:54   ` Mark Brown
2015-01-14  7:43     ` Takashi Iwai
2015-01-14  8:15       ` Lars-Peter Clausen
2015-01-14  8:25         ` jiwang
2015-01-14  8:25           ` [alsa-devel] " jiwang
2015-01-14  9:34           ` Lars-Peter Clausen
2015-01-14  9:34             ` [alsa-devel] " Lars-Peter Clausen
2015-01-14  8:47         ` Takashi Iwai
2015-01-14 10:00           ` Lars-Peter Clausen
2015-01-14 10:00             ` [alsa-devel] " Lars-Peter Clausen
2015-01-14 10:50             ` Takashi Iwai
2015-01-14 12:02               ` Mark Brown
2015-01-14 12:02                 ` [alsa-devel] " Mark Brown
2015-01-14 12:57                 ` Lars-Peter Clausen [this message]
2015-01-14 12:57                   ` Lars-Peter Clausen
2015-01-14 13:06                   ` Takashi Iwai
2015-01-14 13:06                     ` [alsa-devel] " Takashi Iwai
2015-01-14 13:43                   ` Fabio Estevam
2015-01-15  4:40                     ` jiwang
2015-01-15  6:14                       ` Takashi Iwai
2015-01-15  6:14                         ` [alsa-devel] " Takashi Iwai
2015-01-15 10:52                       ` Mark Brown
2015-01-14 13:01                 ` Takashi Iwai
2015-01-14 16:34                   ` Mark Brown
2015-01-15  6:21                     ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2015-01-09 11:49 Wang, Jiada (ESD)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B6679F.1030706@metafoo.de \
    --to=lars@metafoo.de \
    --cc=Jiada_Wang@mentor.com \
    --cc=Joshua_Frkuska@mentor.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.