All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Cc: Tony Lindgren <tony@atomide.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Jason Cooper <jason@lakedaemon.net>, Felipe Balbi <balbi@ti.com>,
	Yingjoe Chen <yingjoe.chen@mediatek.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
	"magnus.damm@gmail.com" <magnus.damm@gmail.com>
Subject: Re: Regression with legacy IRQ numbers caused by 9a1091ef0017
Date: Fri, 16 Jan 2015 17:23:05 +0000	[thread overview]
Message-ID: <54B948F9.2060100@arm.com> (raw)
In-Reply-To: <3822486.YZLIqXdAgt@wuerfel>

On 16/01/15 16:56, Arnd Bergmann wrote:
> On Thursday 15 January 2015 07:37:48 Tony Lindgren wrote:
>> * Marc Zyngier <marc.zyngier@arm.com> [150115 06:46]:
>>> On Thu, Jan 15 2015 at  2:27:56 pm GMT, Arnd Bergmann <arnd@arndb.de> wrote:
>>>> On Thursday 15 January 2015 13:42:57 Marc Zyngier wrote:
>>> Probably there is a workable strategy, but my knowledge about OMAP is
>>> close to *nothing*...
>>
>> I have a feeling this might bite other platforms too and we just have
>> not noticed it yet..
> 
> I'm looking through the entire tree now, scanning for machines that have
> GIC and use IORESOURCE_IRQ or DEFINE_RES_IRQ in their platform code.
> Most platforms using GIC are completely converted to DT and have no
> hardcoded legacy IRQs.
> 
> I have checked that cns3xxx and realview are both fine by inspection.
> 
> The only one I'm not sure about is shmobile, which looks like it might
> suffer from the same problem. Simon/Magnus, could you verify this
> with a multiplatform kernel on any SoC that has GIC and uses devices
> that have interrupts defined in setup-*.c or board-*.c?

There are 3 patches floating around for shmobile, converting their
non-DT support to directly initializing the GIC instead of relying on
irqchip_init(). That's assuming their DT implementation doesn't use any
of these device declarations.

If they do, we could use a hack similar to the one I implemented for
OMAP, populating the virtual IRQ in the resource at boot time, just
after the irqchip initialization.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: Regression with legacy IRQ numbers caused by 9a1091ef0017
Date: Fri, 16 Jan 2015 17:23:05 +0000	[thread overview]
Message-ID: <54B948F9.2060100@arm.com> (raw)
In-Reply-To: <3822486.YZLIqXdAgt@wuerfel>

On 16/01/15 16:56, Arnd Bergmann wrote:
> On Thursday 15 January 2015 07:37:48 Tony Lindgren wrote:
>> * Marc Zyngier <marc.zyngier@arm.com> [150115 06:46]:
>>> On Thu, Jan 15 2015 at  2:27:56 pm GMT, Arnd Bergmann <arnd@arndb.de> wrote:
>>>> On Thursday 15 January 2015 13:42:57 Marc Zyngier wrote:
>>> Probably there is a workable strategy, but my knowledge about OMAP is
>>> close to *nothing*...
>>
>> I have a feeling this might bite other platforms too and we just have
>> not noticed it yet..
> 
> I'm looking through the entire tree now, scanning for machines that have
> GIC and use IORESOURCE_IRQ or DEFINE_RES_IRQ in their platform code.
> Most platforms using GIC are completely converted to DT and have no
> hardcoded legacy IRQs.
> 
> I have checked that cns3xxx and realview are both fine by inspection.
> 
> The only one I'm not sure about is shmobile, which looks like it might
> suffer from the same problem. Simon/Magnus, could you verify this
> with a multiplatform kernel on any SoC that has GIC and uses devices
> that have interrupts defined in setup-*.c or board-*.c?

There are 3 patches floating around for shmobile, converting their
non-DT support to directly initializing the GIC instead of relying on
irqchip_init(). That's assuming their DT implementation doesn't use any
of these device declarations.

If they do, we could use a hack similar to the one I implemented for
OMAP, populating the virtual IRQ in the resource at boot time, just
after the irqchip initialization.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2015-01-16 17:23 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 22:14 Regression with legacy IRQ numbers caused by 9a1091ef0017 Tony Lindgren
2015-01-14 22:14 ` Tony Lindgren
2015-01-15 10:50 ` Russell King - ARM Linux
2015-01-15 10:50   ` Russell King - ARM Linux
2015-01-15 15:28   ` Tony Lindgren
2015-01-15 15:28     ` Tony Lindgren
2015-01-15 17:19     ` Russell King - ARM Linux
2015-01-15 17:19       ` Russell King - ARM Linux
2015-01-16 16:21       ` Tony Lindgren
2015-01-16 16:21         ` Tony Lindgren
2015-01-16 16:30         ` Russell King - ARM Linux
2015-01-16 16:30           ` Russell King - ARM Linux
2015-01-16 16:41           ` Tony Lindgren
2015-01-16 16:41             ` Tony Lindgren
2015-01-16 16:46             ` Felipe Balbi
2015-01-16 16:46               ` Felipe Balbi
2015-01-16 17:22             ` Russell King - ARM Linux
2015-01-16 17:22               ` Russell King - ARM Linux
2015-01-16 17:29               ` Tony Lindgren
2015-01-16 17:29                 ` Tony Lindgren
2015-01-16 22:52                 ` Tony Lindgren
2015-01-16 22:52                   ` Tony Lindgren
2015-01-16 22:57                   ` Russell King - ARM Linux
2015-01-16 22:57                     ` Russell King - ARM Linux
2015-01-16 22:57                     ` Tony Lindgren
2015-01-16 22:57                       ` Tony Lindgren
2015-01-15 13:42 ` Marc Zyngier
2015-01-15 13:42   ` Marc Zyngier
2015-01-15 14:27   ` Arnd Bergmann
2015-01-15 14:27     ` Arnd Bergmann
2015-01-15 14:43     ` Marc Zyngier
2015-01-15 14:43       ` Marc Zyngier
2015-01-15 15:37       ` Tony Lindgren
2015-01-15 15:37         ` Tony Lindgren
2015-01-16 16:56         ` Arnd Bergmann
2015-01-16 16:56           ` Arnd Bergmann
2015-01-16 17:23           ` Marc Zyngier [this message]
2015-01-16 17:23             ` Marc Zyngier
2015-01-17  0:48             ` Simon Horman
2015-01-17  0:48               ` Simon Horman
2015-01-15 16:37       ` Arnd Bergmann
2015-01-15 16:37         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B948F9.2060100@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=arnd@arndb.de \
    --cc=balbi@ti.com \
    --cc=horms+renesas@verge.net.au \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.