[PATCH 1/3] ionice: drop the duplicate docstring

[PATCH 1/3] ionice: drop the duplicate docstring

[Benno Schulenberg]

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
---
 schedutils/ionice.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/schedutils/ionice.c b/schedutils/ionice.c
index fb5d04a..5528afe 100644
--- a/schedutils/ionice.c
+++ b/schedutils/ionice.c
@@ -100,8 +100,6 @@ static void ioprio_setid(int which, int ioclass, int data, int who)
 
 static void __attribute__ ((__noreturn__)) usage(FILE * out)
 {
-	fputs(_("\nSets or gets the IO scheduling class and priority of processes.\n"), out);
-
 	fputs(USAGE_HEADER, out);
 	fprintf(out,  _(" %1$s [options] -p <pid>...\n"
 			" %1$s [options] -P <pgid>...\n"
-- 
1.7.0.4

[PATCH 2/3] docs: fix two spellings in man page of logger

[Benno Schulenberg]

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
---
 misc-utils/logger.1 |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/misc-utils/logger.1 b/misc-utils/logger.1
index 235331e..ff81fce 100644
--- a/misc-utils/logger.1
+++ b/misc-utils/logger.1
@@ -130,7 +130,7 @@ The optional \fIwithout\fR argument can be a comma-separated list of
 the following values: \fBnotq\fR, \fBnotime\fR, \fBnohost\fR.
 The \fBnotq\fR value suppresses the time-quality structured data
 from the submitted message.  (The time-quality information shows whether
-the local clock was syncronized plus the maximum number of microseconds
+the local clock was synchronized plus the maximum number of microseconds
 the timestamp might be off.)  The \fBnotime\fR value (which implies
 \fBnotq\fR) suppresses the complete sender timestamp that is in
 ISO-8601 format, including microseconds and timezone.
@@ -138,7 +138,7 @@ The \fBnohost\fR value suppresses
 .BR gethostname (2)
 information from the message header.
 .IP
-The rfc5424 protocol has been default for
+The RFC 5424 protocol has been the default for
 .B logger
 since version 2.26.
 .TP
-- 
1.7.0.4

[PATCH 3/3] textual: put option and its description into a single translatable string

[Benno Schulenberg]

Also improve the description: notime, notq, and nohost are literals,
not things to be replaced by something else -- so no angular brackets.

Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
---
 misc-utils/logger.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/misc-utils/logger.c b/misc-utils/logger.c
index 35caf9d..296f7f0 100644
--- a/misc-utils/logger.c
+++ b/misc-utils/logger.c
@@ -525,8 +525,8 @@ static void __attribute__ ((__noreturn__)) usage(FILE *out)
 	fputs(_(" -T, --tcp             use TCP only\n"), out);
 	fputs(_(" -d, --udp             use UDP only\n"), out);
 	fputs(_("     --rfc3164         use the obsolete BSD syslog protocol\n"), out);
-	fputs(_("     --rfc5424[=<notime,notq,nohost>]\n"), out);
-	fputs(_("                       use the syslog protocol (default)\n"), out);
+	fputs(_("     --rfc5424[=<cut>] use the syslog protocol (the default);\n"
+		"                         <cut> can be notime, or notq, and/or nohost\n"), out);
 	fputs(_(" -u, --socket <socket> write to this Unix socket\n"), out);
 #ifdef HAVE_LIBSYSTEMD
 	fputs(_("     --journald[=<file>]  write journald entry\n"), out);
-- 
1.7.0.4

Re: [PATCH 3/3] textual: put option and its description into a single translatable string

[JWP]

On 01/18/2015 03:40 PM, Benno Schulenberg wrote:
> Also improve the description: notime, notq, and nohost are literals,
> not things to be replaced by something else -- so no angular brackets.
> 
> Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
> ---
>  misc-utils/logger.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/misc-utils/logger.c b/misc-utils/logger.c
> index 35caf9d..296f7f0 100644
> --- a/misc-utils/logger.c
> +++ b/misc-utils/logger.c
> @@ -525,8 +525,8 @@ static void __attribute__ ((__noreturn__)) usage(FILE *out)
>  	fputs(_(" -T, --tcp             use TCP only\n"), out);
>  	fputs(_(" -d, --udp             use UDP only\n"), out);
>  	fputs(_("     --rfc3164         use the obsolete BSD syslog protocol\n"), out);
> -	fputs(_("     --rfc5424[=<notime,notq,nohost>]\n"), out);
> -	fputs(_("                       use the syslog protocol (default)\n"), out);
> +	fputs(_("     --rfc5424[=<cut>] use the syslog protocol (the default);\n"
> +		"                         <cut> can be notime, or notq, and/or nohost\n"), out);

I have never see that done before, it seems confusing.
Isn't the commonly used term 'snip'?



>  	fputs(_(" -u, --socket <socket> write to this Unix socket\n"), out);
>  #ifdef HAVE_LIBSYSTEMD
>  	fputs(_("     --journald[=<file>]  write journald entry\n"), out);
> 

Re: [PATCH 1/3] ionice: drop the duplicate docstring

[Karel Zak]

On Sun, Jan 18, 2015 at 09:40:29PM +0100, Benno Schulenberg wrote:
>  schedutils/ionice.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)

 All 3 patches applied. Thanks!

    Karel
    
-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [PATCH 3/3] textual: put option and its description into a single translatable string

[Karel Zak]

On Sun, Jan 18, 2015 at 04:02:49PM -0500, JWP wrote:
> On 01/18/2015 03:40 PM, Benno Schulenberg wrote:
> > Also improve the description: notime, notq, and nohost are literals,
> > not things to be replaced by something else -- so no angular brackets.
> > 
> > Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
> > ---
> >  misc-utils/logger.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/misc-utils/logger.c b/misc-utils/logger.c
> > index 35caf9d..296f7f0 100644
> > --- a/misc-utils/logger.c
> > +++ b/misc-utils/logger.c
> > @@ -525,8 +525,8 @@ static void __attribute__ ((__noreturn__)) usage(FILE *out)
> >  	fputs(_(" -T, --tcp             use TCP only\n"), out);
> >  	fputs(_(" -d, --udp             use UDP only\n"), out);
> >  	fputs(_("     --rfc3164         use the obsolete BSD syslog protocol\n"), out);
> > -	fputs(_("     --rfc5424[=<notime,notq,nohost>]\n"), out);
> > -	fputs(_("                       use the syslog protocol (default)\n"), out);
> > +	fputs(_("     --rfc5424[=<cut>] use the syslog protocol (the default);\n"
> > +		"                         <cut> can be notime, or notq, and/or nohost\n"), out);
> 
> I have never see that done before, it seems confusing.
> Isn't the commonly used term 'snip'?

 Yes, I have replaced <cut> with <snip>.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com