Re: [PATCH v2 3/3] xen/arm: Find automatically a PPI for the DOM0 event channel interrupt

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 19/01/15 16:04, Ian Campbell wrote:
> On Thu, 2015-01-15 at 20:23 +0000, Julien Grall wrote:
> 
> Subject should be "Automatically find..."
> 
>> Use the new vgic interface to know which virtual PPI is free and use it
>> for the event channel code.
>>
>> At the DOM0 creation time, Xen still don't know which vIRQ will be free.
> 
> "...Xen still doesn't know..." or just "... Xen doesn't know..."

I will use the second suggestion.

> 
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index 3d4f317..d5959b5 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -627,6 +627,16 @@ static int make_hypervisor_node(struct domain *d,
> 
> I'd prefer this not to be done in make_hypervisor_node, to keep
> make_*_node purely about creating the DT, without other side effects, as
> far as possible.
> 
> I think you can drop a placeholder here and update it around the time of
> the calls to kernel_load and initrd_load from a new helper function
> which allocates and updates. initrd_load does something similar.

I will give a look.

Regards,

-- 
Julien Grall